From: sys_stv@intel.com
To: johndale@cisco.com, test-report@dpdk.org
Subject: [dpdk-test-report] [PatchWork]|ERROR| pw12925-12935 enic: fix Rx drop counters
Date: 22 May 2016 20:18:46 -0700 [thread overview]
Message-ID: <9c8bee$svbq5e@fmsmga001.fm.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 12925-12935
http://www.dpdk.org/dev/patchwork/patch/12935/
Submitter: John Daley <johndale@cisco.com>
Date: Fri, 20 May 2016 12:04:04 -0700
DPDK git baseline: 587d684d70f9d7f74e77a886c58103b40409caea
Check patch error:
12933:
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#598: FILE: drivers/net/enic/enic_rxtx.c:2:
+/*
+ * Copyright 2008-2014 Cisco Systems, Inc. All rights reserved.
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#644: FILE: drivers/net/enic/enic_rxtx.c:48:
+/*
+ * Prefetch a cache line into all cache levels.
ERROR: return is not a function, parentheses are not required
#666: FILE: drivers/net/enic/enic_rxtx.c:70:
+ return(le16_to_cpu(crd->bytes_written_flags) &
ERROR: space required before the open parenthesis '('
#673: FILE: drivers/net/enic/enic_rxtx.c:77:
+ return((bwflags & CQ_ENET_RQ_DESC_FLAGS_TRUNCATED) ==
ERROR: space required before the open parenthesis '('
#702: FILE: drivers/net/enic/enic_rxtx.c:106:
+ return((cqrd->flags & CQ_ENET_RQ_DESC_FLAGS_TCP_UDP_CSUM_OK) ==
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#746: FILE: drivers/net/enic/enic_rxtx.c:150:
+/*
+ * Lookup table to translate RX CQ flags to mbuf flags.
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#841: FILE: drivers/net/enic/enic_rxtx.c:245:
+ volatile struct cq_desc *cqd_ptr;
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#851: FILE: drivers/net/enic/enic_rxtx.c:255:
+ volatile struct rq_enet_desc *rqd_ptr;
total: 3 errors, 5 warnings, 679 lines checked
/home/patchWorkOrg/patches/dpdk-dev-04-11-enic-Tx-cleanup---put-Tx-and-Rx-functions-into-same-file.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
reply other threads:[~2016-05-23 3:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9c8bee$svbq5e@fmsmga001.fm.intel.com' \
--to=sys_stv@intel.com \
--cc=johndale@cisco.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).