Test-Label: Intel Niantic on Fedora Test-Status: ERROR Patchwork ID: 12925-12935 http://www.dpdk.org/dev/patchwork/patch/12935/ Submitter: John Daley Date: Fri, 20 May 2016 12:04:04 -0700 DPDK git baseline: 587d684d70f9d7f74e77a886c58103b40409caea Check patch error: 12933: WARNING: networking block comments don't use an empty /* line, use /* Comment... #598: FILE: drivers/net/enic/enic_rxtx.c:2: +/* + * Copyright 2008-2014 Cisco Systems, Inc. All rights reserved. WARNING: networking block comments don't use an empty /* line, use /* Comment... #644: FILE: drivers/net/enic/enic_rxtx.c:48: +/* + * Prefetch a cache line into all cache levels. ERROR: return is not a function, parentheses are not required #666: FILE: drivers/net/enic/enic_rxtx.c:70: + return(le16_to_cpu(crd->bytes_written_flags) & ERROR: space required before the open parenthesis '(' #673: FILE: drivers/net/enic/enic_rxtx.c:77: + return((bwflags & CQ_ENET_RQ_DESC_FLAGS_TRUNCATED) == ERROR: space required before the open parenthesis '(' #702: FILE: drivers/net/enic/enic_rxtx.c:106: + return((cqrd->flags & CQ_ENET_RQ_DESC_FLAGS_TCP_UDP_CSUM_OK) == WARNING: networking block comments don't use an empty /* line, use /* Comment... #746: FILE: drivers/net/enic/enic_rxtx.c:150: +/* + * Lookup table to translate RX CQ flags to mbuf flags. WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #841: FILE: drivers/net/enic/enic_rxtx.c:245: + volatile struct cq_desc *cqd_ptr; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #851: FILE: drivers/net/enic/enic_rxtx.c:255: + volatile struct rq_enet_desc *rqd_ptr; total: 3 errors, 5 warnings, 679 lines checked /home/patchWorkOrg/patches/dpdk-dev-04-11-enic-Tx-cleanup---put-Tx-and-Rx-functions-into-same-file.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Compilation: OS: fedora Nic: niantic GCC: gcc_x86-64, 4.8.3 ICC:16.0.2 i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass DPDK STV team