Test-Label: Intel Niantic on Fedora Test-Status: ERROR Patchwork ID: 13059-13078 http://www.dpdk.org/dev/patchwork/patch/13078/ Submitter: Jerin Jacob Date: Sun, 29 May 2016 22:16:45 +0530 DPDK git baseline: c8c33ad7f94c59d1c0676af0cfd61207b3e808db Check patch error: 13059: WARNING: networking block comments don't use an empty /* line, use /* Comment... #53: FILE: drivers/net/thunderx/base/nicvf_hw.c:2: +/* + * BSD LICENSE ERROR: return is not a function, parentheses are not required #320: FILE: drivers/net/thunderx/base/nicvf_hw.c:269: +return (*(const uint32_t *)a - *(const uint32_t *)b); WARNING: networking block comments don't use an empty /* line, use /* Comment... #394: FILE: drivers/net/thunderx/base/nicvf_hw.c:343: +/* + * Handle poll mode driver interested "mbox" and "queue-set error" interrupts. WARNING: networking block comments don't use an empty /* line, use /* Comment... #967: FILE: drivers/net/thunderx/base/nicvf_hw.h:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #1213: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:2: +/* + * BSD LICENSE WARNING: do not add new typedefs #1750: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:539: +typedef uint64_t nicvf_phys_addr_t; WARNING: do not add new typedefs #1761: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:550: +typedef union { WARNING: do not add new typedefs #1806: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:595: +typedef union { WARNING: do not add new typedefs #1831: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:620: +typedef union { WARNING: do not add new typedefs #1848: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:637: +typedef union { WARNING: do not add new typedefs #1865: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:654: +typedef union { WARNING: do not add new typedefs #1882: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:671: +typedef union { WARNING: do not add new typedefs #1899: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:688: +typedef union { ERROR: spaces prohibited around that ':' (ctx:VxW) #2336: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:1125: +uint64_t ena: 1; ^ WARNING: networking block comments don't use an empty /* line, use /* Comment... #2435: FILE: drivers/net/thunderx/base/nicvf_mbox.c:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #2628: FILE: drivers/net/thunderx/base/nicvf_mbox.c:195: +/* + * Checks if VF is able to communicate with PF WARNING: networking block comments don't use an empty /* line, use /* Comment... #2857: FILE: drivers/net/thunderx/base/nicvf_mbox.h:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #3095: FILE: drivers/net/thunderx/base/nicvf_plat.h:2: +/* + * BSD LICENSE ERROR: space prohibited before open square bracket '[' #3176: FILE: drivers/net/thunderx/base/nicvf_plat.h:83: + : [val] "r" (val), [addr] "r" (addr)); ERROR: space prohibited before open square bracket '[' #3186: FILE: drivers/net/thunderx/base/nicvf_plat.h:93: + : [val] "=r" (val) ERROR: space prohibited before open square bracket '[' #3187: FILE: drivers/net/thunderx/base/nicvf_plat.h:94: + : [addr] "r" (addr)); ERROR: space prohibited before open square bracket '[' #3194: FILE: drivers/net/thunderx/base/nicvf_plat.h:101: +: [x1]"=r"(reg1), [x0]"=r"(reg2) ERROR: space prohibited before open square bracket '[' #3195: FILE: drivers/net/thunderx/base/nicvf_plat.h:102: +: [p1]"r"(addr) WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #3205: FILE: drivers/net/thunderx/base/nicvf_plat.h:112: +*(volatile uint64_t *)addr = val; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #3211: FILE: drivers/net/thunderx/base/nicvf_plat.h:118: +return*(volatile uint64_t *)addr; total: 7 errors, 18 warnings, 3144 lines checked /home/patchWorkOrg/patches/dpdk-dev-v2-01-20-thunderx-nicvf-base-add-hardware-API-for-ThunderX-nicvf-inbuilt-NIC.patch has style problems, please review. 13070: WARNING: networking block comments don't use an empty /* line, use /* Comment... #83: FILE: drivers/net/thunderx/nicvf_rxtx.c:2: +/* + * BSD LICENSE ERROR: return is not a function, parentheses are not required #221: FILE: drivers/net/thunderx/nicvf_rxtx.c:140: + return ((sq->head - sq->tail - 1) & sq->qlen_mask); WARNING: networking block comments don't use an empty /* line, use /* Comment... #345: FILE: drivers/net/thunderx/nicvf_rxtx.h:2: +/* + * BSD LICENSE ERROR: code indent should use tabs where possible #422: FILE: drivers/net/thunderx/nicvf_rxtx.h:79: + entry->buff[0] = (uint64_t)SQ_DESC_TYPE_GATHER << 60 |$ WARNING: please, no spaces at the start of a line #422: FILE: drivers/net/thunderx/nicvf_rxtx.h:79: + entry->buff[0] = (uint64_t)SQ_DESC_TYPE_GATHER << 60 |$ ERROR: code indent should use tabs where possible #425: FILE: drivers/net/thunderx/nicvf_rxtx.h:82: + entry->buff[1] = rte_mbuf_data_dma_addr(pkt);$ WARNING: please, no spaces at the start of a line #425: FILE: drivers/net/thunderx/nicvf_rxtx.h:82: + entry->buff[1] = rte_mbuf_data_dma_addr(pkt);$ total: 3 errors, 4 warnings, 378 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile /home/patchWorkOrg/patches/dpdk-dev-v2-12-20-thunderx-nicvf-add-single-and-multi-segment-tx-functions.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Compilation: OS: fedora Nic: niantic GCC: gcc_x86-64, 4.8.3 ICC:16.0.2 i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass DPDK STV team