[dpdk-test-report] [PatchWork]|ERROR| pw13531-13546 vfio: fix include of eal_private.h to be local

[dpdk-test-report] [PatchWork]|ERROR| pw13531-13546 vfio: fix include of eal_private.h to be local

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 6085 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13531-13546
http://www.dpdk.org/dev/patchwork/patch/13546/
Submitter: Jan Viktorin <viktorin@rehivetech.com>
Date: Mon, 13 Jun 2016 15:01:51 +0200
DPDK git baseline: dd9ae4c7b302dffd9b3dac849f4da8badac91719

Check patch error:
13540: 
ERROR: do not use assignment in if condition
#345: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:326:
+	if ((ret = vfio_setup_device(SYSFS_PCI_DEVICES, pci_addr,

WARNING: line over 80 characters
#452: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:73:
+				RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,

WARNING: line over 80 characters
#463: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:84:
+					RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,

WARNING: line over 80 characters
#474: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:95:
+			RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!
");

WARNING: line over 80 characters
#478: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:99:
+		vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].group_no = 
+iommu_group_no;

WARNING: line over 80 characters
#479: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:100:
+		vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].fd = vfio_group_fd;

WARNING: line over 80 characters
#491: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:112:
+			RTE_LOG(ERR, EAL, "  cannot connect to primary process!
");

WARNING: line over 80 characters
#494: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:115:
+		if (vfio_mp_sync_send_request(socket_fd, SOCKET_REQ_GROUP) < 0) {

WARNING: line over 80 characters
#546: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:167:
+		RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#566: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:187:
+		RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#576: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:197:
+	 * at this point, we know that this group is viable (meaning, all 
+devices

WARNING: line over 80 characters
#584: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:205:
+				"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#584: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:205:
+		RTE_LOG(ERR, EAL, "  %s cannot get group status, "
+				"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: line over 80 characters
#602: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:223:
+			RTE_LOG(ERR, EAL, "  %s cannot add VFIO group to container, "

WARNING: line over 80 characters
#603: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:224:
+					"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#603: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:224:
+			RTE_LOG(ERR, EAL, "  %s cannot add VFIO group to container, "
+					"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: line over 80 characters
#610: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:231:
+		 * initialized, so we increment vfio_group_idx to indicate that we 
+can

WARNING: line over 80 characters
#619: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:240:
+	 * needs to be done only once, only when at least one group is 
+assigned to

WARNING: line over 80 characters
#628: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:249:
+			RTE_LOG(ERR, EAL, "  %s failed to select IOMMU type
", dev_addr);

WARNING: line over 80 characters
#634: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:255:
+					"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#634: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:255:
+			RTE_LOG(ERR, EAL, "  %s DMA remapping failed, "
+					"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: line over 80 characters
#646: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:267:
+		RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#655: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:276:
+				"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#655: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:276:
+		RTE_LOG(ERR, EAL, "  %s cannot get device info, "
+				"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#690: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:311:
+		RTE_LOG(DEBUG, EAL, "VFIO modules not loaded, "
+			"skipping VFIO support...
");

total: 1 errors, 24 warnings, 659 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v2-11-16-vfio-move-global-vfio_cfg-to-eal_vfio.c.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13541: 
WARNING: line over 80 characters
#90: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:464:
+	 * at this point, we know that this group is viable (meaning, all 
+devices

WARNING: line over 80 characters
#148: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:564:
+	struct mapped_pci_res_list *vfio_res_list = 
+RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list);

ERROR: do not use assignment in if condition
#162: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:578:
+	if ((ret = pci_vfio_setup_device(pci_addr, &vfio_dev_fd, 
+&device_info)))

total: 1 errors, 2 warnings, 127 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v2-10-16-vfio-extract-setup-logic-out-of-pci_vfio_map_resource.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team