[dpdk-test-report] [PatchWork]|ERROR| pw13902-13904 mempool: deprecate specific get/put functions

[dpdk-test-report] [PatchWork]|ERROR| pw13902-13904 mempool: deprecate specific get/put functions

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 3796 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13902-13904
http://www.dpdk.org/dev/patchwork/patch/13904/
Submitter: Lazaros Koromilas <l@nofutznetworks.com>
Date: Thu, 16 Jun 2016 12:02:17 +0100
DPDK git baseline: 3901ed99c2f82d3e979bb1bea001d61898241829

Check patch error:
13904: 
WARNING: Single statement macros should not use a do {} while (0) loop
#49: FILE: app/test/test_mempool.c:82:
+#define LOG_ERR() do {							+		printf("test failed at %s():%d
", __func__, __LINE__); +	} while (0)

WARNING: line over 80 characters
#283: FILE: app/test/test_mempool_perf.c:181:
+				ret = rte_mempool_generic_get(mp, &obj_table[idx],

ERROR: code indent should use tabs where possible
#328: FILE: app/test/test_mempool_perf.c:233:
+^I           external_cache_size : (unsigned) mp->cache_size,$

ERROR: "foo * bar" should be "foo *bar"
#556: FILE: lib/librte_mempool/rte_mempool.h:996:
+static inline struct rte_mempool_cache * __attribute__((always_inline))

WARNING: line over 80 characters
#779: FILE: lib/librte_mempool/rte_mempool.h:1370:
+	return rte_mempool_generic_get(mp, obj_table, n, NULL, 
+MEMPOOL_F_SC_GET);

total: 2 errors, 3 warnings, 748 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-v3-3-3-mempool-allow-for-user-owned-mempool-caches.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


patch file error:
13904: 
patching file app/test/test_mempool.c
Hunk #2 succeeded at 101 (offset -93 lines).
Hunk #3 succeeded at 109 (offset -93 lines).
Hunk #4 succeeded at 189 (offset -93 lines).
Hunk #5 succeeded at 218 (offset -93 lines).
Hunk #6 succeeded at 558 (offset -117 lines).
patching file app/test/test_mempool_perf.c Hunk #4 FAILED at 178.
Hunk #5 succeeded at 192 (offset 1 line).
Hunk #6 succeeded at 203 (offset 1 line).
Hunk #7 succeeded at 228 (offset 1 line).
Hunk #8 succeeded at 354 (offset 1 line).
1 out of 8 hunks FAILED -- saving rejects to file app/test/test_mempool_perf.c.rej patching file lib/librte_mempool/rte_mempool.c Hunk #1 succeeded at 707 (offset 34 lines).
Hunk #2 succeeded at 768 (offset 34 lines).
Hunk #3 succeeded at 849 (offset 34 lines).
Hunk #4 succeeded at 862 with fuzz 2 (offset 34 lines).
Hunk #5 succeeded at 1010 (offset 20 lines).
Hunk #6 succeeded at 1018 (offset 20 lines).
Hunk #7 succeeded at 1138 (offset 20 lines).
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 100 (offset -1 lines).
Hunk #2 succeeded at 210 with fuzz 2 (offset -4 lines).
Hunk #3 succeeded at 724 (offset -218 lines).
Hunk #4 succeeded at 796 (offset -218 lines).
Hunk #5 FAILED at 1053.
Hunk #6 succeeded at 873 (offset -209 lines).
Hunk #7 succeeded at 902 (offset -209 lines).
Hunk #8 succeeded at 922 (offset -209 lines).
Hunk #9 succeeded at 943 (offset -209 lines).
Hunk #10 succeeded at 960 (offset -209 lines).
Hunk #11 succeeded at 977 (offset -209 lines).
Hunk #12 succeeded at 1006 (offset -209 lines).
Hunk #13 succeeded at 1017 with fuzz 1 (offset -209 lines).
Hunk #14 succeeded at 1090 (offset -207 lines).
Hunk #15 succeeded at 1101 (offset -207 lines).
Hunk #16 succeeded at 1132 (offset -207 lines).
Hunk #17 succeeded at 1160 (offset -207 lines).
Hunk #18 succeeded at 1188 (offset -207 lines).
Hunk #19 succeeded at 1213 (offset -207 lines).
Hunk #20 succeeded at 1238 (offset -207 lines).
Hunk #21 succeeded at 1272 (offset -207 lines).
Hunk #22 succeeded at 1291 (offset -207 lines).
Hunk #23 succeeded at 1309 (offset -207 lines).
Hunk #24 succeeded at 1328 (offset -207 lines).
1 out of 24 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej

DPDK STV team