[dpdk-test-report] [PatchWork]|ERROR| pw13945-13947 kasumi: add new KASUMI PMD

[dpdk-test-report] [PatchWork]|ERROR| pw13945-13947 kasumi: add new KASUMI PMD

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 5207 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13945-13947
http://www.dpdk.org/dev/patchwork/patch/13947/
Submitter: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Fri, 17 Jun 2016 11:32:43 +0100
DPDK git baseline: 8688b18a997ecb8938a4e86f14407967fa1b6a0e

Check patch error:
13945: 
WARNING: line over 80 characters
#714: FILE: drivers/crypto/kasumi/rte_kasumi_pmd.c:275:
+		if (unlikely(ops[i]->sym->auth.aad.length != KASUMI_IV_LENGTH)) {

WARNING: line over 80 characters
#720: FILE: drivers/crypto/kasumi/rte_kasumi_pmd.c:281:
+		if (unlikely(ops[i]->sym->auth.digest.length != 
+KASUMI_DIGEST_LENGTH)) {

WARNING: line over 80 characters
#754: FILE: drivers/crypto/kasumi/rte_kasumi_pmd.c:315:
+				ops[i]->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;

WARNING: line over 80 characters
#906: FILE: drivers/crypto/kasumi/rte_kasumi_pmd.c:467:
+		/* If length/offset is at bit-level, process this buffer alone. */

WARNING: quoted string split across lines
#1084: FILE: drivers/crypto/kasumi/rte_kasumi_pmd.c:645:
+	RTE_LOG(INFO, PMD, "Closing KASUMI crypto device %s"
+			" on numa socket %u
",

WARNING: quoted string split across lines
#1309: FILE: drivers/crypto/kasumi/rte_kasumi_pmd_ops.c:206:
+			KASUMI_LOG_INFO("Reusing existing ring %s"
+					" for processed packets",

WARNING: quoted string split across lines
#1315: FILE: drivers/crypto/kasumi/rte_kasumi_pmd_ops.c:212:
+		KASUMI_LOG_ERR("Unable to reuse existing ring %s"
+				" for processed packets",

ERROR: return is not a function, parentheses are not required
#1340: FILE: drivers/crypto/kasumi/rte_kasumi_pmd_ops.c:237:
+		return (-ENOMEM);

WARNING: line over 80 characters
#1595: FILE: examples/l2fwd-crypto/main.c:471:
+		/* For SNOW3G/KASUMI algorithms, offset/length must be in bits */

WARNING: line over 80 characters
#1597: FILE: examples/l2fwd-crypto/main.c:473:
+				cparams->auth_algo == RTE_CRYPTO_AUTH_KASUMI_F9) {

WARNING: line over 80 characters
#1607: FILE: examples/l2fwd-crypto/main.c:495:
+				cparams->cipher_algo == RTE_CRYPTO_CIPHER_KASUMI_F8) {

total: 1 errors, 10 warnings, 1549 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v2-1-3-kasumi-add-new-KASUMI-PMD.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13947: 
ERROR: return is not a function, parentheses are not required
#46: FILE: app/test/test_cryptodev.c:122:
+		return ((num_bits >> 3) + 1);

ERROR: return is not a function, parentheses are not required
#48: FILE: app/test/test_cryptodev.c:124:
+		return (num_bits >> 3);

WARNING: line over 80 characters
#477: FILE: app/test/test_cryptodev.c:1957:
+			+ plaintext_pad_len + ALIGN_POW2_ROUNDUP(tdata->aad.len, 8);

WARNING: line over 80 characters
#764: FILE: app/test/test_cryptodev.c:2225:
+	retval = create_kasumi_cipher_operation_oop(tdata->iv.data, 
+tdata->iv.len,

WARNING: line over 80 characters
#861: FILE: app/test/test_cryptodev.c:2290:
+	retval = create_kasumi_cipher_operation_oop(tdata->iv.data, 
+tdata->iv.len,

total: 2 errors, 3 warnings, 1693 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v2-3-3-test-add-unit-tests-for-KASUMI-PMD.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


patch file error:
13945: 
patching file MAINTAINERS
patching file config/common_base
patching file config/defconfig_i686-native-linuxapp-gcc
patching file config/defconfig_i686-native-linuxapp-icc
patching file doc/guides/cryptodevs/index.rst patching file doc/guides/cryptodevs/kasumi.rst patching file doc/guides/cryptodevs/overview.rst
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file doc/guides/cryptodevs/overview.rst.rej
patching file doc/guides/rel_notes/release_16_07.rst
Hunk #1 succeeded at 81 with fuzz 2 (offset 11 lines).
patching file drivers/crypto/Makefile
patching file drivers/crypto/kasumi/Makefile patching file drivers/crypto/kasumi/rte_kasumi_pmd.c
patching file drivers/crypto/kasumi/rte_kasumi_pmd_ops.c
patching file drivers/crypto/kasumi/rte_kasumi_pmd_private.h
patching file drivers/crypto/kasumi/rte_pmd_kasumi_version.map
patching file examples/l2fwd-crypto/main.c patching file lib/librte_cryptodev/rte_crypto_sym.h
patching file lib/librte_cryptodev/rte_cryptodev.h
patching file mk/rte.app.mk
Hunk #1 succeeded at 135 (offset 1 line).
patching file scripts/test-build.sh

13947: 
patching file app/test/test_cryptodev.c
Hunk #1 FAILED at 44.
Hunk #2 succeeded at 133 with fuzz 2 (offset 21 lines).
Hunk #3 succeeded at 253 (offset 30 lines).
Hunk #4 succeeded at 2344 (offset 1227 lines).
Hunk #5 succeeded at 2765 (offset 1234 lines).
Hunk #6 succeeded at 3026 (offset 1241 lines).
Hunk #7 succeeded at 4116 (offset 1255 lines).
Hunk #8 succeeded at 5452 (offset 1422 lines).
Hunk #9 succeeded at 5645 (offset 1422 lines).
1 out of 9 hunks FAILED -- saving rejects to file app/test/test_cryptodev.c.rej patching file app/test/test_cryptodev.h patching file app/test/test_cryptodev_kasumi_hash_test_vectors.h
patching file app/test/test_cryptodev_kasumi_test_vectors.h

DPDK STV team