[dpdk-test-report] [PatchWork]|ERROR| pw13948 hash: new function to retrieve a key given its position

[dpdk-test-report] [PatchWork]|ERROR| pw13948 hash: new function to retrieve a key given its position

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 3751 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13948
http://www.dpdk.org/dev/patchwork/patch/13948/
Submitter: Yari Adan Petralanda <yari.adan.petralanda@ericsson.com>
Date: Fri, 17 Jun 2016 12:59:43 +0200
DPDK git baseline: 8688b18a997ecb8938a4e86f14407967fa1b6a0e

Check patch error:
13948: 
ERROR: trailing whitespace
#40: FILE: app/test/test_hash.c:424:
+ * Sequence of operations for retrieving a key with its position $

ERROR: code indent should use tabs where possible
#102: FILE: lib/librte_hash/rte_cuckoo_hash.c:978:
+                                void **key)$

WARNING: please, no spaces at the start of a line
#102: FILE: lib/librte_hash/rte_cuckoo_hash.c:978:
+                                void **key)$

ERROR: code indent should use tabs where possible
#104: FILE: lib/librte_hash/rte_cuckoo_hash.c:980:
+        RETURN_IF_TRUE(((h == NULL) || (key == NULL)), -EINVAL);$

WARNING: please, no spaces at the start of a line
#104: FILE: lib/librte_hash/rte_cuckoo_hash.c:980:
+        RETURN_IF_TRUE(((h == NULL) || (key == NULL)), -EINVAL);$

ERROR: code indent should use tabs where possible
#106: FILE: lib/librte_hash/rte_cuckoo_hash.c:982:
+        struct rte_hash_key *k, *keys = h->key_store;$

WARNING: please, no spaces at the start of a line
#106: FILE: lib/librte_hash/rte_cuckoo_hash.c:982:
+        struct rte_hash_key *k, *keys = h->key_store;$

WARNING: line over 80 characters
#107: FILE: lib/librte_hash/rte_cuckoo_hash.c:983:
+        k = (struct rte_hash_key *) ((char *) keys + (position + 1) * 
+ h->key_entry_size);

ERROR: code indent should use tabs where possible
#107: FILE: lib/librte_hash/rte_cuckoo_hash.c:983:
+        k = (struct rte_hash_key *) ((char *) keys + (position + 1) * 
+ h->key_entry_size);$

WARNING: please, no spaces at the start of a line
#107: FILE: lib/librte_hash/rte_cuckoo_hash.c:983:
+        k = (struct rte_hash_key *) ((char *) keys + (position + 1) * 
+ h->key_entry_size);$

ERROR: code indent should use tabs where possible
#108: FILE: lib/librte_hash/rte_cuckoo_hash.c:984:
+        *key = k->key;$

WARNING: please, no spaces at the start of a line
#108: FILE: lib/librte_hash/rte_cuckoo_hash.c:984:
+        *key = k->key;$

WARNING: line over 80 characters
#111: FILE: lib/librte_hash/rte_cuckoo_hash.c:987:
+		__rte_hash_lookup_with_hash(h, *key, rte_hash_hash(h, *key), NULL)) {

ERROR: code indent should use tabs where possible
#115: FILE: lib/librte_hash/rte_cuckoo_hash.c:991:
+        return 0;$

WARNING: please, no spaces at the start of a line
#115: FILE: lib/librte_hash/rte_cuckoo_hash.c:991:
+        return 0;$

ERROR: code indent should use tabs where possible
#146: FILE: lib/librte_hash/rte_hash.h:288:
+                                void **key);$

WARNING: please, no spaces at the start of a line
#146: FILE: lib/librte_hash/rte_hash.h:288:
+                                void **key);$

total: 8 errors, 9 warnings, 112 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-v2-hash-new-function-to-retrieve-a-key-given-its-position.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team