* [dpdk-test-report] |FAILURE| pw31389 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Re: [PATCH] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Hi On Wed Nov 15 2017 at 12:46:15PM +0000 Hanoch Haim (hhaim) wrote: > +Oliver > Ilia I assume there is a reason why Oliver did that I just consolidate the code. > He didn't want to *write* the same value to mbuf field. > In the common case that pointer was already cleared by the driver it is better to just read it. From cache synchronization perspective it will run faster. > > Thanks > Hanoh > > > -----Original Message----- >
@ 2017-11-16 8:00 sys_stv
0 siblings, 0 replies; only message in thread
From: sys_stv @ 2017-11-16 8:00 UTC (permalink / raw)
To: test-report; +Cc: hhaim
[-- Attachment #1: Type: text/plain, Size: 24443 bytes --]
Test-Label: Intel-compilation
Test-Status: FAILURE
http://dpdk.org/patch/31389
_Compilation issues_
Submitter: "Hanoch Haim \(hhaim\)" <hhaim@cisco.com>
Date: Thu, 16 Nov 2017 07:16:31 +0000
DPDK git baseline: Repo:dpdk, Branch:master, CommitID:d84aad650401a122cb75bd5811e49b03ef3dc49d
Patch31389-31389 --> compile error
Build Summary: 21 Builds Done, 0 Successful, 21 Failures
Test environment and configuration as below:
OS: RHEL7.2_64
Kernel Version:3.10.0-514.10.2.el7.x86_64
CPU info:Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
GCC Version:gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)
Clang Version:3.4.2
i686-native-linuxapp-gcc
x86_64-native-linuxapp-gcc
x86_64-native-linuxapp-gcc-shared
OS: UB1610_64
Kernel Version:4.8.0-22-generic
CPU info:Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
GCC Version:gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
Clang Version:NA
x86_64-native-linuxapp-icc
OS: UB1604_64
Kernel Version:4.4.0-78-generic
CPU info:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
GCC Version:gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
Clang Version:3.8.0
i686-native-linuxapp-gcc
x86_64-native-linuxapp-gcc
x86_64-native-linuxapp-gcc-shared
x86_64-native-linuxapp-clang
OS: FC25_64
Kernel Version:4.8.6-300.fc25.x86_64
CPU info:Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
GCC Version:gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
Clang Version:NA
x86_64-native-linuxapp-icc
OS: FreeBSD10.3_64
Kernel Version:10.3-RELEASE
CPU info:
GCC Version:gcc (FreeBSD Ports Collection) 4.8.5
Clang Version:3.4.1
x86_64-native-bsdapp-clang
x86_64-native-bsdapp-gcc
OS: CentOS7_64
Kernel Version:3.10.0-514.10.2.el7.x86_64
CPU info:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
GCC Version:gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)
Clang Version:3.4.2
i686-native-linuxapp-gcc
x86_64-native-linuxapp-clang
x86_64-native-linuxapp-gcc-shared
x86_64-native-linuxapp-gcc
OS: FC24_64
Kernel Version:4.9.13-100.fc24.x86_64
CPU info:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
GCC Version:gcc (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)
Clang Version:3.8.0
x86_64-native-linuxapp-gcc-debug
i686-native-linuxapp-gcc
x86_64-native-linuxapp-clang
x86_64-native-linuxapp-gcc-shared
x86_64-native-linuxapp-gcc
OS: RHEL7.3_64
Kernel Version:3.10.0-514.16.1.el7.x86_64
CPU info:Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
GCC Version:gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
Clang Version:NA
x86_64-native-linuxapp-icc
Failed Build #1:
OS: RHEL7.2_64
Target: i686-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #2:
OS: RHEL7.2_64
Target: x86_64-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #3:
OS: RHEL7.2_64
Target: x86_64-native-linuxapp-gcc-shared
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #4:
OS: UB1610_64
Target: x86_64-native-linuxapp-icc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c(56):
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-icc/include/rte_mbuf.h(1373): error: identifier "ret" is undefined
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
compilation aborted for /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c (code 2)
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #5:
OS: UB1604_64
Target: i686-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #6:
OS: UB1604_64
Target: x86_64-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #7:
OS: UB1604_64
Target: x86_64-native-linuxapp-gcc-shared
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #8:
OS: UB1604_64
Target: x86_64-native-linuxapp-clang
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1373:16: error: use of undeclared identifier 'ret'
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1377:20: error: use of undeclared identifier 'ret'
if (ret != 0)
^
2 errors generated.
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #9:
OS: FC25_64
Target: x86_64-native-linuxapp-icc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c(56):
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-icc/include/rte_mbuf.h(1373): error: identifier "ret" is undefined
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
compilation aborted for /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c (code 2)
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #10:
OS: FreeBSD10.3_64
Target: x86_64-native-bsdapp-clang
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:
/home/patchWorkOrg/compilation/x86_64-native-bsdapp-clang/include/rte_mbuf.h:1373:16: error: use of undeclared identifier 'ret'
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-bsdapp-clang/include/rte_mbuf.h:1377:20: error: use of undeclared identifier 'ret'
if (ret != 0)
^
2 errors generated.
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #11:
OS: FreeBSD10.3_64
Target: x86_64-native-bsdapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-bsdapp-gcc/include/rte_mbuf.h: In function 'rte_pktmbuf_prefree_seg':
/home/patchWorkOrg/compilation/x86_64-native-bsdapp-gcc/include/rte_mbuf.h:1373:16: error: 'ret' undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-bsdapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #12:
OS: CentOS7_64
Target: i686-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #13:
OS: CentOS7_64
Target: x86_64-native-linuxapp-clang
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1373:16: error: use of undeclared identifier 'ret'
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1377:20: error: use of undeclared identifier 'ret'
if (ret != 0)
^
2 errors generated.
Failed Build #14:
OS: CentOS7_64
Target: x86_64-native-linuxapp-gcc-shared
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #15:
OS: CentOS7_64
Target: x86_64-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
Failed Build #16:
OS: FC24_64
Target: x86_64-native-linuxapp-gcc-debug
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^~~
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #17:
OS: FC24_64
Target: i686-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^~~
/home/patchWorkOrg/compilation/i686-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #18:
OS: FC24_64
Target: x86_64-native-linuxapp-clang
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1373:16: error: use of undeclared identifier 'ret'
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-clang/include/rte_mbuf.h:1377:20: error: use of undeclared identifier 'ret'
if (ret != 0)
^
2 errors generated.
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #19:
OS: FC24_64
Target: x86_64-native-linuxapp-gcc-shared
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^~~
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #20:
OS: FC24_64
Target: x86_64-native-linuxapp-gcc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c:56:0:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_prefree_seg’:
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: error: ‘ret’ undeclared (first use in this function)
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^~~
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:1373:16: note: each undeclared identifier is reported only once for each function it appears in
/home/patchWorkOrg/compilation/mk/internal/rte.compile-pre.mk:138: recipe for target 'rte_mbuf.o' failed
/home/patchWorkOrg/compilation/mk/rte.subdir.mk:63: recipe for target 'librte_mbuf' failed
/home/patchWorkOrg/compilation/mk/rte.sdkbuild.mk:76: recipe for target 'lib' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:128: recipe for target 'all' failed
/home/patchWorkOrg/compilation/mk/rte.sdkinstall.mk:85: recipe for target 'pre_install' failed
/home/patchWorkOrg/compilation/mk/rte.sdkroot.mk:107: recipe for target 'install' failed
Failed Build #21:
OS: RHEL7.3_64
Target: x86_64-native-linuxapp-icc
SYMLINK-FILE include/rte_mbuf.h
SYMLINK-FILE include/rte_mbuf_ptype.hIn file included from /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c(56):
/home/patchWorkOrg/compilation/x86_64-native-linuxapp-icc/include/rte_mbuf.h(1373): error: identifier "ret" is undefined
ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
^
compilation aborted for /home/patchWorkOrg/compilation/lib/librte_mbuf/rte_mbuf.c (code 2)
DPDK STV team
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-16 8:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-16 8:00 [dpdk-test-report] |FAILURE| pw31389 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Re: [PATCH] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Hi On Wed Nov 15 2017 at 12:46:15PM +0000 Hanoch Haim (hhaim) wrote: > +Oliver > Ilia I assume there is a reason why Oliver did that I just consolidate the code. > He didn't want to *write* the same value to mbuf field. > In the common case that pointer was already cleared by the driver it is better to just read it. From cache synchronization perspective it will run faster. > > Thanks > Hanoh > > > -----Original Message----- > sys_stv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).