From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpo21.poczta.onet.pl (smtpo21.poczta.onet.pl [213.180.142.152]) by dpdk.org (Postfix) with ESMTP id 4968695AB for ; Wed, 27 Jan 2016 14:44:41 +0100 (CET) Received: from pmq3v.m5r2.onet (pmq3v.m5r2.onet [10.174.32.69]) by smtp.poczta.onet.pl (Onet) with ESMTP id 3pr5lD6cbZz9v72D; Wed, 27 Jan 2016 14:44:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vp.pl; s=2011; t=1453902281; bh=md6mBSoJh7q/cjZ/e5EMGvfm9jWfbbC3ze+i3tmzC3o=; h=Content-Type:MIME-Version:Content-Transfer-Encoding:From:Cc:To: Date:Message-Id:Subject; b=kmJC0Mv41DGNEdgkqI/0nllo4oDeYZ8TaLfCZfW8KtXoHeXrTA77pXTIir4ojKvpP HFZo6i0C+uBnq/PGGcLr4EZ1BkOwd0d87jd7OuWy2fijSPHx64ZqP2HYvAZg0+7vri QQD1hTep2E6LON5QFqk/RTdS3hM9CjPKHOTvc7NU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received: from [78.11.8.249] by pmq3v.m5r2.onet via HTTP id 201601271442519370010001; Wed, 27 Jan 2016 14:44:40 +0100 From: dawid_jurek X-Priority: 3 To: Thomas Monjalon Date: Wed, 27 Jan 2016 14:44:40 +0100 Message-Id: <123065911-cd2e3bceeae2c6d9a614feda1f0df9e8@pmq3v.m5r2.onet> X-Mailer: onet.poczta X-Onet-PMQ: ;78.11.8.249;PL;2 Cc: "users@dpdk.org" Subject: Re: [dpdk-users] SyntaxError in setup.sh during binding ethernet device X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 13:44:41 -0000 W dniu 2016-01-19 11:54:24 u=C5=BCytkownik dawid_jurek = napisa=C5=82: > = > = > W dniu 2016-01-19 11:19:55 u=C5=BCytkownik Thomas Monjalon napisa=C5=82: > > Hi > > = > > 2016-01-19 10:45, dawid_jurek: > > > Hello DPDK developers, > > > I experienced issue when I ran tools/setup.sh and chose option [23]: = Bind Ethernet device to IGB UIO module. > > > Script Output: > > > File ".../dpdk/dpdk-2.2.0/tools/dpdk_nic_bind.py", line 113 > > > """ % locals() # replace items from local variables > > > ^ > > > SyntaxError: invalid syntax > > > It turned out that python 2.7 set as default in system was needed. > > > So I added python2 to every line with dpdk_nic_bind.py call in tools/= setup.sh and now it works fine. > > > But the question is: is it expected behaviour? Shouldn't it be fixed = by simple patch in way I did it? > > = > > Yes a patch would be appreciated to make it python 3 friendly. > > Thanks > > = > = > OK. I will prepare patch for dpdk_nic_bind.py soon. > Regards, > Dawid > = > = Hello again, patch for this issue was prepared and tested on Arch (Python 3 is default) = and Ubuntu (Python 2 is default) distros. = In both cases syntax errors from dpdk_nic_bind.py disappeared and everythin= g worked as expected. = Patch is very simple and in most cases just adds extra brackets to print fu= nctions. Anyway please review this. Regards, Dawid diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py index f02454e..9f7c848 100755 --- a/tools/dpdk_nic_bind.py +++ b/tools/dpdk_nic_bind.py @@ -54,7 +54,7 @@ args =3D [] def usage(): '''Print usage information for the program''' argv0 =3D basename(sys.argv[0]) - print """ + print (""" Usage: ------ = @@ -110,7 +110,7 @@ To unbind 0000:01:00.0 from using any driver To bind 0000:02:00.0 and 0000:02:00.1 to the ixgbe kernel driver %(argv0)s -b ixgbe 02:00.0 02:00.1 = - """ % locals() # replace items from local variables + """ % locals()) # replace items from local variables = # This is roughly compatible with check_output function in subprocess modu= le # which is only available in python 2.7. @@ -156,7 +156,7 @@ def check_modules(): '''Checks that igb_uio is loaded''' global dpdk_drivers = - fd =3D file("/proc/modules") + fd =3D open("/proc/modules", 'r') loaded_mods =3D fd.readlines() fd.close() = @@ -176,10 +176,10 @@ def check_modules(): # check if we have at least one loaded module if True not in [mod["Found"] for mod in mods] and b_flag is not None: if b_flag in dpdk_drivers: - print "Error - no supported modules(DPDK driver) are loaded" + print ("Error - no supported modules(DPDK driver) are loaded") sys.exit(1) else: - print "Warning - no supported modules(DPDK driver) are loaded" + print ("Warning - no supported modules(DPDK driver) are loaded= ") = # change DPDK driver list to only contain drivers that are loaded dpdk_drivers =3D [mod["Name"] for mod in mods if mod["Found"]] @@ -198,7 +198,7 @@ def get_pci_device_details(dev_id): for line in extra_info: if len(line) =3D=3D 0: continue - name, value =3D line.split("\t", 1) + name, value =3D line.decode().split("\t", 1) name =3D name.strip(":") + "_str" device[name] =3D value # check for a unix interface name @@ -234,7 +234,7 @@ def get_nic_details(): dev["Device"] =3D int(dev["Device"],16) devices[dev["Slot"]] =3D dict(dev) # use dict to make copy= of dev else: - name, value =3D dev_line.split("\t", 1) + name, value =3D dev_line.decode().split("\t", 1) dev[name.rstrip(":")] =3D value = # check what is the interface if any for an ssh connection if @@ -243,17 +243,17 @@ def get_nic_details(): route =3D check_output(["ip", "-o", "route"]) # filter out all lines for 169.254 routes route =3D "\n".join(filter(lambda ln: not ln.startswith("169.254"), - route.splitlines())) + route.decode().splitlines())) rt_info =3D route.split() - for i in xrange(len(rt_info) - 1): + for i in range(len(rt_info) - 1): if rt_info[i] =3D=3D "dev": ssh_if.append(rt_info[i+1]) = # based on the basic info, get extended text details for d in devices.keys(): # get additional info and add it to existing data - devices[d] =3D dict(devices[d].items() + - get_pci_device_details(d).items()) + devices[d] =3D devices[d].copy() + devices[d].update(get_pci_device_details(d).items()) = for _if in ssh_if: if _if in devices[d]["Interface"].split(","): @@ -293,22 +293,22 @@ def dev_id_from_dev_name(dev_name): if dev_name in devices[d]["Interface"].split(","): return devices[d]["Slot"] # if nothing else matches - error - print "Unknown device: %s. " \ - "Please specify device in \"bus:slot.func\" format" % dev_name + print ("Unknown device: %s. " \ + "Please specify device in \"bus:slot.func\" format" % dev_name) sys.exit(1) = def unbind_one(dev_id, force): '''Unbind the device identified by "dev_id" from its current driver''' dev =3D devices[dev_id] if not has_driver(dev_id): - print "%s %s %s is not currently managed by any driver\n" % \ - (dev["Slot"], dev["Device_str"], dev["Interface"]) + print ("%s %s %s is not currently managed by any driver\n" % \ + (dev["Slot"], dev["Device_str"], dev["Interface"])) return = # prevent us disconnecting ourselves if dev["Ssh_if"] and not force: - print "Routing table indicates that interface %s is active" \ - ". Skipping unbind" % (dev_id) + print ("Routing table indicates that interface %s is active" \ + ". Skipping unbind" % (dev_id)) return = # write to /sys to unbind @@ -316,7 +316,7 @@ def unbind_one(dev_id, force): try: f =3D open(filename, "a") except: - print "Error: unbind failed for %s - Cannot open %s" % (dev_id, fi= lename) + print ("Error: unbind failed for %s - Cannot open %s" % (dev_id, f= ilename)) sys/exit(1) f.write(dev_id) f.close() @@ -329,14 +329,14 @@ def bind_one(dev_id, driver, force): = # prevent disconnection of our ssh session if dev["Ssh_if"] and not force: - print "Routing table indicates that interface %s is active" \ - ". Not modifying" % (dev_id) + print ("Routing table indicates that interface %s is active" \ + ". Not modifying" % (dev_id)) return = # unbind any existing drivers we don't want if has_driver(dev_id): if dev["Driver_str"] =3D=3D driver: - print "%s already bound to driver %s, skipping\n" % (dev_id, d= river) + print ("%s already bound to driver %s, skipping\n" % (dev_id, = driver)) return else: saved_driver =3D dev["Driver_str"] @@ -349,14 +349,14 @@ def bind_one(dev_id, driver, force): try: f =3D open(filename, "w") except: - print "Error: bind failed for %s - Cannot open %s" % (dev_id, = filename) + print ("Error: bind failed for %s - Cannot open %s" % (dev_id,= filename)) return try: f.write("%04x %04x" % (dev["Vendor"], dev["Device"])) f.close() except: - print "Error: bind failed for %s - Cannot write new PCI ID to = " \ - "driver %s" % (dev_id, driver) + print ("Error: bind failed for %s - Cannot write new PCI ID to= " \ + "driver %s" % (dev_id, driver)) return = # do the bind by writing to /sys @@ -364,7 +364,7 @@ def bind_one(dev_id, driver, force): try: f =3D open(filename, "a") except: - print "Error: bind failed for %s - Cannot open %s" % (dev_id, file= name) + print ("Error: bind failed for %s - Cannot open %s" % (dev_id, fil= ename)) if saved_driver is not None: # restore any previous driver bind_one(dev_id, saved_driver, force) return @@ -378,7 +378,7 @@ def bind_one(dev_id, driver, force): tmp =3D get_pci_device_details(dev_id) if "Driver_str" in tmp and tmp["Driver_str"] =3D=3D driver: return - print "Error: bind failed for %s - Cannot bind to driver %s" % (de= v_id, driver) + print ("Error: bind failed for %s - Cannot bind to driver %s" % (d= ev_id, driver)) if saved_driver is not None: # restore any previous driver bind_one(dev_id, saved_driver, force) return @@ -423,8 +423,8 @@ def display_devices(title, dev_list, extra_params =3D N= one): %()s fields in it for replacement by the named fields in each device's dictionary.''' strings =3D [] # this holds the strings to print. We sort before print= ing - print "\n%s" % title - print "=3D"*len(title) + print ("\n%s" % title) + print ("=3D"*len(title)) if len(dev_list) =3D=3D 0: strings.append("") else: @@ -436,7 +436,7 @@ def display_devices(title, dev_list, extra_params =3D N= one): strings.append("%s '%s'" % (dev["Slot"], dev["Device_str"]= )) # sort before printing, so that the entries appear in PCI order strings.sort() - print "\n".join(strings) # print one per line + print ("\n".join(strings)) # print one per line = def show_status(): '''Function called when the script is passed the "--status" option. Di= splays @@ -480,9 +480,9 @@ def parse_args(): opts, args =3D getopt.getopt(sys.argv[1:], "b:us", ["help", "usage", "status", "force", "bind=3D", "unbind"]) - except getopt.GetoptError, error: - print str(error) - print "Run '%s --usage' for further information" % sys.argv[0] + except (getopt.GetoptError, error): + print (str(error)) + print ("Run '%s --usage' for further information" % sys.argv[0]) sys.exit(1) = for opt, arg in opts: @@ -495,7 +495,7 @@ def parse_args(): force_flag =3D True if opt =3D=3D "-b" or opt =3D=3D "-u" or opt =3D=3D "--bind" or op= t =3D=3D "--unbind": if b_flag is not None: - print "Error - Only one bind or unbind may be specified\n" + print ("Error - Only one bind or unbind may be specified\n= ") sys.exit(1) if opt =3D=3D "-u" or opt =3D=3D "--unbind": b_flag =3D "none" @@ -510,13 +510,13 @@ def do_arg_actions(): global args = if b_flag is None and not status_flag: - print "Error: No action specified for devices. Please give a -b or= -u option" - print "Run '%s --usage' for further information" % sys.argv[0] + print ("Error: No action specified for devices. Please give a -b o= r -u option") + print ("Run '%s --usage' for further information" % sys.argv[0]) sys.exit(1) = if b_flag is not None and len(args) =3D=3D 0: - print "Error: No devices specified." - print "Run '%s --usage' for further information" % sys.argv[0] + print ("Error: No devices specified.") + print ("Run '%s --usage' for further information" % sys.argv[0]) sys.exit(1) = if b_flag =3D=3D "none" or b_flag =3D=3D "None":