DPDK usage discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up?
@ 2022-01-10  3:20 wangyunjian
  2022-01-10  9:29 ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2022-01-10  3:20 UTC (permalink / raw)
  To: dev, users, qiming.yang, qi.z.zhang; +Cc: Huangshaozhang, dingxiaoxiong

Hi, All:

I am using Intel E810 with DPDK v21.11 to create a dpdkbond but there
is a probability that the failure will occur.

During the test, the bonding is repeatedly added and deleted. Sometimes,
the link status of the NIC is Down. And if call ice_dev_set_link_up again,
the link status of the NIC can be recovered. 

Alternatively, the problem can be avoided by modifying the ice pmd driver.

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 13a7a9702a..fcd22e20a5 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3604,7 +3604,7 @@ ice_dev_start(struct rte_eth_dev *dev)
        ice_dev_set_link_up(dev);
 
        /* Call get_link_info aq commond to enable/disable LSE */
-       ice_link_update(dev, 0);
+       ice_link_update(dev, 1);
 
        pf->adapter_stopped = false;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up?
  2022-01-10  3:20 [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up? wangyunjian
@ 2022-01-10  9:29 ` Zhang, Qi Z
  2022-01-10 10:17   ` wangyunjian
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2022-01-10  9:29 UTC (permalink / raw)
  To: wangyunjian, dev, users, Yang, Qiming; +Cc: Huangshaozhang, dingxiaoxiong



> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Monday, January 10, 2022 11:20 AM
> To: dev@dpdk.org; users@dpdk.org; Yang, Qiming <qiming.yang@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Huangshaozhang <huangshaozhang@huawei.com>; dingxiaoxiong
> <dingxiaoxiong@huawei.com>
> Subject: [dpdk-dev] [dpdk-users] A question about the link status of the intel
> E810 nic can not be up?
> 
> Hi, All:
> 
> I am using Intel E810 with DPDK v21.11 to create a dpdkbond but there is a
> probability that the failure will occur.
> 
> During the test, the bonding is repeatedly added and deleted. Sometimes, the
> link status of the NIC is Down. And if call ice_dev_set_link_up again, the link
> status of the NIC can be recovered.
> 
> Alternatively, the problem can be avoided by modifying the ice pmd driver.
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 13a7a9702a..fcd22e20a5 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3604,7 +3604,7 @@ ice_dev_start(struct rte_eth_dev *dev)
>         ice_dev_set_link_up(dev);
> 
>         /* Call get_link_info aq commond to enable/disable LSE */
> -       ice_link_update(dev, 0);
> +       ice_link_update(dev, 1);

This looks good to me, it's reasonable to wait for complete right after set link up as it is not in an link status change interrupt handling scenario.

We will try to reproduce this issue, meanwhile could you help on following below 2 things.

1. share the device ID / firmware version that you met this issue.
2. send a v2 with reworded title and commit log as a normal patch if you want to contribute.

Thanks
Qi

> 
>         pf->adapter_stopped = false;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up?
  2022-01-10  9:29 ` Zhang, Qi Z
@ 2022-01-10 10:17   ` wangyunjian
  0 siblings, 0 replies; 3+ messages in thread
From: wangyunjian @ 2022-01-10 10:17 UTC (permalink / raw)
  To: Zhang, Qi Z, dev, users, Yang, Qiming; +Cc: Huangshaozhang, dingxiaoxiong

> -----Original Message-----
> From: Zhang, Qi Z [mailto:qi.z.zhang@intel.com]
> Sent: Monday, January 10, 2022 5:29 PM
> To: wangyunjian <wangyunjian@huawei.com>; dev@dpdk.org; users@dpdk.org;
> Yang, Qiming <qiming.yang@intel.com>
> Cc: Huangshaozhang <huangshaozhang@huawei.com>; dingxiaoxiong
> <dingxiaoxiong@huawei.com>
> Subject: RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel
> E810 nic can not be up?
> 
> 
> 
> > -----Original Message-----
> > From: wangyunjian <wangyunjian@huawei.com>
> > Sent: Monday, January 10, 2022 11:20 AM
> > To: dev@dpdk.org; users@dpdk.org; Yang, Qiming
> > <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: Huangshaozhang <huangshaozhang@huawei.com>; dingxiaoxiong
> > <dingxiaoxiong@huawei.com>
> > Subject: [dpdk-dev] [dpdk-users] A question about the link status of
> > the intel
> > E810 nic can not be up?
> >
> > Hi, All:
> >
> > I am using Intel E810 with DPDK v21.11 to create a dpdkbond but there
> > is a probability that the failure will occur.
> >
> > During the test, the bonding is repeatedly added and deleted.
> > Sometimes, the link status of the NIC is Down. And if call
> > ice_dev_set_link_up again, the link status of the NIC can be recovered.
> >
> > Alternatively, the problem can be avoided by modifying the ice pmd driver.
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c
> > b/drivers/net/ice/ice_ethdev.c index
> > 13a7a9702a..fcd22e20a5 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -3604,7 +3604,7 @@ ice_dev_start(struct rte_eth_dev *dev)
> >         ice_dev_set_link_up(dev);
> >
> >         /* Call get_link_info aq commond to enable/disable LSE */
> > -       ice_link_update(dev, 0);
> > +       ice_link_update(dev, 1);
> 
> This looks good to me, it's reasonable to wait for complete right after set link
> up as it is not in an link status change interrupt handling scenario.
> 
> We will try to reproduce this issue, meanwhile could you help on following
> below 2 things.
> 
> 1. share the device ID / firmware version that you met this issue.

# ethtool -i eth16
driver: ice
version: 1.6.4
firmware-version: 3.10 0x8000ad4a 1.3106.0
expansion-rom-version: 
bus-info: 0000:04:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

# lspci -n -s 04:00.0
04:00.0 0200: 8086:159b (rev 02)

> 2. send a v2 with reworded title and commit log as a normal patch if you want
> to contribute.

OK, I'll send v2 patch to fix it.

Thanks
> 
> Thanks
> Qi
> 
> >
> >         pf->adapter_stopped = false;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-10 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10  3:20 [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up? wangyunjian
2022-01-10  9:29 ` Zhang, Qi Z
2022-01-10 10:17   ` wangyunjian

DPDK usage discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/users/0 users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 users users/ http://inbox.dpdk.org/users \
		users@dpdk.org
	public-inbox-index users

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git