From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 422C82C10;
Fri, 18 Nov 2016 17:37:43 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga103.fm.intel.com with ESMTP; 18 Nov 2016 08:37:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,510,1473145200"; d="scan'208";a="32878267"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.64])
by orsmga005.jf.intel.com with SMTP; 18 Nov 2016 08:37:39 -0800
Received: by (sSMTP sendmail emulation); Fri, 18 Nov 2016 16:37:38 +0000
Date: Fri, 18 Nov 2016 16:37:38 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>, "users@dpdk.org" <users@dpdk.org>,
"Jacob, Jerin" <Jerin.Jacob@cavium.com>,
Jan Viktorin <viktorin@rehivetech.com>
Message-ID: <20161118163737.GA11072@bricha3-MOBL3.ger.corp.intel.com>
References: <DB5PR04MB1605F64CF0D986E0B2B26AF089BB0@DB5PR04MB1605.eurprd04.prod.outlook.com>
<20161113205924.GA11392@localhost.localdomain>
<20161114144839.GA15570@hmsreliant.think-freely.org>
<DB5PR04MB1605203F2297ED88A47270F189BF0@DB5PR04MB1605.eurprd04.prod.outlook.com>
<20161115150800.GB11283@hmsreliant.think-freely.org>
<DB5PR04MB1605E3C25DF89568176D668C89B00@DB5PR04MB1605.eurprd04.prod.outlook.com>
<20161118135052.GA29049@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161118135052.GA29049@hmsreliant.think-freely.org>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
=?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.7.1 (2016-10-04)
Subject: Re: [dpdk-users] [dpdk-dev] pmdinfogen issues: cross compilation
for ARM fails with older host compiler
X-BeenThere: users@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: usage discussions <users.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/users>,
<mailto:users-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/users/>
List-Post: <mailto:users@dpdk.org>
List-Help: <mailto:users-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/users>,
<mailto:users-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2016 16:37:44 -0000
On Fri, Nov 18, 2016 at 08:50:52AM -0500, Neil Horman wrote:
> On Fri, Nov 18, 2016 at 12:03:19PM +0000, Hemant Agrawal wrote:
> > > -----Original Message-----
> > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > On Tue, Nov 15, 2016 at 09:34:16AM +0000, Hemant Agrawal wrote:
> > > > > On Mon, Nov 14, 2016 at 02:29:24AM +0530, Jerin Jacob wrote:
> > > > > > On Fri, Nov 11, 2016 at 10:34:39AM +0000, Hemant Agrawal wrote:
> > > > > > > Hi Neil,
> > > > > > > Pmdinfogen compiles with host compiler. It usages
> > > rte_byteorder.h
> > > > > of the target platform.
> > > > > > > However, if the host compiler is older than 4.8, it will be an issue during
> > > cross
> > > > > compilation for some platforms.
> > > > > > > e.g. if we are compiling on x86 host for ARM, x86 host compiler will not
> > > > > understand the arm asm instructions.
> > > > > > >
> > > > > > > /* fix missing __builtin_bswap16 for gcc older then 4.8 */ #if
> > > > > > > !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)) static
> > > > > > > inline uint16_t rte_arch_bswap16(uint16_t _x) {
> > > > > > > register uint16_t x = _x;
> > > > > > > asm volatile ("rev16 %0,%1"
> > > > > > > : "=r" (x)
> > > > > > > : "r" (x)
> > > > > > > );
> > > > > > > return x;
> > > > > > > }
> > > > > > > #endif
> > > > > > >
> > > > > > > One easy solution is that we add compiler platform check in this
> > > > > > > code section of rte_byteorder.h e.g #if !(defined __arm__ || defined
> > > > > > > __aarch64__) static inline uint16_t rte_arch_bswap16(uint16_t _x) {
> > > > > > > return (_x >> 8) | ((_x << 8) & 0xff00); } #else ….
> > > > > > >
> > > > > > > Is there a better way to fix it?
> > > > > >
> > > > > > IMO, It is a HOST build infrastructure issue. If a host app is using
> > > > > > the dpdk service then it should compile and link against HOST
> > > > > > target(in this specific case, build/x86_64-native-linuxapp-gcc). I
> > > > > > think, introducing the HOSTTARGET kind of scheme is a clean solution.
> > > > > >
> > > > > > /Jerin
> > > > > >
> > > > > >
> > > > > That would be accurate. That is to say, pmdinfogen is a tool that should only
> > > be
> > > > > run on the host doing the build, by the host doing the build, and so should be
> > > > > compiled to run on the host, not on the target being built for.
> > > > >
> > > > > Yeah, so what we need is a way to get to the host version of rte_byteorder.h
> > > > > when building in a cross environment
> > > > >
> > > > +1
> > > >
> > > > > Neil
> > > >
> > >
> > > Give this a try, I've tested it on linux, but not BSD. From what I read the
> > > functions are not posix compliant, though they should exist on all BSD and Linux
> > > systems in recent history. There may be some fiddling needed for Net and
> > > OpenBSD variants, but I think this is the right general direction.
> >
> > + 1
> > This patch works good for Linux.
> >
> Can someone test it on BSD? I'd like to ensure we don't need to modify it for
> that platform
>
> Neil
>
> > >
> > >
> > > diff --git a/buildtools/pmdinfogen/pmdinfogen.h
> > > b/buildtools/pmdinfogen/pmdinfogen.h
> > > index 1da2966..c5ef89d 100644
> > > --- a/buildtools/pmdinfogen/pmdinfogen.h
> > > +++ b/buildtools/pmdinfogen/pmdinfogen.h
> > > @@ -21,7 +21,6 @@
> > > #include <elf.h>
> > > #include <rte_config.h>
> > > #include <rte_pci.h>
> > > -#include <rte_byteorder.h>
> > >
> > > /* On BSD-alike OSes elf.h defines these according to host's word size */
> > > #undef ELF_ST_BIND
> > > @@ -75,9 +74,9 @@
> > > #define CONVERT_NATIVE(fend, width, x) ({ \
> > > typeof(x) ___x; \
> > > if ((fend) == ELFDATA2LSB) \
> > > - ___x = rte_le_to_cpu_##width(x); \
> > > + ___x = le##width##toh(x); \
> > > else \
> > > - ___x = rte_be_to_cpu_##width(x); \
> > > + ___x = be##width##toh(x); \
> > > ___x; \
> > > })
> > >
For compile on FreeBSD 10 we need "#include <sys/endian.h>" and this
works.
/Bruce