DPDK usage discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
Cc: Ye Xiaolong <xiaolong.ye@intel.com>, "users@dpdk.org" <users@dpdk.org>
Subject: Re: [dpdk-users] Why flow can not be created?
Date: Tue, 6 Aug 2019 11:12:34 +0200	[thread overview]
Message-ID: <20190806091234.GJ4512@6wind.com> (raw)
In-Reply-To: <20190802150619.D107.17218CA3@ntt-tx.co.jp_1>

On Fri, Aug 02, 2019 at 03:06:19PM +0900, Hideyuki Yamashita wrote:
> Helllo Experts,

I think most of them are on vacation :)

> Q1. Are there any NICs which supports entag/detag VLAN?
> I searched source DPDK source code with keyword "OF_POP_VLAN" or "OF_POP_VLAN"
> and found some codes within mlx5_flow_tcf.c and cxgbe_flow.c.

Indeed only those two seem to implement that. However depending on what
you're trying to achieve, there could be a workaround as many drivers
provide support for VLAN entag/detag outside rte_flow.

For Rx, you can dedicate queues to perform VLAN stripping through
rte_eth_dev_set_vlan_strip_on_queue(), and use rte_flow to redirect traffic
of interest to these queues after matching specific VLANs and other
properties for instance.

If you don't care about specific VLANs or queues, you can request VLAN
stripping globally using ETH_VLAN_STRIP_OFFLOAD with
rte_eth_dev_set_vlan_offload(), then rely on mbuf->ol_flags & PKT_RX_VLAN to
retrieve it from mbuf->vlan_tci.

On the Tx side you simply have to request mbuf->ol_flags | PKT_TX_VLAN while
doing Tx. As for Rx, make sure DEV_TX_OFFLOAD_VLAN_INSERT is among the Tx
offloads requested during setup (rte_eth_conf->txmode.offloads).

> Q2. Are there any plans in DPDK community to update document about 
> NIC to update support of rte_flow?
> I have heard the situation about document form Adrien, and to be honest
> I felt it is very hard to take try and error with testpmd for every NIC.

This was discussed in the past, however so far no action was taken.

I think we cannot summarize all supported combinations for each NIC while
covering their specific quirks efficiently. For instance, two NICs may
support a given pattern item, but not necessarily at the same position in
the pattern. Likewise for pattern item fields, they may not support the same
masks.

The most sensible approach is perhaps to provide a list of popular flow
rules tagged with the NICs supporting them.

Anyway since it's not a huge priority at the moment, you should start a
discussion on that topic on the dev@dpdk.org mailing list. Without noise,
nothing will happen :) As usual contributions are always welcome!

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2019-08-06  9:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  6:08 Hideyuki Yamashita
2019-07-22 12:48 ` Ye Xiaolong
2019-07-23  6:26   ` Hideyuki Yamashita
2019-07-30 10:37     ` Hideyuki Yamashita
2019-07-30 12:25       ` Adrien Mazarguil
2019-07-31  2:30         ` Hideyuki Yamashita
2019-08-02  6:06           ` Hideyuki Yamashita
2019-08-06  9:12             ` Adrien Mazarguil [this message]
2019-08-06  9:59               ` Moti Haimovsky
2019-08-09  6:05               ` Hideyuki Yamashita
2019-08-14  5:56                 ` [dpdk-users] How L2 broadcast is handled under rte_flow? Hideyuki Yamashita
2019-08-29  3:11                   ` Hideyuki Yamashita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190806091234.GJ4512@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=users@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    --cc=yamashita.hideyuki@ntt-tx.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).