From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77804429D7 for ; Sat, 29 Apr 2023 02:04:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1E2F4067E; Sat, 29 Apr 2023 02:04:50 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id C8AB240141 for ; Sat, 29 Apr 2023 02:04:49 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-63b7096e2e4so505159b3a.2 for ; Fri, 28 Apr 2023 17:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682726688; x=1685318688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZOvl2B5YpWt+6OISAVXS16eMpJu8UFiheIBVdVfqCKQ=; b=sMXeqHyPXhJqIZv5LemJ/7beafyLLSljFK1QhRrlrhQExV3stv4kjHXDHoGVXIm4PJ 8qDetxSr9nfW3O46kp6CUX4nGmBzJZh9HMYxNpNNINkXnYC88T6QbdIIisemXFUfpv6R WShj1qW+y1LHFck35rJL7s+l8gKh538qCmJc2uy3PeHWHxrBYIw76QCcW4KzLqY2RJcZ nGVQvNTXw1A5WAEo39qpjszQwrCQEmPPOPVLd01tezgiq2VeHjCVQhwh5TKv92moTQts eCfexwio3+3WQqv1o6aRp/JWR4kfhTwWFCaKhzhsAmxwVpGQBXeFbOQHAgTtiIbvb5Ca uAaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682726688; x=1685318688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZOvl2B5YpWt+6OISAVXS16eMpJu8UFiheIBVdVfqCKQ=; b=Mfqb4+8z9ZKSFsovLk8Kqqi+CxAcdn2yBg068sfnBd5dECGLsb0w6I+Yi+89X7q9O6 I1O5iKT6p+Lx3bP8lNG+JK8YIdz9oQ6mX2c+SdSYRVPxq0BEsmmZ3uJNyh29q0iO4sCK dcW4Y+V9OEnz/mwuhpzvNmz/1/wQQt+ehwbm2iIxKqgVcrr/qc+/tZN0bOBvvWE8oE4H FUgXvBjKt63SHL/e0r+K+J7aGVJlK6PEQQfNC70nIjfcIHel28qfACFKzyAZho3X7HUM z6Mbt9GiCAzC2eGIYdMZdg4JMAKAb8Qhg6892yK3gGxY3ZAP+xUxks0QFMAE1a8LBkv2 UOmw== X-Gm-Message-State: AC+VfDz+rUtsrPjzk2piRnmeT/Lig3WTV/T/icjHBTgW09Gs3wf8qnUB gWS2DSIM9R33eR6rzetj5DArCQ== X-Google-Smtp-Source: ACHHUZ6q7v1MnlOb+WTGX5SMjeojcniQ5UCGhGEOs2felyigTvlJJNysXlypiJjjn3FPHtuBzaziBA== X-Received: by 2002:a05:6a20:b919:b0:f2:aa3c:fc6e with SMTP id fe25-20020a056a20b91900b000f2aa3cfc6emr6616761pzb.43.1682726688596; Fri, 28 Apr 2023 17:04:48 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 69-20020a621948000000b00634dde2992bsm15668157pfz.132.2023.04.28.17.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 17:04:48 -0700 (PDT) Date: Fri, 28 Apr 2023 17:04:46 -0700 From: Stephen Hemminger To: Cliff Burdick Cc: Tom Barbette , Thomas Monjalon , David Marchand , users , Ori Kam Subject: Re: Generic flow string parser Message-ID: <20230428170446.122c8775@hermes.local> In-Reply-To: References: <1814734.QZUTf85G27@thomas> <771fa709-563f-1ec2-a997-084b7709edce@uclouvain.be> <20230428110935.00311cd8@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Fri, 28 Apr 2023 12:13:26 -0700 Cliff Burdick wrote: > Hi Stephen, it would definitely not be worthwhile to repeat everything > that's already tested with testpmd. I was thinking that given that there > already is a "flow_parse" function that does almost everything needed, > something like that could be exposed. If we think of the testpmd flow > string as a sort of "IR" for string flow specification, that would allow > others to implement higher-level transform of a schema like JSON or YAML > into the testpmd language. Due to the complexity of testpmd and how it's > the source of true for testing flows, I think it's too great of an ask to > have testpmd support a new type of parsing. My only suggestion would be to > take what already exists and expose it in a public API that is included in > a DPDK install. > > If you look at the "flow_classify" example in DPDK you can already see that > for that application someone had to write another flow text parser for a > format they made up. Instead, that example could be converted over to this > other API as well. Please don't top post. The naming issue is that almost all libraries in DPDK start with rte_ prefix and the testpmd functions do not. The flow_classify example is pretty much abandonware at this point. Code is not updated, other than build breakages. Last time I looked at it noticed lots of code reinvention useless code, and only supports IPv4. It really needs a rewrite.