From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62096429D7 for ; Sat, 29 Apr 2023 02:08:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3D2E4067E; Sat, 29 Apr 2023 02:08:12 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 9EB7240141 for ; Sat, 29 Apr 2023 02:08:11 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1a814fe0ddeso5722885ad.2 for ; Fri, 28 Apr 2023 17:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682726891; x=1685318891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8UIxJpxcEWgp9DU3a4GXjEpi0F9oN8z6wptxvC+pfdo=; b=NBaEPzWZR1gwl7eSc39ru+J1MQDlr/tf7xG1BT4gVxAcnqsFjePeQetkMT/kOxYxjq n/D6k6Ji+f0ZTrw6ayhHaTegDpMBZcbyTub0kdrzYUm3mk9VrELcvTlx2CC9V0Dn+wO4 PSCsssRKoW5740fCRkbbbvtSYT9/yb5vgN5DONwByWrs3CfkbJajQ95veOjafzc5okIl ybMSTGTRBtCEhkpYcq2bVBNbLnGcKFQqQLMX0n/xrEekKcBeYtcoZ6jHOaz2zlf3SWSu jAkr9cMxQLvgHDJleH598lfftxYa4fNIctcCh4Z1OrZEESuVS0EWm65MX1XeEHUd2LMq D3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682726891; x=1685318891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UIxJpxcEWgp9DU3a4GXjEpi0F9oN8z6wptxvC+pfdo=; b=feoTDocqkdfwGE4T149B6mWPNY5UsUjnQFVuHakd2V8d6jKIVr+sT+vsumvQ7eXf1W i/itCHQmduFVx4bOkPjMcByD04UffY05UX6Cuzm2fKMOKcyExKkiiG3luQCxmlykCKXn X97XP9TlT9hyW70eVxu50cqUiajrhKHTp242x6U8+bvfTAEIbNPzOGHvG8i1PeeEwHkC hPNobwgO03UnALNG1TTo9BHApS2mtqLO6dXQlVnTHv1vh5LqboBUEN9ucF54gFJxBVuW z/tHjvykmTx2F/c0pOCGnygleH90j0zl9ijVP+h5KKzIu8/tVAkVG0InU6w+PJLHLhlo IjQQ== X-Gm-Message-State: AC+VfDwMERiw+PJ210xU6sMq16/q3SNVgjnuLglqmSrTTkptqEikj9mF pBJCprH2D45LoQaUuo8il8GJRg== X-Google-Smtp-Source: ACHHUZ5qp9JyWQJE0sOE6HiXzXOT/s4IzhYJGcIeQaq8M8sjIAvmRaTjUxwPV5ODnm8SiV2eXSJRCQ== X-Received: by 2002:a17:902:ea11:b0:1a9:a408:a502 with SMTP id s17-20020a170902ea1100b001a9a408a502mr8433812plg.1.1682726890766; Fri, 28 Apr 2023 17:08:10 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jk24-20020a170903331800b00194c90ca320sm13760054plb.204.2023.04.28.17.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 17:08:10 -0700 (PDT) Date: Fri, 28 Apr 2023 17:08:09 -0700 From: Stephen Hemminger To: Cliff Burdick Cc: Tom Barbette , Thomas Monjalon , David Marchand , users , Ori Kam Subject: Re: Generic flow string parser Message-ID: <20230428170809.387feebd@hermes.local> In-Reply-To: <20230428170446.122c8775@hermes.local> References: <1814734.QZUTf85G27@thomas> <771fa709-563f-1ec2-a997-084b7709edce@uclouvain.be> <20230428110935.00311cd8@hermes.local> <20230428170446.122c8775@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Fri, 28 Apr 2023 17:04:46 -0700 Stephen Hemminger wrote: > On Fri, 28 Apr 2023 12:13:26 -0700 > Cliff Burdick wrote: > > > Hi Stephen, it would definitely not be worthwhile to repeat everything > > that's already tested with testpmd. I was thinking that given that there > > already is a "flow_parse" function that does almost everything needed, > > something like that could be exposed. If we think of the testpmd flow > > string as a sort of "IR" for string flow specification, that would allow > > others to implement higher-level transform of a schema like JSON or YAML > > into the testpmd language. Due to the complexity of testpmd and how it's > > the source of true for testing flows, I think it's too great of an ask to > > have testpmd support a new type of parsing. My only suggestion would be to > > take what already exists and expose it in a public API that is included in > > a DPDK install. > > > > If you look at the "flow_classify" example in DPDK you can already see that > > for that application someone had to write another flow text parser for a > > format they made up. Instead, that example could be converted over to this > > other API as well. > > Please don't top post. > > The naming issue is that almost all libraries in DPDK start with rte_ prefix > and the testpmd functions do not. > > The flow_classify example is pretty much abandonware at this point. > Code is not updated, other than build breakages. > Last time I looked at it noticed lots of code reinvention useless code, > and only supports IPv4. It really needs a rewrite. Would rather the flow parser was rewritten as well. Doing open coded parser is much more error prone and hard to extend versus writing the parser in yacc/lex (ie bison/flex).