From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2214F4260D for ; Tue, 19 Sep 2023 20:00:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C189402DB; Tue, 19 Sep 2023 20:00:13 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id E848540277 for ; Tue, 19 Sep 2023 20:00:12 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-690bfd4f3ebso1098862b3a.3 for ; Tue, 19 Sep 2023 11:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695146412; x=1695751212; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rpkdiW9RX6gDPPUj7zAyCayNAefxFKyP0Ld0dLVm5VQ=; b=Zb7F6+WfB2sMJ2Xc+RRKixDUqNmrm2XSyOrkwuwj67ozgnip8SdbjLivNC++hLq5f9 NKfpXBAZbYxBiQQzEMp19LbqbSe2tjP8XPLCGSsiMnQR8Dewr7/aQL/NngqxHsDhXbVY lCCeEt3FROEZJlF2xPykQMVfB4yzLSEqDEZEKWLwb5e/HFKLvlnts4POWcJMks87fd3G L2fwvqy4jTBj/hh2dLTUIjQlyMNdbpe8A9n03UEvs0Ql+ly0Wk6OPY/xHFB5rsOler55 ngzCNmm8Vspwv88LqeBanh8q5lZQ01ihh/4i0I1O/sUnj0L6EDKLcTzKHMCfvBAlnTNH aqVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695146412; x=1695751212; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rpkdiW9RX6gDPPUj7zAyCayNAefxFKyP0Ld0dLVm5VQ=; b=e1BMEUSH1XUksLo41N90g3FrJnJC2GD+PmxS23NCqhvMWolOmKRV7zvTetUEmeSQtp XZPU7thaCb1VumbdyxiKffhDLBaQFf0VhGpeb+9d2tN4YvJvlU2v1Cyt1OO5JyT5owRu lCIqc+ZRyX/3SyPIKluZCoav18EW8yC/SktSRoKsq+7+yRKK0GSWS0Ut+z1seF6PUsqP FlbmYOn91zpVJebmhqR98/LJYN3ODFN63VTgeE3HEpzO5n9QDC9Ukpgbbk2cGWqVmiyf j4GgrkRRe8q60T2357LP7KwL2G92GI96XHxs8CHSUuVIL4FbuMHOZbWoOQY/dsvBQLBc Nhmw== X-Gm-Message-State: AOJu0YzgLs1qNpLrf6jdN7sYm72VlwKKaITtAe14N4QtFaBcUxR3YJDj /yKi/X3jeLQ7OhyX7HeKqi5cSQ== X-Google-Smtp-Source: AGHT+IHqDwRK22CJLlLm88QfHr5dk2kEQbCfzcV0lheUR5j+1MgueDBU2ZQgZX4h8VNZd28PCOSX/A== X-Received: by 2002:a05:6a20:1388:b0:151:9156:6067 with SMTP id hn8-20020a056a20138800b0015191566067mr254222pzc.26.1695146411924; Tue, 19 Sep 2023 11:00:11 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id t6-20020a62ea06000000b00679a4b56e41sm8895938pfh.43.2023.09.19.11.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 11:00:11 -0700 (PDT) Date: Tue, 19 Sep 2023 11:00:09 -0700 From: Stephen Hemminger To: Isaac Boukris Cc: users@dpdk.org Subject: Re: dumpcap: timestamp is years ahead when in pcapng format Message-ID: <20230919110009.29e90615@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Tue, 19 Sep 2023 19:35:55 +0300 Isaac Boukris wrote: > Looking with git log, i found the original line was: > return pcapng_time.ns + (delta * NSEC_PER_SEC) / rte_get_tsc_hz(); > > Testing that does show a wrapping issue, e.g. (it stays around 08:05). > > 2023-09-19 08:05:24.372037 IP _gateway.domain > Rocky8.38358: 31975 > NXDomain 0/0/0 (46) 10 > 2023-09-19 08:05:21.577497 ARP, Request who-has _gateway tell Rocky8, > length 46 > 2023-09-19 08:05:21.577599 ARP, Reply _gateway is-at 00:50:56:f8:92:76 > (oui Unknown), length 46 13 > 2023-09-19 08:05:22.833897 IP 192.168.202.1.50886 > > 239.255.255.250.ssdp: UDP, length 174 > > However with my change it looks fine and always increments. I dropped > all the parenthesis: > return pcapng_time.ns + delta / pcapng_time.tsc_hz * NSEC_PER_SEC; The issue is that timestamping is in the fast path and that 64 bit divide is slow. Looking at other alternatives.