From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8686458AC for ; Thu, 5 Sep 2024 00:42:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D6614025C; Thu, 5 Sep 2024 00:42:50 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id B519140151 for ; Thu, 5 Sep 2024 00:42:49 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2068a7c9286so1477615ad.1 for ; Wed, 04 Sep 2024 15:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1725489769; x=1726094569; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Up8nTw38XAf9g4mqnkv96LRAjAMwx0wwUigSxyg2bEI=; b=uSt3g3N5aR1MUAba81b53c/q7s1DCG/LRLGr9gNfhZDhxIXGOs+2Mme9vGzdFMcJ4e 54scBukwUfXLheGW5brNdcZl23uQto7idd9Dj7+Yr9X8UfHke0zaGFjSu+E22k4aCMxN BqVzBWulC4qpVDIKZHpEGBSwsaFxrolNmlNX/lXMcw6PvDa2CNIhlof987VOZZGgEnz3 b/cXoU9I1j0epgfhMNMW0IvUOuZYPPT8jUgMRMHClPqfN5SBPFsWniurnM0xgWf7h5Tr vXKb5I/t+xRCs7LtVDMGU6cvQkvdyNT/tz6PrwLtLWrgD+2XJ1oHGbTkxmPSqqgJQ8Ea zSkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725489769; x=1726094569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Up8nTw38XAf9g4mqnkv96LRAjAMwx0wwUigSxyg2bEI=; b=LQlZBtxUaO8Yu9SGVFtwdIhdvAXSqbRiPvfekWa9S6fbs9dNrUipl9ubZWLU7rlNEI mVJ/XddPbrryCG8PLxtRLI+Uzdz1+S5PWNVLNmcv+VC4wNPmByZ4Xr4rUNIhtB8+9Az6 u6oiEEqKhXUkQ/ZkIgQplrzP9dy1Oiqd612ETGO0EJOY5tSbe6YCdte3IOwU59bIpKs5 AGKjzna2FfRn5sCrYxNroYTw/bJuBZr0IvRm9e/5x44YcbYpVa6F7LhSd8EzGSRWbg9A 4WKtOnP1pnndeZFdTrW8njeZWJIVrDTpFCeLTKQLZn0xLNzslpTBJycogGJmYKLoerAr DSyg== X-Forwarded-Encrypted: i=1; AJvYcCWDgatNNgeIChF9wm/q9ou7Wv+bj53AGrr4nrLklfGMAYt2I95+Wf4toK4kuDWRw2MkNEkU4w==@dpdk.org X-Gm-Message-State: AOJu0YxRu5qfiPrlJWVcmFBZVtX9jIdTLOjoWNZycQ/Tq1/2L+NfgVJs jLD0JhDTAXiThLraEj1Ji3y/gvfxa7ddmyeJDThhB+eE/bxNJPEVziPaSOKhcB0= X-Google-Smtp-Source: AGHT+IG8fWPcrA1RXS4TiTX0UGqBmKUwdmhxVrM94CGz6+n5Tigkou5ZjLiWKrXS+gc1jzABFD77VA== X-Received: by 2002:a17:902:d2ca:b0:205:627c:7ff9 with SMTP id d9443c01a7336-20584223108mr126165385ad.40.1725489768820; Wed, 04 Sep 2024 15:42:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206ae91350fsm18358585ad.16.2024.09.04.15.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 15:42:48 -0700 (PDT) Date: Wed, 4 Sep 2024 15:42:46 -0700 From: Stephen Hemminger To: Nandini Rangaswamy Cc: Long Li , users@dpdk.org Subject: Re: Netvsc vs Failsafe Performance Message-ID: <20240904154246.1c5bbb58@hermes.local> In-Reply-To: References: <20240903170350.7e663864@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Tue, 3 Sep 2024 17:21:48 -0700 Nandini Rangaswamy wrote: > Hi Stephen/Long, > dpdk_netvsc_port_configure:1873 Configure port eth2/2. I am testing using > TCP traffic (iperf3 tool) generated between pair of client and servers wi= th > DPDK app forward traffic between client and servers. > These are the config being passed for configuring netvsc: > lsc_intr=3D1 > rxq/txq=3D2/2, > rss is enabled with rss_hf=3D0x0000000000000c30 > tx_ol=3D0x00000000000006 > rx_ol=3D0x00000000080007 >=20 > Rsskey len is 64. > struct rte_eth_conf conf =3D { > .intr_conf =3D { > .lsc =3D !dpdk.lsc_intr_disable && !dpdk_if->lsc_intr_disable && > !!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC), > }, > .rxmode =3D { > .mq_mode =3D RTE_ETH_MQ_RX_RSS, > .offloads =3D RTE_ETH_RX_OFFLOAD_VLAN_STRIP | RTE_ETH_RX_OFFLOAD_IPV4_CKS= UM | > RTE_ETH_RX_OFFLOAD_RSS_HASH | RTE_ETH_RX_OFFLOAD_UDP_CKSUM, > }, > .rx_adv_conf.rss_conf =3D { > .rss_hf =3D RTE_ETH_RSS_NONFRAG_IPV4_UDP | RTE_ETH_RSS_NONFRAG_IPV4_TCP | > RTE_ETH_RSS_NONFRAG_IPV6_TCP, > .rss_key =3D conf_rss_key, > .rss_key_len =3D rss_key_len, > }, > .txmode =3D { > .offloads =3D RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_IPV4_CKSU= M, > }, >=20 > Regards, > Nandini >=20 > On Tue, Sep 3, 2024 at 5:03=E2=80=AFPM Stephen Hemminger > wrote: >=20 > > On Tue, 3 Sep 2024 14:43:28 -0700 > > Nandini Rangaswamy wrote: > > =20 > > > Hi Stephen and Long, > > > I was going through one of the netvsc patches > > > https://mails.dpdk.org/archives/dev/2018-August/110559.html which =20 > > mentioned =20 > > > that netvsc and failsafe give the same performance in VF path whereas= for > > > some exception path tests, about 22% performance gain in seen. > > > I ran some tests locally with my dpdk app integrated with netvsc PMD = and > > > observed that netvsc does give nearly the same performance as failsaf= e in > > > the VF path. > > > Since the official document does not explicitly cite this, I would li= ke =20 > > to =20 > > > confirm if this holds good. > > > Regards, > > > Nandini > > > =20 > > > > Shouldn't be. What settings are you using. > > Both failsafe and netvsc just pass packets to VF if present. > > There is even more locks to go through with failsafe. > > > > Are you sure the test doesn't exercise something like checksumming which > > maybe different. > > =20 >=20 How many streams? RSS won't matter unless multiple streams. The netvsc driver does not have RSS for UDP as a listed flag. It turns out that for that version of NDIS, if you ask for TCP RSS, UDP RSS= is implied. RSS Key must be 40 bytes (Toeplitz) not 64 bytes. Just use the default key (rss_key =3D=3D NULL rss_key_len =3D 0) to be safe Check that packets are going to the VF. One way to do that is to look at xs= tats on both netvsc and mlx5 device.