From: Stephen Hemminger <stephen@networkplumber.org>
To: Nandini Rangaswamy <nandini.rangaswamy@broadcom.com>
Cc: Long Li <longli@microsoft.com>, users@dpdk.org
Subject: Re: Netvsc PMD : Hotplug handling : checksum offloads
Date: Thu, 19 Sep 2024 11:47:19 -0700 [thread overview]
Message-ID: <20240919114719.2389589a@hermes.local> (raw)
In-Reply-To: <CAAkQrK9xTqiAXvURFmpjpgbpA+qyRNzBZ-4SnSAH2bUPBsJDhA@mail.gmail.com>
On Thu, 19 Sep 2024 11:11:44 -0700
Nandini Rangaswamy <nandini.rangaswamy@broadcom.com> wrote:
> Hi Long/Stephen,
> I was going through the hotplug handling code in netvsc PMD and need
> clarification.
> Earlier with failsafe PMD , my dpdk app used to subscribe to hotplug events
> to set the checksum offloads to do software checksum calculation when VF
> was removed and switch to H/W checksum calculation when VF was added.
> I see even with netvsc PMD , it does not do anything specific to RSS
> /checksum offloads in hotplug callbacks but initializes VF port (through
> ioctl) during hotplug add and removes VF port in hotplug remove callback.
> So my understanding is, the dpdk app should continue to handle the checksum
> offloads as part of hotplug callbacks and netvsc will not handle it
> automatically.
> Can you confirm if this is correct?
> Regards,
> Nandini
The code should look at the checksum flags in each packet, rather
than assuming VF hotplug will change things.
prev parent reply other threads:[~2024-09-19 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 18:11 Nandini Rangaswamy
2024-09-19 18:47 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240919114719.2389589a@hermes.local \
--to=stephen@networkplumber.org \
--cc=longli@microsoft.com \
--cc=nandini.rangaswamy@broadcom.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).