From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76E09459D8 for ; Thu, 19 Sep 2024 20:47:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2E7C433AC; Thu, 19 Sep 2024 20:47:24 +0200 (CEST) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by mails.dpdk.org (Postfix) with ESMTP id 8E332406FF for ; Thu, 19 Sep 2024 20:47:23 +0200 (CEST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-27c90f1e968so776077fac.2 for ; Thu, 19 Sep 2024 11:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726771642; x=1727376442; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dHlUnD1C9+vCf3JDxJ9UAbsXro9xdPWcYhXSpaVrNhY=; b=bNUnbsqXOEy+AY2qVsucqE0jmZ+bZU7FCTd2MFDv0B0YsXJKpVTE8+dKR5cMnVrd9V MtRfdwFyAEmlIj9Aui/Qh4u5RBomZv7SM8B7SFE4yh+BPscFL/ndho0hGc3PGnxI3vdx Fx984cbVWhyVcYscxP3d4T7SuVpglrL/EYK4/AsfmqKx0dz+ksRyDfQRanzLxloqebJ1 yAX75ix3M0yHP5k6BtYCScElCOfPxkknYGea2l9rTiu31DbkczPJIXgFAIoc2Hxtoy0Z NfqCyhx+WXMOQHiOBOOdOFsm/Td7XneQHkP+yKWz/DGSc+2RrZE1PkaV0HryvVvSw7Zv vPBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726771642; x=1727376442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dHlUnD1C9+vCf3JDxJ9UAbsXro9xdPWcYhXSpaVrNhY=; b=pS1094TW4ak1VHz1Vb5d1Npjv/1NL49ZmEoT05dYr3KUB64UpqfBR15jDfFC3kDO+F hZ7JCj55i1rwIli+OAa/8NoFN2Snp1fmKJnNSfHWGGphpWwcyaIbwrglKUZiS5cO9ewy LfuZqQ2pUyT6XtWQOhUlIL0pZT7xbtW/LW8HHJzrqL9skyZ+8XF+sST7ik2AMqwHod4G 66MEh0kqt85J+Bp/lqmBDPxqUBSoJFhuzw3Ss/MFVbs4zskyIPUsKq09IyDmP5HUw/6t xIhRJ3VJpwwqvbPnLpfM6eeaURNQ5WB4PQadq2T6jZG/05yy4bfFMM3hpChenkKoeQZn 9X6w== X-Forwarded-Encrypted: i=1; AJvYcCU0epWv4tMb7jHE+We3DsYeLj3sxmzZ5E5q/Yvs7bru/DApxmHsu6R4CsYlJW5oMBTBzo4CdA==@dpdk.org X-Gm-Message-State: AOJu0Yzu2gEqJe6yjVEF/PdbIUAi5CS7uw2+roqtcmhxe72brxk6wf2l Z2xj0qA+0uVPDbmxRnGqaYZhvtVk5o5pa8lo2J58WiJ+ERIrMSvRsT/Mz8e5Te0= X-Google-Smtp-Source: AGHT+IFktABTyjf1ht6Tw//gdxzYkIjYD/Oh8PNOG4p9PK8mihAPOlS3gUW9Ds9YIO0219mueE3fFw== X-Received: by 2002:a05:6870:969f:b0:277:f2a6:8f94 with SMTP id 586e51a60fabf-2803a7b8520mr260786fac.33.1726771642488; Thu, 19 Sep 2024 11:47:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db4999cfb7sm9655820a12.79.2024.09.19.11.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 11:47:22 -0700 (PDT) Date: Thu, 19 Sep 2024 11:47:19 -0700 From: Stephen Hemminger To: Nandini Rangaswamy Cc: Long Li , users@dpdk.org Subject: Re: Netvsc PMD : Hotplug handling : checksum offloads Message-ID: <20240919114719.2389589a@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Thu, 19 Sep 2024 11:11:44 -0700 Nandini Rangaswamy wrote: > Hi Long/Stephen, > I was going through the hotplug handling code in netvsc PMD and need > clarification. > Earlier with failsafe PMD , my dpdk app used to subscribe to hotplug events > to set the checksum offloads to do software checksum calculation when VF > was removed and switch to H/W checksum calculation when VF was added. > I see even with netvsc PMD , it does not do anything specific to RSS > /checksum offloads in hotplug callbacks but initializes VF port (through > ioctl) during hotplug add and removes VF port in hotplug remove callback. > So my understanding is, the dpdk app should continue to handle the checksum > offloads as part of hotplug callbacks and netvsc will not handle it > automatically. > Can you confirm if this is correct? > Regards, > Nandini The code should look at the checksum flags in each packet, rather than assuming VF hotplug will change things.