From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <users-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EB9645BC6 for <public@inbox.dpdk.org>; Thu, 24 Oct 2024 18:34:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F627434F5; Thu, 24 Oct 2024 18:34:01 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 608A64025C for <users@dpdk.org>; Thu, 24 Oct 2024 18:34:00 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2e2fb304e7dso915621a91.1 for <users@dpdk.org>; Thu, 24 Oct 2024 09:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729787639; x=1730392439; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zuvFyiTJaEcy1gi0Z3z0Gen/2+el8UWLY8Qo8VXq0bk=; b=wIRnHlV9BT4orgtjAgFZr5uOAM7tzzqGfiSnn0TMwniToyoMufTKn1Jr5sgeAqzLiS wRTE5T29dSVHhkJSO6Q2Bdx/M82UYF3x1Huw4HunsQmgWhMtrgqTH7HomGy9epWVNbCb W4e6TJMqrN8yloyLLn0NaAm+iL1ILVYQYpC5PpcvuTMe0YLTnlOMElFClXMSj50fAiTe 75eIIvZNGEz6qbqSXlFaw+vxxtV4YRK3ZstS/e0skSfHC+Uk5c5R6emv46jVCEQH6rdb AHuVm++V9oFNB5UECyAoyvzHORSo0e9CsmMXthnDerAJ8+wtaSiBEsLFa+89SzKLbO0W G0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729787639; x=1730392439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zuvFyiTJaEcy1gi0Z3z0Gen/2+el8UWLY8Qo8VXq0bk=; b=FHSeM9FGutFwO1ycMJnZepqvKHINdrCKeq0SR5Jy8u3IG8sAYtxEeJmzu8hxbbZMcr LutKGRQ4aMk9mL893h5+PVaFT+KE0LNlOhCtwshk9gm0KHS0c/efpw+Of5duS6tBCShn xDsMRWndpHCLTiNbKg/flNdA1az7D6FuhrWTQA5MAxbqrsYw2Z7fOjmx0RZycWER4W9h F1WFIYWABzF6iwCeKt4N9MsEWCWds4Uaguw8atccY3FKNuHAEVpttcDg1VkgLIKJ7UYl 3CtpjR70HiYpm9JsdZxmDvSDXtB7OYWZJenw4kf1grcxdHodMTfncubs33t1mqSb/e9J YQow== X-Forwarded-Encrypted: i=1; AJvYcCVSfWUrY4PJDSFiTK4qthJ6sfNV4rp7ftv73BsCzBxY6Fl+vKMEaXOYyI/Pd4Rvx8H3lMyqOA==@dpdk.org X-Gm-Message-State: AOJu0YypEWThELPVEemJxdL+LKOl8EspGItK4pP9pAS9oWoN78BuKpK8 XJBZjRmaa8BCiBL3mmT9eHntE8qqk4KBz70X4a4SDn+g+88KIa0ZNSBJOcqz3M4= X-Google-Smtp-Source: AGHT+IFOssU9E3BqDRQ7x/fLvzPfplJZhpJwpbu2mcGZ6xqgCaVm8xKipunmCb1uVEdKksWF+UL4OQ== X-Received: by 2002:a17:90b:3615:b0:2e2:dd25:9b00 with SMTP id 98e67ed59e1d1-2e77f461561mr3013790a91.22.1729787639425; Thu, 24 Oct 2024 09:33:59 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e76df7ae90sm3715472a91.35.2024.10.24.09.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 09:33:59 -0700 (PDT) Date: Thu, 24 Oct 2024 09:33:57 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Nandini Rangaswamy <nandini.rangaswamy@broadcom.com> Cc: Long Li <longli@microsoft.com>, users@dpdk.org Subject: Re: Netvsc PMD : Hotplug handling : checksum offloads Message-ID: <20241024093357.2473c767@hermes.local> In-Reply-To: <CAAkQrK8nP6SanRUhwbf9RBYoL-rk+v+HrVSDxeAOTRbcg+9rMw@mail.gmail.com> References: <CAAkQrK9xTqiAXvURFmpjpgbpA+qyRNzBZ-4SnSAH2bUPBsJDhA@mail.gmail.com> <20240919114719.2389589a@hermes.local> <CAAkQrK8nP6SanRUhwbf9RBYoL-rk+v+HrVSDxeAOTRbcg+9rMw@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions <users.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/users>, <mailto:users-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/users/> List-Post: <mailto:users@dpdk.org> List-Help: <mailto:users-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/users>, <mailto:users-request@dpdk.org?subject=subscribe> Errors-To: users-bounces@dpdk.org On Wed, 23 Oct 2024 13:34:53 -0700 Nandini Rangaswamy <nandini.rangaswamy@broadcom.com> wrote: > Hi Stephen, > The code looking at checksum flags in each packet would not give us desired > performance. Instead, should the dpdk app register callbacks for hotplug > add and re-configure the checksum offloads when VF is added again? > Regards, > Nandini The code in hn_vf_add which is where netvsc PMD handles hot add of VF should be feeding the current offload settings to the VF. Maybe the rte_eth_conf being passed to VF is incorrect, or the configuration step there is failing. Probably need more instrumentation and logs to tell.