From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <users-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A308A057C for <public@inbox.dpdk.org>; Thu, 26 Mar 2020 22:31:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF2241C02E; Thu, 26 Mar 2020 22:31:56 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C84A51B75C for <users@dpdk.org>; Thu, 26 Mar 2020 22:31:54 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 70D725C02D4; Thu, 26 Mar 2020 17:31:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 26 Mar 2020 17:31:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=YaPfbK1n25uvuEsBUuaXr5jzQ3kFNmOp2O+O4ozbtIY=; b=Qk+ineYf3aIo mpd7e0UjR5CI9eWFvhVU0oI58AEExbfmrEwk3caiQi0R7IgxTxw8XNz/w2Bl8Vt7 tMgJ7u0GDsmqi3xDbmDu+estNwKe7PC644DaLBaLkeZHga8EJW+UQydlCYoyWPAm brgYNtict4oI7v14gY4KlXP+4YNxKOk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=YaPfbK1n25uvuEsBUuaXr5jzQ3kFNmOp2O+O4ozbt IY=; b=H2Q0Q4zX9CHcqVJWnoAlOjnTpnfkTHcU0S5kLXSszfRTI1yDJrBKlMh7N ADe6ur00vTxlVdrY9pGGytzkMv24JTcAhXDj3tj39wRHjGxg+8E2/TZPxH82boAG fXEP2J8b7sAAo8jpMH1C8cF8PxbWQC2uDn3fyVwryBkgU7fRJnL2HVpfAF0Qq0ke 43KGh1/LYjo1mdJ5JFWhALUBnXIXy7s/cDcRw1MuXUbCt/R5V39DuVM64LDyWkl/ +6alJ6qeVS42AVoAl2qNezrCQwi/dEPB2Mphrq7wKwrLIlWLWn3VqQvrbj1wJAYY r3zVho53NSaSR0mP7xEQGKCYvEwTw== X-ME-Sender: <xms:Sh99Xp2ews5G1kmmGt2-dlKmqnwaDAM-ZULA7uAiLv4CRj3BKVmpPA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehjedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfugdrihhopdguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdef rddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:Sh99Xlm2uYykHexnN83lskNK-F1vtZ2lOaAY49_A2DUrCy1WUl_3og> <xmx:Sh99XiMxDW-9vd3Q737dO11GT2tzF-Zdovw6GmZ8Hb6_sciEJ0EHOw> <xmx:Sh99Xk4dvmQBnu9AXuzPRdj57dwqf-eRbxWzABlmiZox9Z7RL6sblw> <xmx:Sh99XhzAl1QzFNNus0fpRRxizZbJ-RlXcdonyBvmf4tSi0sxN3E7pw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 731D6328005A; Thu, 26 Mar 2020 17:31:53 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Benoit Ganne (bganne)" <bganne@cisco.com> Cc: users@dpdk.org, "viacheslavo@mellanox.com" <viacheslavo@mellanox.com>, "matan@mellanox.com" <matan@mellanox.com>, "rasland@mellanox.com" <rasland@mellanox.com> Date: Thu, 26 Mar 2020 22:31:52 +0100 Message-ID: <2170638.ECZNHGQPT7@xps> In-Reply-To: <1712113.QCnGb9OGeP@xps> References: <CH2PR11MB4327898A6961D9BC8A4DA2A3C1CE0@CH2PR11MB4327.namprd11.prod.outlook.com> <4c84d14c-e12f-298b-474b-0c1da812a6d2@mellanox.com> <1712113.QCnGb9OGeP@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-users] CX4-Lx VF link status in Azure X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions <users.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/users>, <mailto:users-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/users/> List-Post: <mailto:users@dpdk.org> List-Help: <mailto:users-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/users>, <mailto:users-request@dpdk.org?subject=subscribe> Errors-To: users-bounces@dpdk.org Sender: "users" <users-bounces@dpdk.org> On 3/26/2020 12:00, Benoit Ganne (bganne) wrote: > Just removing the over-strict check in mlx5 PMD is enough for everything to work fine: > https://gerrit.fd.io/r/c/vpp/+/26152/1/build/external/patches/dpdk_20.02/0002-mlx5-azure-workaround.patch [...] > 2) mlx5 PMD enforce that both link speed is defined and link is up to update interface state The original commit introducing this logic is: http://git.dpdk.org/dpdk/commit/?id=cfee94752b8f8f I would say that the first issue is a lack of comment in this code. Second, as Benoit said, we should relax this requirement. If the link speed is unknown, a second request can be tried, no more. Benoit, feel free to submit a patch showing how you think it should behave. Otherwise, I guess a maintainer of mlx5 will try to arrange it later. Note: a patch (even not perfect) is usually speeding up resolution. Thanks