From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: martin_curran-gray@keysight.com
Cc: users@dpdk.org, stephen@networkplumber.org, dev@dpdk.org
Subject: Re: [dpdk-users] Link Status and Interrupts in 2.2.0
Date: Wed, 27 Apr 2016 11:39:37 +0200 [thread overview]
Message-ID: <3616976.ag6djbJWME@xps13> (raw)
In-Reply-To: <22C95CA62CBADB498D32A348F0F073BC116CC81F@wcosexch02k.cos.is.keysight.com>
2016-04-25 11:49, martin_curran-gray@keysight.com:
> But if the link was "active" when dpdk and my app starts up,
> then no interrupt is generated, which then means that global
> structure is not filled in
You are describing the case of interrupts enabled but never called.
It has been fixed in DPDK 2.0:
http://dpdk.org/commit/99610782
But a race condition has been seen if interrupt fires during
rte_eth_dev_start() call. The decision was to remove link update if
interrupt is enabled (DPDK 2.2):
http://dpdk.org/commit/d5790b03
This "fix" was a bit strange:
- Is it possible to fix the race condition with link_update in the drivers?
- Is it possible to update the link status in dev_start of each driver
without race condition with the interrupt?
- Why calling link_update() from rte_eth_dev_start() in the polling case?
> I saw a submission to the patchwork 7160, dated Sep 24 2015
> but it was marked as not applicable , archived.....
It has been re-submitted and applied (hence the problem):
http://dpdk.org/patch/8112
prev parent reply other threads:[~2016-04-27 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 11:49 martin_curran-gray
2016-04-25 20:03 ` Stephen Hemminger
2016-04-26 6:03 ` martin_curran-gray
2016-04-27 9:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3616976.ag6djbJWME@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=martin_curran-gray@keysight.com \
--cc=stephen@networkplumber.org \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).