From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Coen <d.coen@resi.it>
Cc: users@dpdk.org, 'dawid_jurek' <dawid_jurek@vp.pl>,
sony.chacko@qlogic.com, harish.patil@qlogic.com,
rasesh.mody@qlogic.com
Subject: Re: [dpdk-users] R: Error in rte_eal_init using dpdk 16.04 and Qlogic (Broadcom) bnx2x driver in a SECONDARY process
Date: Thu, 05 May 2016 22:21:30 +0200 [thread overview]
Message-ID: <4994759.sGgJT4E6bM@xps13> (raw)
In-Reply-To: <!&!AAAAAAAAAAAuAAAAAAAAAKuKZlduhZNNohI3ULvVQaUBAMg6AHMwd4dMjwyZIszo7QkAAAABapoAABAAAAC8rH3RusnyTIunwc2ythakAQAAAAA=@resi.it>
2016-05-05 13:02, David Coen:
> Looking at Intel and Mellanox driver sources ("ixgbe_ethdev.c" and "mlx4.c" respectively),
> I found that, in the driver function called by rte_eal_init to initialize pci devs, is mandatory
> to distinguish if the process is running as SECONDARY (--proc-type=secondary in EAL prameters).
>
> For example:
> eth_ixgbe_dev_init() function of the ixgbe Intel driver, at line 988 :
>
> /*
> * For secondary processes, we don't initialise any further as primary
> * has already done this work. Only check we don't need a different
> * RX and TX function.
> */
> if (rte_eal_process_type() != RTE_PROC_PRIMARY){
> ... some code lines here ...
> return 0;
> }
>
> While in Mellanox mlx4 driver there is a check in ALL driver functions that makes them return
> immediatelly if the running process is of type "secondary".
>
> That means that a driver has to take into account that the process could be a SECONDARY process...
This is called "Multiprocess aware" in doc/guides/nics/overview.rst.
> but in Qlogic (Broadcom) bnx2x driver I didn't find anything about that.
It seems the driver do not comply with this multiprocess requirement.
> Do you think I've missed something ?
You are probably right :)
prev parent reply other threads:[~2016-05-05 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 19:07 [dpdk-users] " dawid_jurek
2016-05-05 11:02 ` [dpdk-users] R: " David Coen
2016-05-05 20:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4994759.sGgJT4E6bM@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=d.coen@resi.it \
--cc=dawid_jurek@vp.pl \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).