From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 35C405585 for ; Thu, 5 May 2016 22:21:33 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id a17so46020054wme.0 for ; Thu, 05 May 2016 13:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=63dlmrAS7BTlj2t8d5C5wj3pTAMh+UPDouILrTbzRVg=; b=2Pwf/GSUgzDGO8aUNy2akzD6almI1wnc/rEXNNEAosDDXqHn3ttguche6xBetN0asI SKsAbylKoM9zKbBUmV7Z7PpeGEjMTmg40KlNEt0T+gKOnGzI/tv5x9kUemyxE0ChxMC2 C7j997XjPFhZVxjJ+V4hT5Yvi+XNLH4pm7hm0Qq+c9jsFI7hYihP4ZQm1ZHOHk3LFIKk g3OGj5Tsbag4A7m+/8Jy6qIkKnoF1ZYTCmfRPGxhSRQP5uO3Cbhuw3E4Trsm8NIrdYV1 KNHfiiwzH2l11GsMIUWi93dTmQCBrHRhzr1hjJbNE/cMEPW6y1lbaFsqwkahUgBrwqTG U8RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=63dlmrAS7BTlj2t8d5C5wj3pTAMh+UPDouILrTbzRVg=; b=A15NJ2ih4NMNXIzoOl9PzG4Wn2hslXwoZgy8+84lDzD+TK0yvALywPwkQ7ivtdD6vl 5U6qvYbNLIx6x/N9YC+ZzzoJcsJx73+3t1fQT5orRxTBI4cdq1oSztx5IE+YMgOLqYvv 0JhPoKMzmIrlmkag//UrZPTDOJ8mVQt542h47KN1NOpi503os9jLK79fczS30rZsBX/0 WBhMgL/1k8o1CjmVYM/MiC6ozxq8vSDBVB7jW1RWf1PJdJ+3F6QIXbgQgEZAOAYzasJT C+SFpHcdlEMuatV8Cz7bFALlNVoQHby7ZzLCuhZ4486u9+ii85PtTUCzhXr1NBVVegRT kpkA== X-Gm-Message-State: AOPr4FWwCWfxYcvwV0dItZXvBkDT7kcNfepwi0pBk/DbN9p39XA1bNfPz3nGFqwMRmWI3noO X-Received: by 10.28.19.20 with SMTP id 20mr5662784wmt.5.1462479692964; Thu, 05 May 2016 13:21:32 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id us3sm11337838wjc.41.2016.05.05.13.21.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 May 2016 13:21:31 -0700 (PDT) From: Thomas Monjalon To: David Coen Cc: users@dpdk.org, 'dawid_jurek' , sony.chacko@qlogic.com, harish.patil@qlogic.com, rasesh.mody@qlogic.com Date: Thu, 05 May 2016 22:21:30 +0200 Message-ID: <4994759.sGgJT4E6bM@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <165831252-cca6483a472f578ccd9eda2a6841f697@pmq1v.m5r2.onet> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-users] R: Error in rte_eal_init using dpdk 16.04 and Qlogic (Broadcom) bnx2x driver in a SECONDARY process X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 20:21:33 -0000 2016-05-05 13:02, David Coen: > Looking at Intel and Mellanox driver sources ("ixgbe_ethdev.c" and "mlx4.c" respectively), > I found that, in the driver function called by rte_eal_init to initialize pci devs, is mandatory > to distinguish if the process is running as SECONDARY (--proc-type=secondary in EAL prameters). > > For example: > eth_ixgbe_dev_init() function of the ixgbe Intel driver, at line 988 : > > /* > * For secondary processes, we don't initialise any further as primary > * has already done this work. Only check we don't need a different > * RX and TX function. > */ > if (rte_eal_process_type() != RTE_PROC_PRIMARY){ > ... some code lines here ... > return 0; > } > > While in Mellanox mlx4 driver there is a check in ALL driver functions that makes them return > immediatelly if the running process is of type "secondary". > > That means that a driver has to take into account that the process could be a SECONDARY process... This is called "Multiprocess aware" in doc/guides/nics/overview.rst. > but in Qlogic (Broadcom) bnx2x driver I didn't find anything about that. It seems the driver do not comply with this multiprocess requirement. > Do you think I've missed something ? You are probably right :)