From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24A6EA2EEB for ; Mon, 7 Oct 2019 20:17:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B3061C06D; Mon, 7 Oct 2019 20:17:24 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by dpdk.org (Postfix) with ESMTP id CAA311C05C for ; Mon, 7 Oct 2019 20:17:23 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id m18so485966wmc.1 for ; Mon, 07 Oct 2019 11:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=saguna-net.20150623.gappssmtp.com; s=20150623; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=2A10Llpl+FnXHfLHF+pLL91We4w3h9/IE8xJYdaaqMo=; b=gQP2OeWsrzj8j5AxBE8Usf3/FTzKnUCe93FWUsTpFx9lxFpPi74r3NC8/SMp069Hzt RX6IlbuqEoLqtcE+sFvEF0Mty0aHO5GMYQt+UAc4dfqgClR6w96KTXav2S1RyjRINfid CC8W7P1T75QZz+od8lFLEmMj6j8rEU4nEsc7hvGuxjvK3+GlVcZlYqLZGom47zrKqoIv zw5rNFm0Q1QDT5ghkmswgxHsKXQKL7EgvPdJoxgsvyW+pTCTTJy4lzmxnUfVksqvCi31 hIrZql9MGX2uEqrYJseZ3LjPYqH8RJPn4Cid+mdfqFGLU0PE7QtzsstTqgC4msO/de7H zxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=2A10Llpl+FnXHfLHF+pLL91We4w3h9/IE8xJYdaaqMo=; b=oL99pkF1vuG4Ed8nxN5QnF/z5wtVZ7uqee8QYels6TdsQxkySlHfhS9WxeYAETRb+j ksSYA0Z7x2qU35aGtSKZPKcZVIpXvFwpdqsNXRJyq6e9uxr3bUkmrALVJvn2pbYJ5ijV vogwcJZb6BmyJ7I1S2gH+6rh7k7YX1H+wA+v5YhRhokM8YC3VYJTUFtMZAPSxKv5F/DU cvi9KXF7TcXtieisPMZa5uyqStL2XrN6E9l+7y9LehJcslCX1N7A8Gfer+FE19B6tBtq /Zk/Fn5HL56U/LFn5onnXwcqipLRmcdaCLRc6vqUFNyQXSukBDyVatMtbyPkDB3z0e31 VJNg== X-Gm-Message-State: APjAAAXugZoWoUgu4AUduZDZFn0s4I4M4vm7M8AKLDTw4NbjJo2d8coU fSfBwheRUmbZPtNtx2Avh5J2OU/Idl4= X-Google-Smtp-Source: APXvYqyTvVkZboObxXa+IH3Tx5jTMpeeve4yeKrMsoQ/6eJdhdxhVLMIo9Btd9mEHfVxg7ViVnoXzw== X-Received: by 2002:a1c:ed02:: with SMTP id l2mr398877wmh.155.1570472241657; Mon, 07 Oct 2019 11:17:21 -0700 (PDT) Received: from [192.168.11.100] ([77.138.64.131]) by smtp.gmail.com with ESMTPSA id t6sm648434wmf.8.2019.10.07.11.17.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2019 11:17:17 -0700 (PDT) To: users@dpdk.org From: Eugene Iskra Message-ID: <4ed5ac6c-046e-fc70-f756-e86fdaa16423@saguna.net> Date: Mon, 7 Oct 2019 21:17:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: [dpdk-users] bonding - slave mac address is not updated X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" Hello, I am using DPDK 18.11.2 with bonding in BONDING_MODE_ACTIVE_BACKUP mode. When both slaves are connected to the switch, the primary slave receives / sends traffic and everything work well. When the primary port is disconnected, and the secondary slave becomes primary, no packets are received, except for broadcast packets. Looking at bond_ethdev_lsc_event_callback in rte_eth_bond_pmd.c, I see that mac_address_slaves_update is called only when slave link is brought up, but if slave goes down, mac addresses are not updated. Also the mac_address_slaves_update function itself doesn't seem to update mac address correctly for the new primary port, since it updates internals->primary_port instead of internals->current_primary_port. Is this an actual bug or am I misunderstanding something / something is not configured right? Regards, Eugene