DPDK usage discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: wangyunjian <wangyunjian@huawei.com>,
	"dev@dpdk.org" <dev@dpdk.org>, "users@dpdk.org" <users@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>
Cc: Huangshaozhang <huangshaozhang@huawei.com>,
	dingxiaoxiong <dingxiaoxiong@huawei.com>
Subject: RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up?
Date: Mon, 10 Jan 2022 09:29:05 +0000	[thread overview]
Message-ID: <559e14c286d240caa7e1649df9664843@intel.com> (raw)
In-Reply-To: <41f0c2c9f77348fbb22dad35ef155536@huawei.com>



> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Monday, January 10, 2022 11:20 AM
> To: dev@dpdk.org; users@dpdk.org; Yang, Qiming <qiming.yang@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Huangshaozhang <huangshaozhang@huawei.com>; dingxiaoxiong
> <dingxiaoxiong@huawei.com>
> Subject: [dpdk-dev] [dpdk-users] A question about the link status of the intel
> E810 nic can not be up?
> 
> Hi, All:
> 
> I am using Intel E810 with DPDK v21.11 to create a dpdkbond but there is a
> probability that the failure will occur.
> 
> During the test, the bonding is repeatedly added and deleted. Sometimes, the
> link status of the NIC is Down. And if call ice_dev_set_link_up again, the link
> status of the NIC can be recovered.
> 
> Alternatively, the problem can be avoided by modifying the ice pmd driver.
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 13a7a9702a..fcd22e20a5 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3604,7 +3604,7 @@ ice_dev_start(struct rte_eth_dev *dev)
>         ice_dev_set_link_up(dev);
> 
>         /* Call get_link_info aq commond to enable/disable LSE */
> -       ice_link_update(dev, 0);
> +       ice_link_update(dev, 1);

This looks good to me, it's reasonable to wait for complete right after set link up as it is not in an link status change interrupt handling scenario.

We will try to reproduce this issue, meanwhile could you help on following below 2 things.

1. share the device ID / firmware version that you met this issue.
2. send a v2 with reworded title and commit log as a normal patch if you want to contribute.

Thanks
Qi

> 
>         pf->adapter_stopped = false;

  reply	other threads:[~2022-01-10  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  3:20 wangyunjian
2022-01-10  9:29 ` Zhang, Qi Z [this message]
2022-01-10 10:17   ` wangyunjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559e14c286d240caa7e1649df9664843@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=dingxiaoxiong@huawei.com \
    --cc=huangshaozhang@huawei.com \
    --cc=qiming.yang@intel.com \
    --cc=users@dpdk.org \
    --cc=wangyunjian@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).