From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D41FA00E6 for ; Tue, 6 Aug 2019 11:59:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 698DD1BE31; Tue, 6 Aug 2019 11:59:37 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40080.outbound.protection.outlook.com [40.107.4.80]) by dpdk.org (Postfix) with ESMTP id 334271B957 for ; Tue, 6 Aug 2019 11:59:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oo59C40s5LHV8nRP4StISbahcH7Jt1hGjMXZ8BGNdsOEOvR/Y5UtebuuCw6yv55W4thpExELJZLffMQr5c3elm/94ROvpnuoBt5j9Rg3pH3Ss41b5UhyFIre5BYnrc72CGZuzseyk6Pfvi6bVVfmUSZydUjJpcHWtr76HFUppe9VJxwjIV2RnqS3uTiP2f41WtGNCxo8IbVS7bqK/Gpq68vXVVErGW/YIwmbMv41IAHK2gtKMkW1pLC3SoDqbx/4nbVUkj0F8dfYcAptIvv1bPO00/Mc0yafVKEDcwc0lUYbCS9p/uaLFkc0d3KLIyLEpWTTyjsKO6SZvhcOivJrEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9szunxupK4w9kkdzZQIx3tYKLjZEPNL9y7zOruiVCIY=; b=eAdkIARemDDVqT+7y6zuGxRSf97fRDJr+695shq8Zjnpa15phn3CZijo5vaCP13DwkpbdFRynGhrOH/j30oFw2s5QtjQ0f5RY7V4t/BRqMx8ErRrq1LEF5eo+vDS7wNwi1EGNCv3RHR/ROPd9kq2pUbUzExcMybBDQrUbJtOa+oC+IVGETstKqqiBKZWfUFKLyQbih9qYWV5y7yKBXFOJ8AP8+WDvvSE02BVDuQTiNBkDDt8X0ptdYAYDrnnL+aaXObxVkUpEnN+0lYYP6vJpNA5Oz1Az5fNXToRQAkD2rDCDqt6ljoL+yyebOyJV8OlIZ/hAF1HghP5PujQOKl5Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9szunxupK4w9kkdzZQIx3tYKLjZEPNL9y7zOruiVCIY=; b=DDsP5OvuYw4aiVRZ9UsBzzzUsf28KuWnZiwBQlEtokpdv8BeELK7Bu+eixCEoNQKRFeSLag2VV3rOu3LTHLwkJwkQgsE0BXMVkXdsf4FVTy4xWeaMbGKcuU38u0NnRJwDSLXZu+t6d6+Z3MvpbF6cSBdbKoTwBc3Z5J3lvRLAPE= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.95.151) by AM0PR05MB5938.eurprd05.prod.outlook.com (20.178.203.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.15; Tue, 6 Aug 2019 09:59:34 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::d4a1:f970:c1ae:a0e]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::d4a1:f970:c1ae:a0e%7]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 09:59:34 +0000 From: Moti Haimovsky To: Adrien Mazarguil , Hideyuki Yamashita CC: Ye Xiaolong , "users@dpdk.org" Thread-Topic: [dpdk-users] Why flow can not be created? Thread-Index: AQHVPfiIQQTBUaX5Lk+qKIhglap016bWm3yAgAEnvICAC0Z0AIAAHi2AgADsIACAA2DjgIAGfV0AgAALrJA= Date: Tue, 6 Aug 2019 09:59:34 +0000 Message-ID: References: <20190730122539.GD4512@6wind.com> <20190731113045.8EC1.17218CA3@ntt-tx.co.jp_1> <20190802150619.D107.17218CA3@ntt-tx.co.jp_1> <20190806091234.GJ4512@6wind.com> In-Reply-To: <20190806091234.GJ4512@6wind.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c13c9f0-1580-48d3-205e-08d71a54c8ec x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR05MB5938; x-ms-traffictypediagnostic: AM0PR05MB5938: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(13464003)(199004)(189003)(53546011)(102836004)(53936002)(8936002)(14454004)(486006)(305945005)(33656002)(6506007)(76176011)(86362001)(7736002)(2906002)(6116002)(256004)(3846002)(76116006)(81166006)(66066001)(4326008)(186003)(71200400001)(6246003)(7696005)(478600001)(5660300002)(229853002)(66446008)(55016002)(11346002)(66556008)(8676002)(316002)(25786009)(9686003)(68736007)(476003)(446003)(71190400001)(52536014)(99286004)(81156014)(66946007)(74316002)(64756008)(110136005)(6436002)(26005)(14444005)(66476007)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5938; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cy0aP8X9zYy9erJh+cmg/V3l3IO05tpIxkXTe8NGQceGqihduoWckMh4U74vCfA6tRPJp0dxnEDrIIdYhq95Hyb+y+lirMaSmBMqDAraRRPD+J5Ih61GB8uWmf3rvNIjB2iI0CjnDAB3883P17CPiaqwWh8hNyxds1P8secSHX8yjojMxBX9JRFPYvUd2UUirNMhpS9GqO+xOzFF9Kub3Lqd3Z8xOZGVIePksl/DBrMrzC9wM9PUyVVkjJUwxarwX6pOn3hSslBBDjQxeehSjTU5QraEUMHHxQzczWIRtxFnNFTPO54RFAu/OWDdRXX177Pq1Up9VQxZF8+1g0MuDTcgg6zBn84hhGj6MPOrpKuL+4EClswzUjmBJCHeXEGXzVruDhJk2sdZOd6nghAIF5JbcXYeNFePDWDbh4DL61Q= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c13c9f0-1580-48d3-205e-08d71a54c8ec X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 09:59:34.5798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: motih@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5938 Subject: Re: [dpdk-users] Why flow can not be created? X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" Mlnx5 Patches supporting rte-flow Vlan push/pop actions were submitted tod= ay.=20 Moti > -----Original Message----- > From: users On Behalf Of Adrien Mazarguil > Sent: Tuesday, August 6, 2019 12:13 PM > To: Hideyuki Yamashita > Cc: Ye Xiaolong ; users@dpdk.org > Subject: Re: [dpdk-users] Why flow can not be created? >=20 > On Fri, Aug 02, 2019 at 03:06:19PM +0900, Hideyuki Yamashita wrote: > > Helllo Experts, >=20 > I think most of them are on vacation :) >=20 > > Q1. Are there any NICs which supports entag/detag VLAN? > > I searched source DPDK source code with keyword "OF_POP_VLAN" or > "OF_POP_VLAN" > > and found some codes within mlx5_flow_tcf.c and cxgbe_flow.c. >=20 > Indeed only those two seem to implement that. However depending on > what you're trying to achieve, there could be a workaround as many driver= s > provide support for VLAN entag/detag outside rte_flow. >=20 > For Rx, you can dedicate queues to perform VLAN stripping through > rte_eth_dev_set_vlan_strip_on_queue(), and use rte_flow to redirect > traffic of interest to these queues after matching specific VLANs and oth= er > properties for instance. >=20 > If you don't care about specific VLANs or queues, you can request VLAN > stripping globally using ETH_VLAN_STRIP_OFFLOAD with > rte_eth_dev_set_vlan_offload(), then rely on mbuf->ol_flags & > PKT_RX_VLAN to retrieve it from mbuf->vlan_tci. >=20 > On the Tx side you simply have to request mbuf->ol_flags | PKT_TX_VLAN > while doing Tx. As for Rx, make sure DEV_TX_OFFLOAD_VLAN_INSERT is > among the Tx offloads requested during setup (rte_eth_conf- > >txmode.offloads). >=20 > > Q2. Are there any plans in DPDK community to update document about NIC > > to update support of rte_flow? > > I have heard the situation about document form Adrien, and to be > > honest I felt it is very hard to take try and error with testpmd for ev= ery NIC. >=20 > This was discussed in the past, however so far no action was taken. >=20 > I think we cannot summarize all supported combinations for each NIC while > covering their specific quirks efficiently. For instance, two NICs may su= pport a > given pattern item, but not necessarily at the same position in the patte= rn. > Likewise for pattern item fields, they may not support the same masks. >=20 > The most sensible approach is perhaps to provide a list of popular flow r= ules > tagged with the NICs supporting them. >=20 > Anyway since it's not a huge priority at the moment, you should start a > discussion on that topic on the dev@dpdk.org mailing list. Without noise, > nothing will happen :) As usual contributions are always welcome! >=20 > -- > Adrien Mazarguil > 6WIND