From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87E0B41CE5 for ; Mon, 20 Feb 2023 11:27:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F8CB43010; Mon, 20 Feb 2023 11:27:51 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9171440395 for ; Mon, 20 Feb 2023 11:27:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676888869; x=1708424869; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=guFoRKh/eLu5avN8jW9qmUapu2i0HL7xitpEgwppejw=; b=CxjCGag90PXiRryDUbwF/46FontHzMt9soxcXX/cO6UMwUpmq9m6tmI+ faojGGyvZ8dL94Nv11IcWUzxz91EtF2a6t2Cm7TB312XBI9GDB/19c/tB S0pGjzaIdWOCv2QFkgSeFksD+rQ30eIFQBZhe+d71kkCcNaMCsPe++RGF ehWmy2WLcLzdTq1bW92xWVVOjdFe6DS90/8mGazVc8dWdAzDUvPdxIdaP Be72y52PhHxCN2yOj3FlZlM9CojHxjFmAuVBG9xPYW285ymGwTWZ0ybfI 9P6To4oYRL1Bg+sXrCQlMya0uktNcFmARQLqmNkeTPIXQgKbUCkEvKlLW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10626"; a="330084433" X-IronPort-AV: E=Sophos;i="5.97,312,1669104000"; d="scan'208,217";a="330084433" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2023 02:27:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10626"; a="814080916" X-IronPort-AV: E=Sophos;i="5.97,312,1669104000"; d="scan'208,217";a="814080916" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2023 02:27:48 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 02:27:48 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Feb 2023 02:27:48 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 20 Feb 2023 02:27:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkh6xTpZpX5IhE82X2/3QErWxTwTc03L3G7wfkoyN0T4wwywUpY6JquIuLQ0onaurrJs7pP/IPt3lV05kSaEn/mFJV9xxlLUV9Y8Y+/iG74V5tlSzvmzZM4iDgzYrrcy9vZe0o1NT+Fpwpw0LOc8QOUH5mV4M7ksf8HteLbqge7RPvWGeqD/6EYyllAl9uKwPT0iFpwF7inKNYsjE1Th+J7Wx2hMwPqWlnSABR4SG6cEkd+NwIkQ9w0eAuvakhUvBwvD+HeJ+rbAMyqQpEN+Qc82IhJUscF5A0zR1u1YFHIWlod/GFFsoEOTZdRXxbw8UFPWBYXdy+AO9Gh+l1LO7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1P9joGBbIsfcwhcXGCjwYXoMCBr6SJ+IyAt1h9SJ5C4=; b=CVVGCUahlMVBcSckOQV9zeDDNcDPvBVcTES8enMBZyICvUqvZmWJ0TZk5ir+2wOy54EmtWUgDRJcxQuf+dlUcjAZbVtx4orryoK5TdYY7pJiHliHoN4xgUlMAN6Mzm90k6rB2xSSo6kqhUTLJIhW4mlOrDzslTAdVq+eKPygQHd8lcvPKr8IclCd7tkDAZdYE4CZMd5KpMY66y5S8yVPOsMNLQt/Mp0TU1aZcRMK4r/XyDrdl7YvVyVPPvJ6KLfJwc0nprW/zgRhaUrIgSufxb8SxY88oE0pXJ1IiR7GlK1lYAZNHicW2UnhaW/pUI3J3UkEJg1zl5JrIgURTgWCgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) by SA2PR11MB4809.namprd11.prod.outlook.com (2603:10b6:806:112::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Mon, 20 Feb 2023 10:27:45 +0000 Received: from BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::b966:2d41:ca2e:6871]) by BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::b966:2d41:ca2e:6871%6]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 10:27:45 +0000 From: "Burakov, Anatoly" To: "Xiaoping Yan (NSB)" , "users@dpdk.org" Subject: RE: why rte_power_ethdev_pmgmt_queue_enable need to check if other queues are stopped Thread-Topic: why rte_power_ethdev_pmgmt_queue_enable need to check if other queues are stopped Thread-Index: AdlCBFLV8QoElG47QfeDBKVxvG5wigC7XY2wAAj7pdA= Date: Mon, 20 Feb 2023 10:27:44 +0000 Message-ID: References: <0c6664b4318142df94531165fb2acf94@nokia-sbell.com> <0684cc0bac6f4b4996899b1dd9eafbf4@nokia-sbell.com> In-Reply-To: <0684cc0bac6f4b4996899b1dd9eafbf4@nokia-sbell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR11MB1251:EE_|SA2PR11MB4809:EE_ x-ms-office365-filtering-correlation-id: 0396b08a-2f1f-409a-4cb5-08db132d1aa4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3DuPjwQoUj8jZjeA5sk62Qnnf3Dk5FTgmMMOVjNQtTB6Wa1HUAo9ZDxpM18rEoMYes0UzLxglMG5mXK0Ouu1keqnVGMZ2lWLyUphYeW9KB5m6+9Sm4qIvv5E6UDYekcWcEJofK4ea/M7ooXnYgylXn2MgCvkvb/qaLrA4FjqjXbC66ccfHWApPJvxqNORM6I8I1+NsR56A4JPygv3jeDwzUIVW6h40wg9ZwoJsA9qHS+JRT6JesiWbMQml3UuuA6TFReuUZA/VW5YaODND5VIN1KAojY3jERrmezK1Gj+6NmFbyt4MK5f9qHxs90KSOWrWdmAS1noxlxlxqEUZTbbWIF3NCa3u0MWEfRvr+Y/NdIgHHnxEZoxuUznPwDjYZDysxhE72nxmQwdNmNNMlt7Zs5OsBuUGEEOgk32b17ziB+b9cGJ8QVf8ZCEo7mvaTR/vSeLQGdmcjr2REaJZ2Gjnj/1GePWnA+oGFKF1lbu5wvrB00+pA6bfXLHgqNdYv7WG2liiGwa1I1vneM46yhg26NljNQjgM0h6xe6jBQuRZYUqU50u6IdsnQtMnSK9l0inTE0y9KdTEzdXvJ0lfgXLLa7qF4+ZpcTptOqqfF9VNGWNkDTjKcxlACATyRNLGAuYYbDa0K/K8vuNvLoTOVidW6W/FtrzszOSP3Mj4nmNQK/i/bSw2spHsGS2EuxWb58VVk6e1P19Va8XrFwCKJfg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1251.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199018)(110136005)(5660300002)(86362001)(478600001)(316002)(186003)(9686003)(26005)(33656002)(9326002)(66476007)(52536014)(66446008)(7696005)(66556008)(71200400001)(8676002)(66946007)(2906002)(76116006)(8936002)(64756008)(38070700005)(53546011)(6506007)(55016003)(82960400001)(38100700002)(41300700001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VTc5NWdNNkd1clhqR2UzRVlDQzF4RktBM0tCbmtxNG5UWTVUNHlzSmdM?= =?iso-2022-jp?B?RWF2d0pPYzNQRG85S3RhOE9tam5NcGh1dkVCZHVEc0RGMnRMYmRneVZ0?= =?iso-2022-jp?B?YWVjTUd2TkN0ZS9GM2RheWEzeGkvQXQ3a0JmbktDL3pmWmFpbkRpU2RC?= =?iso-2022-jp?B?OUFKRUlJTkZYa1dKZEMyMGpJTkVGRyt1SEl3cXo4KzNvOUVpRThrZG5m?= =?iso-2022-jp?B?SGx4VXdQVXF1Y3pjdkJ1OC96dWliMktVN3JrcWU5Z3pOY2VTbmxDeFVZ?= =?iso-2022-jp?B?ZkFyV3ovbWh6YllZdmpVMEdMWCtWY1VlQXB6WWUrRUk1aHJrRDVaRFlI?= =?iso-2022-jp?B?dG5EUlkvWXREejArd3dmQjZvYWt2R2gwa09DSS93MDZDYjdWK3ZSMG92?= =?iso-2022-jp?B?emJIMytVYjRPMEJJQXNFMktsNWhPYkpwczVyV000THBoT2U5TWk0cUVZ?= =?iso-2022-jp?B?Q1JEUG83bTY0WUZZNFYvbkY3QlJrcW9BUDBQdkZpVTR3NXB1emJQdlB5?= =?iso-2022-jp?B?aU0vMXQycHdQSUhpUk4yRHNVWHJ2VWFxaDdjeFpOMVl3aitOWWhQcVJz?= =?iso-2022-jp?B?RWZFQUgxZFcyb0JlaDVRVUVaQjlkS3VqSThPVnJSUlBpeVIrVmVDWnNr?= =?iso-2022-jp?B?ZWswVTJlVXF2Mm9GZnErWXAvS2U5WC9CUUIvRkpFZnFqRzVYeGZ2eCsz?= =?iso-2022-jp?B?cFBSMDVNOXZsREMxZG0xTkdiL2FjbGdHVDM2UUVLOUE0b2p6ZWdTTFJ5?= =?iso-2022-jp?B?Ym5tMEIwb3VwZnJnSFJGak5ETzU4WnVRcGtQdzZEWHFOc1JPcU9QUzF3?= =?iso-2022-jp?B?M1FxcEczZVR2eExXL1Q2QlhaMmxqOG9qYjhURit0RWR0Y0V4V2FESW9t?= =?iso-2022-jp?B?MkJDT09mUkU2YjdRd1ZzRHVjVHRXSHFwR0hHb2xwMDE0anNFSHNIbTVS?= =?iso-2022-jp?B?QnNwalo2UTBXM044WjdubTBmaUtYVkJyMUwzbngvMVgva1hqNm9wZnkx?= =?iso-2022-jp?B?OE91bXBrVk1CVFNRUHJNSGMvcWFSRmhQNlhtdCtCelcyNzE0T1d6TVBR?= =?iso-2022-jp?B?RXNHQWdsRnhGUmRtMTV0N0xLUk1QNnBVZkJBZFl6akoyNXZLWTFwNzVP?= =?iso-2022-jp?B?Zmd4MXVwOFpWNDJ2b1FFQVNINHpkYzhGcTBUeDFCN0hsNU5zcytFZGlC?= =?iso-2022-jp?B?a3dxOHR0RWcyZlgwSWFXVjlmVUlPNzRQZlRjTnJEODJMc3FpK0piZlk0?= =?iso-2022-jp?B?cDJnUlUvS3UwQy9aOHYzK0hKQUplQys4dGV1MWE3UTV1WGRTZ3c4T0JR?= =?iso-2022-jp?B?WERhZlZzTTBJaTR2MVdUMVh5Ukl6dEhRSkxvTC9BT2NjOTZBZWcrdUYz?= =?iso-2022-jp?B?M3ZCZVNNRG56VWlSQUdRNnNrR1gwa0lQSCs3ZVU5OXNpcEs3WHp4eGRD?= =?iso-2022-jp?B?TmVUdm52clZFZU1tbmkyV0JPYjVLR3lwcEpJaDcyMlRIVTljRmlVQjRr?= =?iso-2022-jp?B?VFhYZDRCYk1jQnhOMHNaMzZNdWRWaHlGNjk3b2R4b24rSmlzTTR5bUVQ?= =?iso-2022-jp?B?NmdPMXZtVTNYS3RzLzhzWFByRDV1U1JyNjNJK0J3ajVmNXRWTnBleDZK?= =?iso-2022-jp?B?WWN5WU9FRGNhODJxRUM5YlJndS9TQlpHbFRrK3UxNlVzaWphOXloeG43?= =?iso-2022-jp?B?ejZ5RXZMN2JrSFc4S040amZXc2dyQlEwMWFnbHdOcmNNakdvZ0kxcTQ1?= =?iso-2022-jp?B?a0RlL0xWTGFmcE1TY0ZyL1FxNzVSZUI0cXhYMk90Tzd6N0pWWi9ITmh0?= =?iso-2022-jp?B?NitQWkx6NzlidEs0Qmw4WkxRZ29XSEovNGpUc0ZWemZNSHkxY1ZHZ0tS?= =?iso-2022-jp?B?LzhxaUpFKzd5dHJqRXByVVQwaWJuTTkxcnlQMlZHTUtBRG41TG00NUVn?= =?iso-2022-jp?B?WFlPU094SENraW9LcnhWUDlyc3AxMmRqMXZKMHIrdUZiZ2NQdnNBandX?= =?iso-2022-jp?B?WDNodjVtMGo0MXlLRjkxRXU0YkZFVTZHV1VvOTFOUDhwMkVwdGQ5TVRz?= =?iso-2022-jp?B?SFFBTys1S2lVbU9SYnRlL3dCOGlCVDB1Vk5qek5RQ01OcmMzR0dyY2Zy?= =?iso-2022-jp?B?OEpzVXFyQ2tqR0JMd0wxV2ZCa1JHditIOXRrbnd4TFUxUm4rYTV1UzZO?= =?iso-2022-jp?B?ai8wZXV4Z21VYlcrdVpla1pIa2l1Z08raUx1a0FoVWdRanpqTlowa3BZ?= =?iso-2022-jp?B?TmZiOWREemU1aERsSjIrOHRGSjVvM1h6V0s0V2JtV3REN296STZyejFz?= =?iso-2022-jp?B?Zk5CK1J2b1VXYnVxRTU1dG05OEhQTTdCWnc9PQ==?= Content-Type: multipart/alternative; boundary="_000_BN6PR11MB125181CC8523191BC53180F8F7A49BN6PR11MB1251namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1251.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0396b08a-2f1f-409a-4cb5-08db132d1aa4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 10:27:44.3863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d2sjSZwkGJCMvpvYRhu/Br71ECmUBO1PJQ6vzNJolUJdklP90IGeT8LhDPYIGClLIf6Sn4n3Xw2/2vKNQ5I4Uy9Tj2BskTAuKRoX5Ov0rDM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4809 X-OriginatorOrg: intel.com X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org --_000_BN6PR11MB125181CC8523191BC53180F8F7A49BN6PR11MB1251namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi, It is mainly because we=1B$B!G=1B(Bre install callbacks, which is not threa= d-safe unless the PMD is stopped. Our PMD=1B$B!G=1B(Bs internal config stru= ctures are not thread-safe. You should only start these ports after you con= figure everything. From: Xiaoping Yan (NSB) Sent: Monday, February 20, 2023 6:12 AM To: users@dpdk.org; Burakov, Anatoly Subject: RE: why rte_power_ethdev_pmgmt_queue_enable need to check if other= queues are stopped Hi Anatoly I see this multiple queue support is added by you. Could you kindly help me to understand why rte_power_ethdev_pmgmt_queue_ena= ble need other queues to be in stopped state? commit 5dff9a72b0efeab02a2b71e52c4871805b7e64cb Author: Anatoly Burakov anatoly.burakov@intel.com Date: Fri Jul 9 16:08:15 2021 +0000 power: support callbacks for multiple Rx queues Thank you. Br, Xiaoping From: Xiaoping Yan (NSB) Sent: 2023=1B$BG/=1B(B2=1B$B7n=1B(B16=1B$BF|=1B(B 21:00 To: users@dpdk.org Subject: why rte_power_ethdev_pmgmt_queue_enable need to check if other que= ues are stopped Hi experts, I=1B$B!G=1B(Bm trying to use dpdk power pmd management APIs in my dpdk appl= ication. My application uses several ports, each have one rx queue, and it goes like= this 1. Init first port, setup rx queue, call rte_power_ethdev_pmgmt_queue_e= nable, and start the first port 2. Init second port, setup rx queue, call rte_power_ethdev_pmgmt_queue_= enable, and start the second port 3. =1B$B!D=1B(B Now for the first port & queue, rte_power_ethdev_pmgmt_queue_enable return = success, but for the second port & queue, it returns -16 >From rte_power_ethdev_pmgmt_queue_enable code, I think it fails when checki= ng if other queues are stopped as well. /* check if other queues are stopped as well */ ret =3D cfg_queues_stopped(lcore_cfg); if (ret !=3D 1) { /* error means invalid queue, 0 means queue wasn't stopped */ ret =3D ret < 0 ? -EINVAL : -EBUSY; goto end; } This seems quite strange for me, why other queues have to be in stopped sta= te? Can anyone help to explain? Thank you. Br, Xiaoping --_000_BN6PR11MB125181CC8523191BC53180F8F7A49BN6PR11MB1251namp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable

Hi,

 =

It is mainly because we= =1B$B!G=1B(Bre install callbacks, which is not thread-safe unless the PMD i= s stopped. Our PMD=1B$B!G=1B(Bs internal config structures are not thread-s= afe. You should only start these ports after you configure everything.

 =

From: Xiaoping Yan (NSB) <xiaoping.ya= n@nokia-sbell.com>
Sent: Monday, February 20, 2023 6:12 AM
To: users@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com&g= t;
Subject: RE: why rte_power_ethdev_pmgmt_queue_enable need to check i= f other queues are stopped

 =

Hi Anatoly

 

I see this multiple queue suppo= rt is added by you.

Could you kindly help me to und= erstand why rte_power_ethdev_pmgmt_queue_enable need other queues to be in = stopped state?

 

commit 5dff9a72b0efeab02a2b71e5= 2c4871805b7e64cb

Author: Anatoly Burakov anatoly.burakov@intel.com

Date:   Fri Jul 9 16:= 08:15 2021 +0000

 

po= wer: support callbacks for multiple Rx queues

 

 

Thank you.

 

Br, Xiaoping<= /p>

 

From: Xiaoping Yan (NSB)
Sent: 2023=1B$BG/=1B(B2=1B$B7n=1B(B16=1B$BF|=1B(B 21:00
To: users@dpdk.org
Subject: why rte_power_ethdev_pmgmt_queue_enable need to check if ot= her queues are stopped

 

Hi experts,

 

I= =1B$B!G=1B(Bm trying to use dpdk power pmd mana= gement APIs in my dpdk application.

My application uses several por= ts, each have one rx queue, and it goes like this

1= .   &= nbsp; Init first port, setup = rx queue, call rte_power_ethdev_pmgmt_queue_enable, and start the first por= t

2= .   &= nbsp; Init second port, setup= rx queue, call rte_power_ethdev_pmgmt_queue_enable, and start the second p= ort

3= .   &= nbsp; =1B$B!D=1B(B

Now for the first port & qu= eue, rte_power_ethdev_pmgmt_queue_enable return success, but for the second= port & queue, it returns -16

From rte_power_ethdev_pmgmt_que= ue_enable code, I think it fails when checking if other queues are stopped = as well.

  &n= bsp; /* check if other queues are stopped as well */

  &n= bsp; ret =3D cf= g_queues_stopped(lcore_cfg);

  &n= bsp; if (ret !=3D 1) {

  &n= bsp;     /* error means invalid queue, 0 means queue wasn't stopp= ed */

  &n= bsp;     ret =3D re= t = < 0<= /span> ? = -EINVAL : -EBUSY;

  &n= bsp;     goto en= d;=

  &n= bsp; }

This seems quite strange for me= , why other queues have to be in stopped state?

Can anyone help to explain?

 

Thank you.

 

 

Br, Xiaoping<= /p>

 

--_000_BN6PR11MB125181CC8523191BC53180F8F7A49BN6PR11MB1251namp_--