DPDK usage discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "‪nick.tian@longsailingsemi.com‬" <nick.tian@longsailingsemi.com>,
	"Kinsella, Ray" <ray.kinsella@intel.com>,
	"users@dpdk.org" <users@dpdk.org>
Cc: Jason Liu <jason.liu@longsailingsemi.com>,
	Sunshine Qin <sunshine.qin@longsailingsemi.com>,
	Mediter Li <mediter.li@longsailingsemi.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Subject: RE: 回复:About memory cohere =?utf-8?Q?ncy
Date: Tue, 9 Aug 2022 13:13:49 +0000	[thread overview]
Message-ID: <BN6PR11MB1251CB2FF4C836E163F7FCCAF7629@BN6PR11MB1251.namprd11.prod.outlook.com> (raw)
In-Reply-To: <-i53c9zds4ykndnl7h3-yhbkk5-kgsfnt-f38r1oxaxtblo36mvi-a83f7gtz0vhzqd5bjs-dhfhu42a628faggreo-sbs31k-dpc6zx1kw4or-jmox04-xsim2p-wvtn6j-9q3vcdmr3epocv2h41-yaeuro.1660050357124@email.android.com>

[-- Attachment #1: Type: text/plain, Size: 9762 bytes --]

rte_malloc merely distributes memory that was already allocated from the system using mmap(). This isn’t even guaranteed with hugepages unless you’re using IOMMU or using legacy mem mode, but without hugepages, there is no way we can allocate physically contiguous memory, because we have no control over what the kernel gives us.

So, the underlying memory will not be physically contiguous, and, as a consequence, neither will be one given out by rte_malloc.

Thanks,
Anatoly

From: ‪nick.tian@longsailingsemi.com <nick.tian@longsailingsemi.com>
Sent: Tuesday, August 9, 2022 2:06 PM
To: Burakov, Anatoly <anatoly.burakov@intel.com>; Kinsella, Ray <ray.kinsella@intel.com>; users@dpdk.org
Cc: Jason Liu <jason.liu@longsailingsemi.com>; Sunshine Qin <sunshine.qin@longsailingsemi.com>; Mediter Li <mediter.li@longsailingsemi.com>; jerinj@marvell.com
Subject: 回复:About memory cohere =?utf-8?Q?ncy

Hi Anatoly
Memory allocated with ‘no-huge’ will not be physically contiguous.

Do you means dpdk can not guarantee the memory which allocated by calling rte_malloc once is physically continuous?

Or memory1(allocated by rte_malloc at first) and memory2(allocated by rte_malloc later) is not contiguous?




-------- 原始邮件 --------
发件人: "Burakov, Anatoly" <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>
日期: 2022年8月9日周二 晚上8:16
收件人: "Kinsella, Ray" <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>, Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>, users@dpdk.org<mailto:users@dpdk.org>
抄送: Jason Liu <jason.liu@longsailingsemi.com<mailto:jason.liu@longsailingsemi.com>>, Sunshine Qin <sunshine.qin@longsailingsemi.com<mailto:sunshine.qin@longsailingsemi.com>>, Mediter Li <mediter.li@longsailingsemi.com<mailto:mediter.li@longsailingsemi.com>>, jerinj@marvell.com<mailto:jerinj@marvell.com>
主 题: RE: 回复:回复:RE: About memory cohere =?utf-8?Q?ncy

Memory allocated with ‘no-huge’ will not be physically contiguous. Whether it’s cacheable is, I assume, depending on your platform. I can’t comment on ARM platforms, so I’ll defer to Jerin et al. to comment on this 😊



Thanks,

Anatoly



From: Kinsella, Ray <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>
Sent: Tuesday, August 9, 2022 12:44 PM
To: Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>; Burakov, Anatoly <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>; users@dpdk.org<mailto:users@dpdk.org>
Cc: Jason Liu <jason.liu@longsailingsemi.com<mailto:jason.liu@longsailingsemi.com>>; Sunshine Qin <sunshine.qin@longsailingsemi.com<mailto:sunshine.qin@longsailingsemi.com>>; Mediter Li <mediter.li@longsailingsemi.com<mailto:mediter.li@longsailingsemi.com>>; jerinj@marvell.com<mailto:jerinj@marvell.com>
Subject: RE: 回复:回复:RE: About memory coherency



Hi Nick,



Adding Jerin to direct your query. As I think you need some of the ARM guys to chime in here, coherency constraints are ARM is different to Intel.



Ray K



From: Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>
Sent: Tuesday 9 August 2022 12:32
To: Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>; Burakov, Anatoly <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>; Kinsella, Ray <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>; users@dpdk.org<mailto:users@dpdk.org>
Cc: Jason Liu <jason.liu@longsailingsemi.com<mailto:jason.liu@longsailingsemi.com>>; Sunshine Qin <sunshine.qin@longsailingsemi.com<mailto:sunshine.qin@longsailingsemi.com>>; Mediter Li <mediter.li@longsailingsemi.com<mailto:mediter.li@longsailingsemi.com>>
Subject: 回复:回复:RE: About memory coherency



Hi  Anatoly

Let me provide some detail about our user sce​nario.

1.Our HW platform does not support IOMMU, it's a ARM A53 based platform.

2.We try to use DPDK to accelerate the ethernet forwarding performance with our own HW accelerator(Let use HAC as abbreviate).

3.We configure DPDK as "no-huge", and try to use rte_malloc to allocate memory and pass the PHY address of this memory to HAC(write the PHY address to it's register).

4.When HAC receive the ethernet packet, it will parse the packet data and write the descriptor and payload to the memory which allocated in step 3.(The HAC know where to write since we already tell it the address with it's register).

5.Application use the virtual address of this memory to read the descriptor and payload to do something else.

As far as you know, the memory which would be passed to HW should be "uncacheable" and "physically continous" to avoid the in-coherency issue and other issue.

(Given 64 bytes start with Address1 has already in CPU L2 cache, in the meantime , HAC write 32 bytes from Address1, then in-coherency issue will happen. since if we read the content from Address1 with software, the software will get

the old copy from cache instead of the latest one in DDR).



So, I need to know the memory which allocated by rte_malloc( configure with no-huge) is UNCACHEABLE/Physically continous or not?

We need it physically continous and UNCACHEABLE,  otherwise it will not suitable for this user scenario.













------------------原始邮件 ------------------

发件人:Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>

发送时间:08/09/22 17:41:35

收件人:Burakov, Anatoly <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>, Kinsella, Ray <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>, users@dpdk.org<mailto:users@dpdk.org> <users@dpdk.org<mailto:users@dpdk.org>>

抄送:Jason Liu <jason.liu@longsailingsemi.com<mailto:jason.liu@longsailingsemi.com>>, Sunshine Qin <sunshine.qin@longsailingsemi.com<mailto:sunshine.qin@longsailingsemi.com>>, Mediter Li <mediter.li@longsailingsemi.com<mailto:mediter.li@longsailingsemi.com>>

主题:回复:RE: About memory coherency

Hi Burakov

Thanks for your reply.

BTW, about the memory reserved by memfd_create-->ftruncate-->mmap,

what on earth is the coherency between cache and DDR? In another word, is it cacheable?uncacheable?

Is it possible for application to pass this memory to a device with DMA controller(I mean pass the PHY addr coverted by  rte_mem_virt2phy to DMA controller)?

If yes, how can we ensure the coherency between cache and DDR?





static int eal_legacy_hugepage_init(void)

  memfd = memfd_create("nohuge", 0);
...

   fd = memfd;
    flags = MAP_SHARED; //MAP_SHARED means UNCACHEABLE?







------------------原始邮件 ------------------

发件人:Burakov, Anatoly <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>

发送时间:08/09/22 17:25:35

收件人:Kinsella, Ray <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>, Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>, users@dpdk.org<mailto:users@dpdk.org> <users@dpdk.org<mailto:users@dpdk.org>>

主题:RE: About memory coherency

There are two different issues at play here.



The purpose of “no-huge” flag is to run DPDK without requiring hugepage memory. Originally, this has been done using an anonymous mmap() call – so, this memory was not using any fd’s at all. This presents a problem with vhost-user, because it relies on fd’s for its shared memory implementation. This is what memfd (a relatively recent addition to the kernel) is addressing – it’s enabling usage of vhost-user with no-huge because memfd actually does create an fd to back our memory.



That said, while description says “malloc”, it istechnically incorrect because there’s no malloc involved in the process. The “malloc” term is simply shorthand for “use regular memory”, and should be understood in that context.



Thanks,

Anatoly



From: Kinsella, Ray <ray.kinsella@intel.com<mailto:ray.kinsella@intel.com>>
Sent: Tuesday, August 9, 2022 10:04 AM
To: Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>; users@dpdk.org<mailto:users@dpdk.org>
Cc: Burakov, Anatoly <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>
Subject: RE: About memory coherency





I may be incorrect, but is it not simply the case, that when using the no-huge parameter that MAP_HUGETLB is omitted from flags?



Ray K



From: Nick Tian <nick.tian@longsailingsemi.com<mailto:nick.tian@longsailingsemi.com>>
Sent: Tuesday 9 August 2022 03:55
To: users@dpdk.org<mailto:users@dpdk.org>
Subject: About memory coherency



Hi

I am confusing about the "no-huge" option of DPDK 21.11.

The dpdk usage said: --no-huge:Use malloc instead of hugetlbfs.

But when I check the EAL source code, I found some code piece like this:

It's look like "no-huge" option will lead dpdk use memfd_create-->ftruncate-->mmap to reserve memory

and then provide to application with rte_malloc.

Am I right?

If so, what the "malloc" in "use malloc instead of hugelbfs" refer to?



EAL_memory.c

static int eal_legacy_hugepage_init(void){

....

 if (internal_conf->no_hugetlbfs) {
....
#ifdef MEMFD_SUPPORTED
  /* create a memfd and store it in the segment fd table */
  memfd = memfd_create("nohuge", 0);
......

  /* we got an fd - now resize it */
   if (ftruncate(memfd, internal_conf->memory) < 0) {
.....

   fd = memfd;
    flags = MAP_SHARED;   }
....
  prealloc_addr = msl->base_va;
  addr = mmap(prealloc_addr, mem_sz, PROT_READ | PROT_WRITE,
    flags | MAP_FIXED, fd, 0);

...





[-- Attachment #2: Type: text/html, Size: 30420 bytes --]

  reply	other threads:[~2022-08-09 13:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  2:38 About memory coherency Nick Tian
2022-08-09  2:54 ` Nick Tian
2022-08-09  9:04   ` Kinsella, Ray
2022-08-09  9:25     ` Burakov, Anatoly
2022-08-09  9:41       ` 回复:RE: " Nick Tian
2022-08-09  9:59         ` Burakov, Anatoly
2022-08-09 11:32         ` 回复:回复:RE: " Nick Tian
2022-08-09 11:44           ` Kinsella, Ray
2022-08-09 11:57             ` Nick Tian
2022-08-09 12:16             ` 回复:回复:RE: " Burakov, Anatoly
2022-08-09 13:05               ` 回复:About memory cohere =?utf-8?Q?ncy ‪nick.tian
2022-08-09 13:13                 ` Burakov, Anatoly [this message]
2022-08-09 13:16               ` 回复:回复:RE: About memory coherency Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB1251CB2FF4C836E163F7FCCAF7629@BN6PR11MB1251.namprd11.prod.outlook.com \
    --to=anatoly.burakov@intel.com \
    --cc=jason.liu@longsailingsemi.com \
    --cc=jerinj@marvell.com \
    --cc=mediter.li@longsailingsemi.com \
    --cc=nick.tian@longsailingsemi.com \
    --cc=ray.kinsella@intel.com \
    --cc=sunshine.qin@longsailingsemi.com \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).