DPDK usage discussions
 help / color / Atom feed
From: "Berger, MichalX" <michalx.berger@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
	"users@dpdk.org" <users@dpdk.org>
Subject: Re: [dpdk-users] Can't compile QAT driver on Fedora30
Date: Tue, 19 May 2020 14:22:39 +0000
Message-ID: <BN7PR11MB267465D8320013E3D4D3E5F79EB90@BN7PR11MB2674.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB288043607D7D9852151372A9E4B90@SN6PR11MB2880.namprd11.prod.outlook.com>

Hi Fiona,

Appreciate your response!  The thing is that this issue suddenly popped up after the kernel upgrade - I just quickly kexeced into the older version (5.5) and QAT driver was compiled against its source without any hiccups.
By briefly diffing two kernel sources, it seems that it relates to changes introduced in timekeeping32.h and time.h. In the former, getnstimeofday(), that's used by QAT driver, is not declared anymore. As for the latter, #ifndef __KERNEL__ now hides the time* types. Commits that introduced this:

c766d1472c70d25ad475cf56042af1652e792b23 - time.h
412c53a680a97cb1ae2c0ab60230e193bee86387 - timekeeping32.h

So I think some changes needs to be done in the actual driver code. But I will try to reach out to folks at 01.org.

Thanks again for your quick reply! 🙂

Regards,
Michal
________________________________
From: Trahe, Fiona <fiona.trahe@intel.com>
Sent: Tuesday, May 19, 2020 2:56 PM
To: Berger, MichalX <michalx.berger@intel.com>; users@dpdk.org <users@dpdk.org>
Cc: Trahe, Fiona <fiona.trahe@intel.com>
Subject: RE: Can't compile QAT driver on Fedora30

Hi Michal,

The driver below isn't the DPDK QAT driver, it's the one from 01.org, so the support from that is on the 01.org forum.
Release notes https://01.org/sites/default/files/downloads/336211-014-qatforlinux-releasenotes-hwv1.7_0.pdf
give this link for support:
https://premier.intel.com

That said, it looks to me like missing development headers or similar. Have you followed the steps in the GSG here:
https://01.org/sites/default/files/downloads//336212-006qatsw-gettingstarted.pdf ?

Fiona

> -----Original Message-----
> From: users <users-bounces@dpdk.org> On Behalf Of Berger, MichalX
> Sent: Tuesday, May 19, 2020 10:18 AM
> To: users@dpdk.org
> Subject: [dpdk-users] Can't compile QAT driver on Fedora30
>
> Hi All,
>
> I am currently having some issues with compiling the QAT driver under Fedora30 running 5.6.11 kernel
> (gcc 9.3.1). Output below:
>
> make -C /lib/modules/5.6.11-100.fc30.x86_64/build M=/QAT/quickassist/qat modules
> make[2]: Entering directory '/usr/src/kernels/5.6.11-100.fc30.x86_64'
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxx/adf_drv.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.o
>   LD [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxx/qat_c3xxx.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxxvf/adf_drv.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxxvf/adf_c3xxxvf_hw_data.o
>   LD [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c3xxxvf/qat_c3xxxvf.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62x/adf_drv.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62x/adf_c62x_hw_data.o
>   LD [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62x/qat_c62x.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62xvf/adf_drv.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.o
>   LD [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_c62xvf/qat_c62xvf.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_cfg.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_isr.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_ctl_drv.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_dev_mgr.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_dev_err.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_init.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_accel_engine.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_aer.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_transport.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_admin.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_hw_arbiter.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/qat_uclo.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/qat_hal.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_cfg_dev_dbg.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_heartbeat.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_heartbeat_dbg.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_ver_dbg.o
>   CC [M]  /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.o
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c: In function ‘timespec_to_us’:
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:118:17: error: dereferencing
> pointer to incomplete type ‘const struct timespec’
>   118 |  return ((s64)ts->tv_sec * USEC_PER_SEC +
>       |                 ^~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c: In function ‘measure_clock’:
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:132:18: error: storage size of ‘ts1’
> isn’t known
>   132 |  struct timespec ts1;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:133:18: error: storage size of ‘ts2’
> isn’t known
>   133 |  struct timespec ts2;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:134:18: error: storage size of ‘ts3’
> isn’t known
>   134 |  struct timespec ts3;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:135:18: error: storage size of ‘ts4’
> isn’t known
>   135 |  struct timespec ts4;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:146:3: error: implicit declaration
> of function ‘getnstimeofday’ [-Werror=implicit-function-declaration]
>   146 |   getnstimeofday(&ts1);
>       |   ^~~~~~~~~~~~~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:135:18: warning: unused variable
> ‘ts4’ [-Wunused-variable]
>   135 |  struct timespec ts4;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:134:18: warning: unused variable
> ‘ts3’ [-Wunused-variable]
>   134 |  struct timespec ts3;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:133:18: warning: unused variable
> ‘ts2’ [-Wunused-variable]
>   133 |  struct timespec ts2;
>       |                  ^~~
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.c:132:18: warning: unused variable
> ‘ts1’ [-Wunused-variable]
>   132 |  struct timespec ts1;
>       |                  ^~~
> cc1: some warnings being treated as errors
> make[5]: *** [scripts/Makefile.build:268:
> /QAT/quickassist/qat/drivers/crypto/qat/qat_common/adf_clock.o] Error 1
> make[4]: *** [scripts/Makefile.build:505: /QAT/quickassist/qat/drivers/crypto/qat/qat_common]
> Error 2
> make[3]: *** [scripts/Makefile.build:505: /QAT/quickassist/qat/drivers/crypto/qat] Error 2
> make[2]: *** [Makefile:1683: /QAT/quickassist/qat] Error 2
> make[2]: Leaving directory '/usr/src/kernels/5.6.11-100.fc30.x86_64'
> make[1]: *** [Makefile:89: modules] Error 2
> make[1]: Leaving directory '/QAT/quickassist/qat'
> make: *** [Makefile:1560: qat-driver-all] Error 2
>
> I've been using what I think is the latest version of the driver: qat1.7.l.4.9.0-00008.tar.gz
>
> Any feedback on the above failure would be appreciated. 🙂
>
> This issue was initially reported here https://github.com/spdk/spdk/issues/1396.
>
> Regards,
> Michal
> --------------------------------------------------------------------
>
> Intel Technology Poland sp. z o.o.
> ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego
> Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN.
>
> Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje
> poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz
> trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione.
>
> This e-mail and any attachments may contain confidential material for the sole use of the intended
> recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any
> review or distribution by others is strictly prohibited.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  9:17 Berger, MichalX
2020-05-19 12:56 ` Trahe, Fiona
2020-05-19 14:22   ` Berger, MichalX [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN7PR11MB267465D8320013E3D4D3E5F79EB90@BN7PR11MB2674.namprd11.prod.outlook.com \
    --to=michalx.berger@intel.com \
    --cc=fiona.trahe@intel.com \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK usage discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/users/0 users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 users users/ http://inbox.dpdk.org/users \
		users@dpdk.org
	public-inbox-index users


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.users


AGPL code for this site: git clone https://public-inbox.org/ public-inbox