From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF8DB45BB6 for ; Wed, 23 Oct 2024 22:35:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F420F40261; Wed, 23 Oct 2024 22:35:06 +0200 (CEST) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 1029240144 for ; Wed, 23 Oct 2024 22:35:05 +0200 (CEST) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2fb5fa911aaso2137651fa.2 for ; Wed, 23 Oct 2024 13:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729715704; x=1730320504; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XQu18KsIERFDLKcshSji1LewdYjzviLCXHDqNn8SfbI=; b=UrGrKTqKpWprkzgB3F2Jvu8r1V3pfPl+7znGF+uAO8QvsFA0y/RyF/qyO/CfOOxKlp EuALa7D6ZoQgp/LkvVOnylOW0Co7QbmC1KSQT9EZcaVDMhnz2DVCwALDmKKMTsjGW1nR YGnSKDWz5yV1aWmfhIb0oytREsmqi7krwVXZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729715704; x=1730320504; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQu18KsIERFDLKcshSji1LewdYjzviLCXHDqNn8SfbI=; b=MXgh7B/b1mFvNrYlRrRqFE9xpACOq6Tj27n7CelX2gGUMZZ8HjGeBHlivjmPU/YKBd Gc+ZbC4BytWtraWWnR3vwQhFSNbgBrHk1gUrjxjTO8yqvQq54jawCCQDClrjVl6ubct7 Pt4rpRzOys1Q1+ylh1V9P8EzazR+7lQR5xCYFLb6N/rzwifK7aQRlV/wkP7IVlhuxCIA 9BgDlB0ns/6bjwIBcoyk4fkKZuWeQiOkZkmNbauns7qGAz7w+qAgXRqVxTLjlnfvhlWv f07xZ3epXcXOC0WpaqFKR9VAV2evBjVM709881gpyc6ukneL0qVdVjBbP8bwvN5CUWiX zxPQ== X-Forwarded-Encrypted: i=1; AJvYcCXyYk8epGjWfxzbfJSnW2Qar957liDmLca+zgbV/cY0lTmLiuqFFnvtLrC1du59c7MTcZyQpQ==@dpdk.org X-Gm-Message-State: AOJu0YxPdaFbf8b8L7B8IeCgRSblPYbPR8A2STqZAXF+BhkyA2VJwlKp eQcF4j2Wj9TcjMT+X47YdtpNE8JV/hm/8OjG08y3ogYQ39HMnKTQ0IZX1yrBC3bvVmYsvyHdU1h m0eK9VUn1786OGXu8DwCm+WRPuXU9rHdAZ5DR6XiAeecI8FbEkJEIIHIIbXo0bK14U7egkYlvET nX0RmdrBM= X-Google-Smtp-Source: AGHT+IH6W1hoN37MrPZWpPKqai5NtH3KD9SjO8PQ6iTBOhefqy4+0eRhxrkJ/luKW7ZFuXygVp9bgYcll1hR6AfR8OM= X-Received: by 2002:a2e:a593:0:b0:2fb:8c9a:fe3f with SMTP id 38308e7fff4ca-2fc9d3460a3mr36310351fa.22.1729715704298; Wed, 23 Oct 2024 13:35:04 -0700 (PDT) MIME-Version: 1.0 References: <20240919114719.2389589a@hermes.local> In-Reply-To: <20240919114719.2389589a@hermes.local> From: Nandini Rangaswamy Date: Wed, 23 Oct 2024 13:34:53 -0700 Message-ID: Subject: Re: Netvsc PMD : Hotplug handling : checksum offloads To: Stephen Hemminger Cc: Long Li , users@dpdk.org Content-Type: multipart/alternative; boundary="0000000000001e1f8e06252ad22f" X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org --0000000000001e1f8e06252ad22f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stephen, The code looking at checksum flags in each packet would not give us desired performance. Instead, should the dpdk app register callbacks for hotplug add and re-configure the checksum offloads when VF is added again? Regards, Nandini On Thu, Sep 19, 2024 at 11:47=E2=80=AFAM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Thu, 19 Sep 2024 11:11:44 -0700 > Nandini Rangaswamy wrote: > > > Hi Long/Stephen, > > I was going through the hotplug handling code in netvsc PMD and need > > clarification. > > Earlier with failsafe PMD , my dpdk app used to subscribe to hotplug > events > > to set the checksum offloads to do software checksum calculation when V= F > > was removed and switch to H/W checksum calculation when VF was added. > > I see even with netvsc PMD , it does not do anything specific to RSS > > /checksum offloads in hotplug callbacks but initializes VF port (throug= h > > ioctl) during hotplug add and removes VF port in hotplug remove callbac= k. > > So my understanding is, the dpdk app should continue to handle the > checksum > > offloads as part of hotplug callbacks and netvsc will not handle it > > automatically. > > Can you confirm if this is correct? > > Regards, > > Nandini > > The code should look at the checksum flags in each packet, rather > than assuming VF hotplug will change things. > > --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it. --0000000000001e1f8e06252ad22f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stephen,
The code looking at checksum flags in each= packet would not give us desired performance. Instead, should the dpdk app= register callbacks for hotplug add and re-configure=C2=A0the checksum offl= oads when VF is added again?
Regards,
Nandini

On T= hu, Sep 19, 2024 at 11:47=E2=80=AFAM Stephen Hemminger <stephen@networkplumber.org> wrote:
=
On Thu, 19 Sep 2024= 11:11:44 -0700
Nandini Rangaswamy <nandini.rangaswamy@broadcom.com> wrote:

>=C2=A0 Hi Long/Stephen,
> I was going through the hotplug handling code in netvsc PMD and need > clarification.
> Earlier with failsafe PMD , my dpdk app used to subscribe to hotplug e= vents
> to set the checksum offloads to do software checksum calculation when = VF
> was removed and switch to H/W checksum calculation when VF was added.<= br> > I see even with netvsc PMD , it does not do anything specific to RSS > /checksum offloads in hotplug callbacks but initializes VF port (throu= gh
> ioctl) during hotplug add and removes VF port in hotplug remove callba= ck.
> So my understanding is, the dpdk app should continue to handle the che= cksum
> offloads as part of hotplug callbacks and netvsc will not handle it > automatically.
> Can you confirm if this is correct?
> Regards,
> Nandini

The code should look at the checksum flags in each packet, rather
than assuming VF hotplug will change things.


This ele= ctronic communication and the information and any files transmitted with it= , or attached to it, are confidential and are intended solely for the use o= f the individual or entity to whom it is addressed and may contain informat= ion that is confidential, legally privileged, protected by privacy laws, or= otherwise restricted from disclosure to anyone else. If you are not the in= tended recipient or the person responsible for delivering the e-mail to the= intended recipient, you are hereby notified that any use, copying, distrib= uting, dissemination, forwarding, printing, or copying of this e-mail is st= rictly prohibited. If you received this e-mail in error, please return the = e-mail to the sender, delete it from your computer, and destroy any printed= copy of it. --0000000000001e1f8e06252ad22f--