From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 592D543BBE for ; Tue, 27 Feb 2024 20:24:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49C7742ECB; Tue, 27 Feb 2024 20:24:45 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 671CB40A81 for ; Tue, 27 Feb 2024 20:24:44 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-29aa8c4710bso92148a91.1 for ; Tue, 27 Feb 2024 11:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709061883; x=1709666683; darn=dpdk.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jBYb1VkLT2Of+1/mOG80tyJ2AqlOBQBasp+uF2GHaqE=; b=hS6hwJC9fDsHJx2RHAzUZenXy8k5oQ6/4HhItyYmwWc/wbr/cHsHOjGFEx2HY2C70+ tbQfHwosydQkMVILKNdN5dhEQrDjN8mkqFoFCFIuN7ZFXEVYIinhd8uIFqDdPN38G3N9 GKGv9HirbKFfMp3IH212w8DfkXF/11Se/JFk+ew8a1MP74tZ7Ow2hXj62BASjSvOpi1t Tz63ryIDXZvXh4xXMplUKJHKbYoC/i0CwRRaxOTCmUXC/DRD3nuD571Jnne4eL/ASjKy CbD6kD8vAn6gW/P0Jt2bUx5aPgL1H5rCkgHnU9x1DWewQ8oKT66pk2cN2rmAhCScm+vV wN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709061883; x=1709666683; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jBYb1VkLT2Of+1/mOG80tyJ2AqlOBQBasp+uF2GHaqE=; b=AUrZsebm989Kvo0A1WJT8rL3gn4oG4j18YDZH8mC/vqAFPYUQXOqsWan/HD9d6poFx Uh5xn09wviO9FDZR5HWh1XLDnJEMOEvj7D46IMQJmrO15T2UVdAWUV5QilnnhTBobAFe ZIt4MwJvFXgz6P5H1zJVxQVnHmKubN00O9QRfd+g2d0SJ/5rIzY4YUBD/4XwXsc8IZLI VUb0Lzs2IobCkdHCE7aQeIeJXT7E5wEZAQWBcX9YnQoafRxPOb/Bn88D2rBHKWWfX1nr pu9UgAqPeqv6/CnofBU+YrD9P9Uxci1AWf6xtvfZAKNn/WWHZpVF+vmYa6jOR6152CmY OxNA== X-Gm-Message-State: AOJu0YxUQfI3mHYVwl8V63Y/fzaqHz4EGEJzQFU9E+2H3tYr/2KqoM7k JDxvUnXUM4B5Shd4/cqMd4PqqVnvXo9MuKA+BPIT9LhVfwg7qRz2rziDRUwJVEc/4ZUPahP+rOG rCvOXQrgr1UJRguP93NMoq0jO453BDOrXALPO2w== X-Google-Smtp-Source: AGHT+IGlKVSCXsBtb0XOHL2uCLRJf8Yx7n78dp97bT9/geUDrEkKKqSjjXAnFr4ljEVifWzbBiwo5iIQWH4Dsh2thXc= X-Received: by 2002:a17:90b:370c:b0:29a:da24:d24d with SMTP id mg12-20020a17090b370c00b0029ada24d24dmr333955pjb.23.1709061883122; Tue, 27 Feb 2024 11:24:43 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Isaac Boukris Date: Tue, 27 Feb 2024 21:24:31 +0200 Message-ID: Subject: Re: iavf: rte_eth_stats_get() fails upon upgrade to 23.07.0 To: users@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, qi.z.zhang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Tue, Feb 27, 2024 at 4:28=E2=80=AFPM Isaac Boukris = wrote: > > On Tue, Feb 27, 2024 at 1:27=E2=80=AFPM Isaac Boukris wrote: > > > > Hello, > > > > This works fine with 23.03.0 but starting from 23.07.0 up to master it > > fails as follows. > > > > Initialization is ok: > > EAL: Probe PCI driver: net_iavf (8086:154c) device: 0000:09:00.0 (socke= t -1) > > iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set > > rx_pkt_burst as legacy for all queues > > > > telemetry.py /ethdev/link_status,0 | jq > > { > > "/ethdev/link_status": { > > "status": "UP", > > "speed": 40000, > > "duplex": "full-duplex" > > } > > } > > > > But the following command hang and fail: > > telemetry.py /ethdev/stats,0 | jq > > telemetry.py /ethdev/xstats,0 | jq > > > > On the logs I see: > > iavf_execute_vf_cmd(): No response for cmd 15 > > iavf_query_stats(): fail to execute command OP_GET_STATS > > iavf_dev_stats_get(): Get statistics failed > > I did some git bisect and found the commit below, help appreciated! > > 5712bf9d6e14d0eaa7a07814d59351ffeb8e02ed is the first bad commit > commit 5712bf9d6e14d0eaa7a07814d59351ffeb8e02ed > Author: Wenzhuo Lu > Date: Tue Apr 18 13:11:05 2023 +0800 > > net/iavf: add Tx AVX2 offload path > > Add a specific path for TX AVX2. > In this path, support the HW offload features, like, > checksum insertion, VLAN insertion. > This path is chosen automatically according to the > configuration. > > 'inline' is used, then the duplicate code is generated > by the compiler. > > Signed-off-by: Wenzhuo Lu > Acked-by: Qi Zhang > > drivers/net/iavf/iavf_rxtx.c | 33 +++++++++++++-------- > drivers/net/iavf/iavf_rxtx.h | 2 ++ > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 54 +++++++++++++++++++++++++----= ------ > 3 files changed, 62 insertions(+), 27 deletions(-) Notte that I was able to workaround it by forcing the old logic with: diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index f19aa14646..1537a5f19c 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4003,6 +4003,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev) use_avx512 =3D true; #endif + if (!use_sse) use_avx2 =3D false; + if (!use_sse && !use_avx2 && !use_avx512) goto normal;