From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7E3145E7B for ; Wed, 11 Dec 2024 21:52:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FBA040263; Wed, 11 Dec 2024 21:52:13 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 52D66400D7 for ; Wed, 11 Dec 2024 21:52:12 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2efd81c7ca4so1812013a91.2 for ; Wed, 11 Dec 2024 12:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733950331; x=1734555131; darn=dpdk.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yycWefv6aXAQ8RrILYz7B2nw71/gq7j7jPUsWkyQK8Y=; b=IoMq0enZbb8zk2pt3/iTuNYRtPausr7vF89SjtCDRg5+33u52gcJnyWI62nTRnWBjC XpZHrLmRchVzFxKsIhVhs65DwB6/UWi3TtlNGcadAkU+c6zEh2U2E2pr0EH6Exoxs0es f8C++7gbUf4v2oXi3TiFIJB7VfJgERpWW+iG71Kaz8koKYTe4wBIBPFRtW/sV0MVHpaG C2/AJmRpmhonx/1nWLpLmqp4tXrhG91FNCOBrHU+pEoc7PbPRIBxNLl8QMdDyzVPjglD JUvRFqjlVpfY8IjzFB+V8h2DLR+FSu/8Zz0klyOSv2F1ABP/m2dChk+lFKjGkkFPJJyh fXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733950331; x=1734555131; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yycWefv6aXAQ8RrILYz7B2nw71/gq7j7jPUsWkyQK8Y=; b=SrE/8v/OsjClmktrN5jAGDxYx64snjkSdgkXVhd1mCoVb7LBPcshznieD1/QDbW9df rOWz2XSjrLEEWIE/MvI2ZV+akEsF+UAk8vJFKuZdLezxXeJX2CqvAq2MgiuwqYHt5E87 pikEByneZfT/kETGRizXEKsMJxBycWTEtxjr5OHPU9/ZcFbMjh/Cr4d8fzmIp0Uto6BG GFT8Q1mixD3f3KJXKGe87vc6805jgUPkIQ7bgLQA9cqTQ7ggj21/NCgT+XhU2EispOIm o182B3TOyInlqrhx0SSkgor1N+XpXo3pcxxsD3N2je0+PhYI2cLfOpUZi0oy92wpGlkP vpUg== X-Gm-Message-State: AOJu0YyH3PYN5issnqnIdQp8yCwRXobs416FHpySSe8zgppEF8DkA4bY 6SArprbdoVnVSflW5q/oqWWUXKS/d5l8oUKv8C5nbSPhM/Wgl1JXXdwGTohrf8xxoe9kNWpO4Q7 UFhj6c7r2XxoeVT/0kSxcGgGccBkl53po X-Gm-Gg: ASbGncurpR9OvORlpFdQN8avHJz2PlLBPOfI/1hLswv3pxB5ynXaq3lFciXM9b1oLb+ bgPO/eORVXNxh+ir9rZcmLrn/xD/f4gFMruM/ X-Google-Smtp-Source: AGHT+IHqQXWHaka/LTnP8eQaZhGrxtpotugxNyu2bNMviXNtV60dYrVUV9nQidKa76eYeHm6Myu05IKGf8c5HhNpgvU= X-Received: by 2002:a17:90b:17cc:b0:2ee:7c02:8ef1 with SMTP id 98e67ed59e1d1-2f127fbcec5mr6204995a91.11.1733950331085; Wed, 11 Dec 2024 12:52:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Isaac Boukris Date: Wed, 11 Dec 2024 22:51:59 +0200 Message-ID: Subject: Re: iavf: rte_eth_stats_get() fails upon upgrade to 23.07.0 To: users@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, qi.z.zhang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org On Tue, Feb 27, 2024 at 9:24=E2=80=AFPM Isaac Boukris = wrote: > > On Tue, Feb 27, 2024 at 4:28=E2=80=AFPM Isaac Boukris wrote: > > > > On Tue, Feb 27, 2024 at 1:27=E2=80=AFPM Isaac Boukris wrote: > > > > > > Hello, > > > > > > This works fine with 23.03.0 but starting from 23.07.0 up to master i= t > > > fails as follows. > > > > > > Initialization is ok: > > > EAL: Probe PCI driver: net_iavf (8086:154c) device: 0000:09:00.0 (soc= ket -1) > > > iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set > > > rx_pkt_burst as legacy for all queues > > > > > > telemetry.py /ethdev/link_status,0 | jq > > > { > > > "/ethdev/link_status": { > > > "status": "UP", > > > "speed": 40000, > > > "duplex": "full-duplex" > > > } > > > } > > > > > > But the following command hang and fail: > > > telemetry.py /ethdev/stats,0 | jq > > > telemetry.py /ethdev/xstats,0 | jq > > > > > > On the logs I see: > > > iavf_execute_vf_cmd(): No response for cmd 15 > > > iavf_query_stats(): fail to execute command OP_GET_STATS > > > iavf_dev_stats_get(): Get statistics failed > > > > I did some git bisect and found the commit below, help appreciated! > > > > 5712bf9d6e14d0eaa7a07814d59351ffeb8e02ed is the first bad commit > > commit 5712bf9d6e14d0eaa7a07814d59351ffeb8e02ed > > Author: Wenzhuo Lu > > Date: Tue Apr 18 13:11:05 2023 +0800 > > > > net/iavf: add Tx AVX2 offload path > > > > Add a specific path for TX AVX2. > > In this path, support the HW offload features, like, > > checksum insertion, VLAN insertion. > > This path is chosen automatically according to the > > configuration. > > > > 'inline' is used, then the duplicate code is generated > > by the compiler. > > > > Signed-off-by: Wenzhuo Lu > > Acked-by: Qi Zhang > > > > drivers/net/iavf/iavf_rxtx.c | 33 +++++++++++++-------- > > drivers/net/iavf/iavf_rxtx.h | 2 ++ > > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 54 +++++++++++++++++++++++++--= -------- > > 3 files changed, 62 insertions(+), 27 deletions(-) > > Notte that I was able to workaround it by forcing the old logic with: > > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c > index f19aa14646..1537a5f19c 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -4003,6 +4003,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev) > use_avx512 =3D true; > #endif > > + if (!use_sse) use_avx2 =3D false; > + > if (!use_sse && !use_avx2 && !use_avx512) > goto normal; FYI, I was able to fix this and drop my patch by upgrading the firmware on the host machine. From: kernel: i40e 0000:37:00.0: fw 8.5.67516 api 1.15 nvm 8.50 0x8000b6d7 1.3082.0 [8086:1583] [8086:0002] To: kernel: i40e 0000:37:00.0: fw 9.150.77492 api 1.15 nvm 9.50 0x8000f146 1.3597.0 [8086:1583] [8086:0002] Perhaps we should have a compatibility matrix on the iavf doc page, like the one we have on the i40e PF one. HTH