From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3008FA0509 for ; Wed, 6 Apr 2022 17:32:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F10A24290C; Wed, 6 Apr 2022 17:32:25 +0200 (CEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mails.dpdk.org (Postfix) with ESMTP id 8F52B428A2 for ; Wed, 6 Apr 2022 17:32:24 +0200 (CEST) Received: by mail-ed1-f45.google.com with SMTP id f18so3089384edc.5 for ; Wed, 06 Apr 2022 08:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BiGa19y3DaJsOMQvTLE3j49MzbsSxY6myWso4UD4MU8=; b=JW8PSEgaSJ/6nohEanXspye0vf1o1/zYutMkp0lZeZ2xvuKd2CNe4uWnjC8iDaLoFx JtLqn9anQMxSYHr0rV5WC7vQweuX1UkEPxZZ/wX5XyLffR22M4/STqJkVThLa3370qie Kud10XmXhJBxAzZZFl2egpoklvhudYC4bCT1skFNCaaWTx3Y3Dd/irlPEQKes8xMWX/y xPImxqEUcdugjrn13YeAqDvw2dOf2G6wmXqNnZx2y6mS0vyd+hbF5IENRJXWGMCkRqO8 mbJa1JI+/x1PKiLJr0SrTz5T/IL5Ax+pDn8rm7Tfn3FnjGHFMJDcv37MDPIKhb13W2wR qpnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BiGa19y3DaJsOMQvTLE3j49MzbsSxY6myWso4UD4MU8=; b=uZ9iB4el7io41JmJ0CrWAeL4NRinjiQk2/s8RXnPi2RVx0oJT4iiKpxY97d1DilE5R pMbfxla8NELOJebQzXwzhni2H40+od16fqoOrL7Qa1sJHqfRhcnwd8T9AgbxyQxmf65f Ufw0G9BasVSyvZcl9SDKAQP7Bb4g2yHp36XRzCgUgCEH13jTWL46ONNZpriHqBXAAxnq HJAub0vqwB3gd0BKN00xDmlXZ01CX6fWC6FhIEc87cblqGUxFVEQQ4jnWW5VyJJfBl8E yO1ybD4tTIvMu8guaHvCTgqgVvYGXQ+1jJe3RHwfCKLtAODWHwb0UpEa5HCSod5799Ud WrQA== X-Gm-Message-State: AOAM531wMa92ylt0YGyn+tXP+FUwfx/kQ9f3HisibHtFyhegzJJpYnxv w+rWuPsQjYbUmv3M4qZd8f87GkmEg3htlS/tzU/P3jRL/Bg= X-Google-Smtp-Source: ABdhPJyBor/qScPGzRENMlFNUWsgHMgqDaichZUxsIeQAgFzb6BbqQTxfmPb7Cim5dtwsnfL+gHKeKbRGY1VrLQjnTQ= X-Received: by 2002:aa7:c793:0:b0:408:4a69:90b4 with SMTP id n19-20020aa7c793000000b004084a6990b4mr9277181eds.58.1649259144239; Wed, 06 Apr 2022 08:32:24 -0700 (PDT) MIME-Version: 1.0 References: <10708365.BaYr0rKQ5T@thomas> In-Reply-To: From: satish amara Date: Wed, 6 Apr 2022 11:32:15 -0400 Message-ID: Subject: Re: Fwd: QOS sample example. To: "Singh, Jasvinder" Cc: Thomas Monjalon , "users@dpdk.org" , "Dumitrescu, Cristian" Content-Type: multipart/alternative; boundary="0000000000006f5eec05dbfe112a" X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org --0000000000006f5eec05dbfe112a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jasvinder, I have a few more questions. Can you provide some clarity on tc_credits_per_periodtc_period is for how often the credits for traffic need to be updated. Is tc_credits_per_period is fixed based on tc_rate. Regards, Satish Amara On Fri, Apr 1, 2022 at 9:34 AM satish amara wrote: > Thanks for the info Jasvinder. I see there is an internal timer to see > when to refill the token buckets and credits. I have read the QOS > document. My understanding is that the DPDK code is using the same HQOS > thread CPU context to implement timer functionality during the pipe > selection and not leveraging on Linux timers or other timers. > > Regards, > Satish Amara > > On Fri, Apr 1, 2022 at 4:36 AM Singh, Jasvinder > wrote: > >> Hi Satish, >> >> >> >> DPDK HQoS scheduler has internal timer to compute the credits. The time >> difference between the two consecutive visit to the same pipe is used to >> compute the number of tb_periods elapsed and based on that, the availabl= e >> credits in the token bucket is computed. Each pipe has its own context >> which stores the timestamp of the last visit and it is used when pipe i= s >> visited to schedule the packets from its queues. >> >> >> >> Thanks, >> >> Jasvinder >> >> >> >> >> >> >> >> *From:* satish amara >> *Sent:* Thursday, March 31, 2022 9:27 PM >> *To:* Thomas Monjalon >> *Cc:* users@dpdk.org; Singh, Jasvinder ; >> Dumitrescu, Cristian >> *Subject:* Re: Fwd: QOS sample example. >> >> >> >> Thanks, Thomas for forwarding this to the group. >> >> I have one more question. Does DPDK QOS uses any internal threads/timer= s >> for the token bucket implementation?. The token >> >> buckets can be implemented in different ways. When are the tokens are >> filled, I see there is tb_period? >> >> It looks like the tokens are filled when the HQOS thread is trying to >> find the next active pipe? >> >> >> >> Regards, >> >> Satish Amara >> >> >> >> >> >> >> >> On Thu, Mar 31, 2022 at 3:39 PM Thomas Monjalon >> wrote: >> >> +Cc QoS scheduler maintainers (see file MAINTAINERS) >> >> 31/03/2022 18:59, satish amara: >> > Hi, >> > I am trying to understand the QOS sample scheduler application cod= e. >> > Trying to understand what is tc_period in the config. >> > 30. QoS Scheduler Sample Application =E2=80=94 Data Plane Development = Kit >> 21.05.0 >> > documentation (dpdk.org) >> > I= s >> > tc_period same as tb_period >> > tb_period Bytes Time period that should elapse since the last credit >> update >> > in order for the bucket to be awarded tb_credits_per_period worth or >> > credits. >> > Regards, >> > Satish Amara >> > >> >> >> >> >> --0000000000006f5eec05dbfe112a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Jasvinder,
=C2=A0 =C2=A0I have a few more questions.
Can you provide=C2=A0 some clarity=C2=A0on=C2=A0
= tc_credits_per_period
tc_period is for how often t= he credits for traffic need to be updated. Is tc_credits_per_period is fixe= d based on tc_rate.

Regards,
Satish Amara

On Fri, Apr 1, 2022 at 9:34 AM satish amara <satishkamara@gmail.com> wrote:
Thanks for the info = Jasvinder. I see there is an internal timer to see when to refill the token= buckets and credits.=C2=A0 I have read the=C2=A0QOS=C2=A0 document.=C2=A0 = My understanding is that the DPDK code is using the same HQOS thread CPU co= ntext to implement=C2=A0timer functionality during the pipe selection and n= ot leveraging on Linux=C2=A0timers or other timers.=C2=A0=C2=A0

Regards,
Satish Amara

On Fri, Apr 1, 2022 at 4:36 AM= Singh, Jasvinder <jasvinder.singh@intel.com> wrote:

Hi Satish,

=C2=A0

DPDK HQoS scheduler has internal timer to compute th= e credits. The time difference between the two consecutive visit to the sam= e pipe is used to compute the number of tb_periods elapsed and based on tha= t, the available credits in the token bucket is computed. Each pipe has its own context which stores the timesta= mp of the last visit =C2=A0and it is used when pipe is visited to schedule = the packets from its queues.

=C2=A0

Thanks,

Jasvinder

=C2=A0

=C2=A0

=C2=A0

From: satish amara <satishkamara@gmail.com>
Sent: Thursday, March 31, 2022 9:27 PM
To: Thomas Monjalon <thomas@monjalon.net>
Cc: users@dpdk.o= rg; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian &l= t;cristi= an.dumitrescu@intel.com>
Subject: Re: Fwd: QOS sample example.

=C2=A0

Thanks, Thomas for forwarding this to the group.=C2= =A0

I have one more question. Does DPDK QOS=C2=A0 uses a= ny internal threads/timers for the token bucket implementation?. The token<= u>

=C2=A0buckets can be implemented in different ways.= =C2=A0 When are the=C2=A0tokens are filled, I see there is tb_period?

It looks like the=C2=A0tokens are filled when the HQ= OS thread is trying to find the next active pipe?

=C2=A0

Regards,

Satish Amara

=C2=A0

=C2=A0

=C2=A0

On Thu, Mar 31, 2022 at 3:39 PM Thomas Monjalon <= thomas@monjalon.ne= t> wrote:

+Cc QoS scheduler maint= ainers (see file MAINTAINERS)

31/03/2022 18:59, satish amara:
> Hi,
>=C2=A0 =C2=A0 =C2=A0I am trying to understand the QOS sample scheduler = application code.
> Trying to understand what is tc_period in the config.
> 30. QoS Scheduler Sample Application =E2=80=94 Data Plane Development = Kit 21.05.0
> documentation (dpdk.org<= /a>)
> <https://doc.dpdk.org/guides-21.05/sample_app= _ug/qos_scheduler.html> Is
> tc_period same as=C2=A0 tb_period
> tb_period Bytes Time period that should elapse since the last credit u= pdate
> in order for the bucket to be awarded tb_credits_per_period worth or > credits.
> Regards,
> Satish Amara
>




--0000000000006f5eec05dbfe112a--