From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4227143C89 for ; Mon, 11 Mar 2024 16:11:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1F944027C; Mon, 11 Mar 2024 16:11:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A4D9B4026B for ; Mon, 11 Mar 2024 16:11:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710169895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYOx+778aEmUoY3hkbFQkZ33FI/CMs7cFL1TodGnVnQ=; b=NfzcwPkOrFlAisW5ouT8r1TdzT3LjuiKPCbUyl4vNmkDQR1byusHYlUxViymhy+0BTCdI9 /uSUfG6q5HYWD0yI4dNBKtfjkq4YkhE9iy7rq7RffOfpdsEKU8lctEtN5WE+wQ1w9hl26T c1zswgLbq5ekuKyxbq3WAoo2VmIpp+s= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-GJhKcNkgPkCsevkLsXubIA-1; Mon, 11 Mar 2024 11:11:28 -0400 X-MC-Unique: GJhKcNkgPkCsevkLsXubIA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d34ef51653so26114321fa.3 for ; Mon, 11 Mar 2024 08:11:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710169887; x=1710774687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYOx+778aEmUoY3hkbFQkZ33FI/CMs7cFL1TodGnVnQ=; b=ezhJnjUnuoHvzJHEl/+CvmqhzsEA0WbGEnsfksCsGlAE6QE6H/ytaX1xwds25owSFZ ei8FJjOGi1tm/rTxYEXBM3qymMqr2EEvA638TNyu5i+BIyVip4y+ObtN8sTOMwgWOChv RR//xekSOciRa6Wmg0DHr9NFCdNChT72ZftIalzgPD2tHh/OCsLpR77cPkJLvgpizJAI vYpV7inPk5Ef2Kxob+z8uoRWR83HnnBN8T5ukjiEpBiFJbxluEJ+eaz6fn5DvWcOaKJH 4tuh6ZPaQIHtwyhDosUSugSVIvxjokaZoupvp27CQKL1Hv+vcfVNEhiP5WWh68K2rPpz awZg== X-Gm-Message-State: AOJu0Yx0CT2sWUJPrEivxH+UBYbYsvKIDYm/r5ZoNMypGhPQrISUyJfo qxVh/Zwy3uKktKDUrKrFIjFxPmTSKtUZmHDX2VgQbAwxYH6Vbv31BDS3nerl1cMmhfjvu3IIpr/ EscKxLpKpiXICMuA5YXz97hRFcE98GaKuFLIXC6lUULJlVTatGvrs3AyI4Bj5ZEYqcMjiRzrLBJ 2YkZdglnXWmfgkH3gd5w== X-Received: by 2002:a2e:6818:0:b0:2d2:44df:b112 with SMTP id c24-20020a2e6818000000b002d244dfb112mr3161571lja.41.1710169887102; Mon, 11 Mar 2024 08:11:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKAa2egvYQR5Apu5TKI3AoL7X04UTuAWFVDpFUgyqpz0JdJ71ITDCSw2z2lqQ0cxD1vjYg4aPDmehy7X47mx0= X-Received: by 2002:a2e:6818:0:b0:2d2:44df:b112 with SMTP id c24-20020a2e6818000000b002d244dfb112mr3161550lja.41.1710169886452; Mon, 11 Mar 2024 08:11:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Mon, 11 Mar 2024 16:11:14 +0100 Message-ID: Subject: Re: [E810 Offload VLAN Stripping] To: Carlos de Souza Moraes Neto , Bruce Richardson , Vladimir Medvedkin Cc: "users@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Hello Carlos, On Mon, Mar 11, 2024 at 10:29=E2=80=AFAM Carlos de Souza Moraes Neto wrote: > Hello, > Adding some Intel folks. > I'm currently working on enabling the RTE_ETH_RX_OFFLOAD_VLAN_STRIP offlo= ad feature to strip VLAN tags and store the VLAN information in the vlan_tc= i field while using an Intel E810-XXVDA2 NIC. However, the VLAN tags are no= t being stripped. I=E2=80=99ve already tried to update DPDK (23.11), E810 f= irmware (4.40), ICE and DDP (1.3.35.0) but nothing. My console output is: > > EAL: Detected CPU lcores: 8 > EAL: Detected NUMA nodes: 1 > EAL: Detected shared linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'VA' > EAL: VFIO support initialized > EAL: Using IOMMU type 1 (Type 1) > EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.0 (socket -= 1) > ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package = (single VLAN mode) > EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:01:00.1 (socket -= 1) > ice_load_pkg_type(): Active package is: 1.3.35.0, ICE OS Default Package = (single VLAN mode) > EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.0 (so= cket -1) > EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.1 (so= cket -1) > EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.2 (so= cket -1) > EAL: Probe PCI driver: net_e1000_igb (8086:1521) device: 0000:02:00.3 (so= cket -1) > TELEMETRY: No legacy callbacks, legacy socket not created > ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 0). > ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 0). > ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not su= pport qinq > ice_set_rx_function(): Using AVX2 OFFLOAD Vector Rx (port 1). > ice_set_tx_function(): Using AVX2 OFFLOAD Vector Tx (port 1). > ice_vsi_config_outer_vlan_stripping(): Single VLAN mode (SVM) does not su= pport qinq I think I reproduce your issue (though I see messages claiming support for double VLAN in my setup). I tested with testpmd in v23.11 and a E810 nic: 04:00.0 Ethernet controller: Intel Corporation Ethernet Controller E810-XXV for SFP (rev 02) # ./build/app/dpdk-testpmd -a 0000:04:00.0 -- --enable-hw-vlan-strip -i ... ice_load_pkg_type(): Active package is: 1.3.30.0, ICE OS Default Package (double VLAN mode) ... testpmd> set verbose 1 Change verbose level from 0 to 1 testpmd> start ... port 0/queue 0: received 1 packets src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 - type=3D0x8100 - length=3D60 - nb_segs=3D1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER_VLAN L3_IPV4 - l2_len=3D18 - l3_len=3D20 - Receive queue=3D0x0 ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD I did a bisect, v22.11 worked for me and I ended up on: de5da9d16430 ("net/ice: support double VLAN") as the first bad commit. Reverting it restores vlan stripping for me on RHEL9. port 0/queue 0: received 1 packets src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 - type=3D0x0800 - length=3D60 - nb_segs=3D1 - VLAN tci=3D0x2a - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=3D14 - l3_len=3D20 - Receive queue=3D0x0 ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD Carlos, do you see the same? Bruce, Vladimir, could you have a look and confirm on your side? Thanks! --=20 David Marchand