From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E15EB42990 for ; Thu, 20 Apr 2023 04:30:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA8C94114B; Thu, 20 Apr 2023 04:30:49 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 6A89B40A4B; Thu, 20 Apr 2023 04:30:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681957846; x=1713493846; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=4BkvPaFC5fxu+HFykfFo+3RajjfybF8XKt45+JHF0uE=; b=aeDZ1dUX7TPHWGrVtR8Gy2O+3fXLpIoVmUfxElbpnpPp9OfQOMfs5Mnc KKj8dAB1RVNDNdcQmfj7sunaSR3PlHOm6RApjxChI2lvc4mk3FyojRdo+ GwKdYwIbtadqXpyfsqqc16nwz6Nj8GUZhnEysbBxho/BbwAGdPXh0cP7P Iad6/yf1ZfFpyaPGREwZGJdhnlK1ETTZanWJ8sG2OI7D/FY9YIyZrwPNA fJegG95T8UYEsGfQ014BnWL+RUbC4HV+uiyKLC9ftLaRZdewlSFJDtq0b COC6fdUAi7qWiLg/iPVtJfZb+O6HH0nM/QbpSsQCriZxCyAgf9t3j6cR5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="325944837" X-IronPort-AV: E=Sophos;i="5.99,211,1677571200"; d="scan'208";a="325944837" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2023 19:30:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="1021424938" X-IronPort-AV: E=Sophos;i="5.99,211,1677571200"; d="scan'208";a="1021424938" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 19 Apr 2023 19:30:44 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 19 Apr 2023 19:30:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 19 Apr 2023 19:30:44 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 19 Apr 2023 19:30:44 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 19 Apr 2023 19:30:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fWVwqftUfr+iLlc0COPd1d5jo/e29tlFIKpRbKE/cvVtkF5x0uThbCs5ZmRQtkvZy5CNRM7cFqgNCPTcrNsXP1soPlg5XI37qdL2j3xdnF+vgzU8A/V5s988jAmV3DT0xBpdmNTM11HESJcUjc/5uHrW8NV5iksPBGkulzYJ8etUQQtJDfEUdgc7ECfjZi7c+LI3BUy8T/ZRAYy+Q1qxekxMcCUJbFgTRu8drMyfSnyM/0pMYkNFTN24s+x4KfLViCkwImJ+6E0TNQtU6NjfC2S5CPx/HKO3kxHvwxkRcjf5OlograEIo1ogcnerSFXG90DVreFN5T/pogSIo8jlZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pm+AOPW98F44CnA/qVe6zFBx3y43QC3k6u8BM3MP0ro=; b=m8tAcOHZT/w3GT0eO59baJiUOvSdCGS+f/Omtq99WDacCb0oqWtCQYJA9Nn9LZt8gQ5kKS15MCj6syTM0evAQX5QIti17o9sAa5VgeL7jLsUjHSFJEQJtDYMX79CnDXcJxfQroCYpgaaayQFhyZesOCPIYm58c1sw8N5BoJ6bsvyvV8hr0+4m0dgo1GQU08njn38YKkY5nm7wd9VXqh/3orl5j9pZTuxYIVHQORPICBHfhJ+SoRO8t7Tb1kWRDZYbnUdbb16FTkrpET8+l+NLLPnHO9JAAERBHHne8829ZR4HrroOaaTx2SIHAahkuTzHs0YxV3CCBrffgSma4va5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6487.namprd11.prod.outlook.com (2603:10b6:930:31::17) by SN7PR11MB6750.namprd11.prod.outlook.com (2603:10b6:806:266::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.20; Thu, 20 Apr 2023 02:30:42 +0000 Received: from CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::6dae:8e03:4c29:4143]) by CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::6dae:8e03:4c29:4143%5]) with mapi id 15.20.6298.045; Thu, 20 Apr 2023 02:30:41 +0000 From: "Hu, Jiayu" To: "jiangheng (G)" , "users@dpdk.org" , "dev@dpdk.org" Subject: RE: [GRO] check whether ip_id continuity needs to be checked when two TCP packets are merged. Thread-Topic: [GRO] check whether ip_id continuity needs to be checked when two TCP packets are merged. Thread-Index: AdlvqIcRh1F/iP8VTjaqZ0Fg9f9SKQDhZnpw Date: Thu, 20 Apr 2023 02:30:41 +0000 Message-ID: References: <3bec4e84b0dc406887e9df08ddfd91ad@huawei.com> In-Reply-To: <3bec4e84b0dc406887e9df08ddfd91ad@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6487:EE_|SN7PR11MB6750:EE_ x-ms-office365-filtering-correlation-id: b1a346bb-4a96-4b53-a134-08db41473c68 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lx9mdjxxwheW0UkfHpvkqmNrn3RLrxZa0qeNAT/qpWjKoeThs977NFIjBLY/dzPjRET1XbDDgS78woR6eBsJI/69PwgM1aoJtmj46i1IDaz2/IahdDzjE0p+d3L2S8Q7vXZkBj1qDA/MNSDZI0rhKk+AEtTVXDwm+BEc8eaOI6tVFjVX+2REdnb9BHBqk/d7OnMuK0ez+EFQ+dqFh6MN7o6w/HhEySgEmPRZX22eMvaCNsD8sARHggfs18fkUQm3j/+aMJ1NitAS0yCTbDCyqQ/+2P7TrbrMJh1+CjB3rXM6Z5xgVcGMDTXDCmqDunyxqL6tqh6ViNcax7kaOUn3PmRiSqsoAks8eX5lLdZA/uUHW2AoHjH6rnQDBgwS5v5acLiKx8h/VPwBLAGJuXipyLMofr6m2iWoSzd/UbzlIyiT4hYtO6lnvNcXoH/S9vxXI1FYWEXXZHE+/xKGZdbO6S4KmPJYJpSsR0lb7cTfs9QB5yBbWgePJmtOpc8PMu63B92VcVTHynWcQ5pYTyvrViJUhUauYh8NrvaM8VaWsz8cM4TwbddSihs+oUc2dJcC23UqTsqV5Bw2ZbSJQ6TcVWNAtueMhpMFfgZketmR+ddcre45jy+e2o3lIXjT44u6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199021)(316002)(110136005)(66446008)(66556008)(66476007)(66946007)(64756008)(76116006)(186003)(53546011)(26005)(9686003)(6506007)(83380400001)(38100700002)(5660300002)(55016003)(41300700001)(8936002)(8676002)(7696005)(478600001)(71200400001)(33656002)(52536014)(86362001)(38070700005)(82960400001)(2906002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v1uiLFOY5uU1y/Gm/8XNHaR5Ws5QbjwPMK1Cwp3Zcuj+dCaSrtWV52kmDtfu?= =?us-ascii?Q?Q8lT9wHtO7M+k991djEn5E+cMT63sBQ7GWsnZbKW6y2ZQdHMgSnZ74X1TWzm?= =?us-ascii?Q?DCeo92MTOdg70NCMUBaXDQRB3lD803w2skIHEF35b4lyg7zMObNeCGuAb/Rb?= =?us-ascii?Q?Nm1RFWHkHW5DUiPI73Sl5Pc8IwtxMPlRSGSV9GsDdN4VZysYDIbr0MUvbW3C?= =?us-ascii?Q?EYxwh8L36f58pZ1DBv12iBHcu9Ik253iGrTG1tXYxzC6ITNIL5gi8oY0hMZa?= =?us-ascii?Q?lnRm87x4RMMV/WG5FWVXhcopMcykzCy4iHQ2V/E5l1Bn9h3MnXa1Zm/cLZXC?= =?us-ascii?Q?uoQ6GLhpzrFD4v1mGNtLRekbpbmd8v/aphBgkYGlfzV1KoRCPPxho96mlwh4?= =?us-ascii?Q?IGJ4eHiA7cW8kC6IRpATHkbOZSwhq5FCtWLJ+Cbi6T21CCix6Orthn4YcRvJ?= =?us-ascii?Q?pR4mjVP3ygOzQba9bk/UNmtQtXdlcDT7EqS5XuNecuOoiduFeZ5Uy5caoeop?= =?us-ascii?Q?O6h5i4fJ5jyWoz0aCO8pNhZ+4GYWeFlyl8FH6NpEPwmN2oJqYCR/3znoQugj?= =?us-ascii?Q?zv9j8YJifjw3OiheECCfqgSjevFnwsX9+qFDSTe+MPeVIvsKr1qKH6Vk2ua2?= =?us-ascii?Q?2hoHIgs0fETGleSc622WafJONP3nrakadaCcp7MSXMCp5Ci5BW0Dyr89SZqg?= =?us-ascii?Q?Xp+sOQk0CRf6gVL3eDwoaZ11voBTWsOd3OtqZUK9vh+ZvesBY0spcwAC9I8X?= =?us-ascii?Q?+wD+1P+RJukV4UHCJhcKDdbUnEe+VLILd/SaujlNqh1P32mF8f8Ms/uNC80a?= =?us-ascii?Q?wUFpTnOiIL3kvxLB6nrWcM9yyuV/+g/k6akbDGDH6nAcFRea0Wr6zq6hW3T7?= =?us-ascii?Q?bbMKVt1EjiPc2L5z04lTayYMFI72xLl/iksOLExpqw5q6PjdCaQITexxEMO4?= =?us-ascii?Q?4BHMHrMkED+tq/3kuubwhpDAeSTQS1At9y9kQ3QvSDS/orMHoW7d9aTQSamv?= =?us-ascii?Q?5h0dqIKj1SPp7y53kUkbZbpZBJODJ6/dTGh3AvGmQXJl1F+ma9F+BcUh0Klq?= =?us-ascii?Q?9DWKL8fPxDzvuXkyuk+YJHhu9AzJFMPlmwp2R+1SWhn5ZmEe0VrZMVemv6XV?= =?us-ascii?Q?AGz0UjBpOgnrZM69IGWeeRtCCu3bjxiEx9pLwETV+cxcR4SKERB7Sw+6khj/?= =?us-ascii?Q?FG6sra8TnS1G5GMRImkajllFgxILi/lkXduzk/McP3CkSLquRHRan/3noUZD?= =?us-ascii?Q?mI6/zd1+tXxcKtc8J/Fp/4Yr0M/KCK9jQD7TKCU02IZg0S+tElpGFEsLjjla?= =?us-ascii?Q?NnAUZ5ZHhShuL8ozh91ej2NCfaiC3QW5mF2+rFBCpK1I2ru1ND8Zfk7l+9pS?= =?us-ascii?Q?1EE8Iyyn4+t3ljMMvLU/Eoc8OsQMp5pevD/iFzrjGNV/DxKhliQ3IunFdH4T?= =?us-ascii?Q?LthVBXIZVhOQyekdfYqSFpwzBin38GmEUidneYeWAEn7YdUreJxCdxjgHMx6?= =?us-ascii?Q?Yo69LyedZN7IorDUugXAomHW0AMZfZJa8zhJqS09lI9o/V9mZ2N/bCnzUqs7?= =?us-ascii?Q?nGRAkSPZKKxx+dU50pg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1a346bb-4a96-4b53-a134-08db41473c68 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2023 02:30:41.4864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YVh/VM5Ca6jmV5twG1x3x68/lb1eUeqG+5FbG+Iyz7P5Z+QWDfG7yN59Vrubb63G54OQRi8LyudexMGdXzG6xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6750 X-OriginatorOrg: intel.com X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Hi Cheng, > -----Original Message----- > From: jiangheng (G) > Sent: Saturday, April 15, 2023 10:46 PM > To: users@dpdk.org; Hu, Jiayu ; dev@dpdk.org > Subject: [GRO] check whether ip_id continuity needs to be checked when > two TCP packets are merged. >=20 > Hi jiayu.hu >=20 > It cannot be guaranteed that 16bit identification field of ip packets in = the > same tcp stream will be continuous. > Please help check whether ip_id continuity needs to be checked when two > TCP packets are merged? > Seems to modify the following code, gro will aggregate better, and work > better: >=20 > diff --git a/lib/gro/gro_tcp4.h b/lib/gro/gro_tcp4.h index > 212f97a042..06faead7b5 100644 > --- a/lib/gro/gro_tcp4.h > +++ b/lib/gro/gro_tcp4.h > @@ -291,12 +291,10 @@ check_seq_option(struct gro_tcp4_item *item, > /* check if the two packets are neighbors */ > len =3D pkt_orig->pkt_len - l2_offset - pkt_orig->l2_len - > pkt_orig->l3_len - tcp_hl_orig; > - if ((sent_seq =3D=3D item->sent_seq + len) && (is_atomic || > - (ip_id =3D=3D item->ip_id + 1))) > + if (sent_seq =3D=3D item->sent_seq + len) For atomic packets, the IP ID field is ignored, as it can be set in various= ways. For non-atomic packets, it follows Linux kernel tcp_gro_receive(). Is this change specific to your case? Can you give more details on why it h= elps? Thanks, Jiayu > /* append the new packet */ > return 1; > - else if ((sent_seq + tcp_dl =3D=3D item->sent_seq) && (is_atomic = || > - (ip_id + item->nb_merged =3D=3D item->ip_= id))) > + else if (sent_seq + tcp_dl =3D=3D item->sent_seq) > /* pre-pend the new packet */ > return -1;