DPDK usage discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	venkatesh bs <venki.bsv@gmail.com>
Cc: "users@dpdk.org" <users@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
	nd <nd@arm.com>, nd <nd@arm.com>
Subject: RE: Regarding User Data in DPDK ACL Library.
Date: Mon, 21 Nov 2022 05:40:46 +0000	[thread overview]
Message-ID: <DBAPR08MB5814DA67E6366B19A716686E980A9@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <3755f0338ad546a9934644c7847b8c74@huawei.com>

<snip>

> 
> 
> > On Thu, 17 Nov 2022 19:28:12 +0530
> > venkatesh bs <venki.bsv@gmail.com> wrote:
> >
> > > Hi DPDK Team,
> > >
> > > After the ACL match for highest priority DPDK Classification API
> > > returns User Data Which is as mentioned below in the document.
> > >
> > > 53. Packet Classification and Access Control — Data Plane
> > > Development Kit
> > > 22.11.0-rc2 documentation (dpdk.org)
> > >
> > >
> > >    - *userdata*: A user-defined value. For each category, a successful
> > >    match returns the userdata field of the highest priority matched rule.
> When
> > >    no rules match, returned value is zero
> > >
> > > I Wonder Why User Data Support does not returns 64 bit values,
> 
> As I remember if first version of ACL code it was something about space
> savings to improve performance...
> Now I think it is more just a historical reason.
> It would be good to change userdata to 64bit, but I presume it will be ABI
> breakage.
Agree. We should support 64b and even 128b (since architectures support 128b atomic operations). This reduces required memory barriers required if the data size <= the size of atomic operations.

> 
> > Always its
> > > possible that User Data in Application Can be 64bit long, But since
> > > 64 bit User data can't be returned by DPDK ACL Library, Application
> > > should have the conversion algorithm from 64 to 32 bit during Rule
> > > add and vice versa after classification.
> > >
> > > I Wonder if anyone would have faced this issue, Please suggest any
> > > suggestions if somewhere am wrong in understanding/Possible Solution
> > > if someone has already gone through this issue.
> > >
> > > Thanks In Advance.
> > > Regards,
> > > Venkatesh B Siddappa.
> >
> > It looks like all users of this API use the userdata to be the index
> > into a table of application specific rules.
> 
> Yes, that's the most common way.
> Another one would be always (build/search) acl rules with two categories:
> rule for both categories will be identical, while data different (low/ho 32bits),
> but that's a bit too awkward from my perspective.
> 
> 
> 


  parent reply	other threads:[~2022-11-21  5:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 13:58 venkatesh bs
2022-11-17 22:52 ` Stephen Hemminger
2022-11-18 10:30   ` Konstantin Ananyev
2022-11-19 13:13     ` venkatesh bs
2022-11-21  5:40     ` Honnappa Nagarahalli [this message]
2022-11-21 14:15       ` Konstantin Ananyev
2022-11-21 16:56         ` Honnappa Nagarahalli
2022-11-22 13:38           ` Konstantin Ananyev
2022-11-22 15:53             ` Honnappa Nagarahalli
  -- strict thread matches above, loose matches on Subject: below --
2022-11-16 13:58 venkatesh bs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB5814DA67E6366B19A716686E980A9@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=nd@arm.com \
    --cc=stephen@networkplumber.org \
    --cc=users@dpdk.org \
    --cc=venki.bsv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).