From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AF16A046B for ; Fri, 26 Jul 2019 12:00:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D5B81C40F; Fri, 26 Jul 2019 12:00:36 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by dpdk.org (Postfix) with ESMTP id 4AB1B1C406 for ; Fri, 26 Jul 2019 12:00:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+aOHxPzrpmyOXAGDrhIWPFGJ4cGDFgcvjE7Yf9ByeCwQN/1KWWOm2owPxIUd6gAK+vk0Ke3YKiSChbNPOur7sBShkwRE+X4gIazJimuXCjxrMShb88cOxX5qOYrijImcigXW9CP7qY9ixlPUl2IysylPIz4GaulNRjbAUMuhHwSzE5jit4YtDGpGgcNtntjkLnGiMcIeOvFwlvxj0aviP8m7SneSjMAUnL1Iw8FtWjl9JkVMcu016Uu04PYBsI2YfYfUvs0aPJdDZtf6RTnA7AIAsYdw/tq71ZfNqtfMeEQBZdp6Kyw2FwyIS10DBbUzLmHBVewhvStlSBACkfzhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RDpbhUe9HzHathb+O/jW+ZiPbGvvZovNKQaOC3oYTGM=; b=TVMUwxq61igcB5P9pNhpO5qTRpcq/kCZW+fHASCWEN2vqmFJZVoN2SJkU1n4umjUpODxB3xuVpFptBLq9kLMQDlYB54twnZR7WFuNHHSUw+FH8bHVwwmBynyU44CEHAvXV/i/6T40UAAJxv44NGxMVdxIjctuyvm6WakD8KIh8QL04VwcQUB6MzSyJcZhxWp8gvQaEQmh1SsuA8Jvfb0Ke3DvyYR2wpocdBMJMOpqDhqf5eswhNcSjdI4vMREFajUVYsrhbF5y0vb62ogqwd2fBm70PyVJ6cdAcqZb98X1CyyZWPw/NYbKttEubfMa7DF0e1QOTnvtiD4wxWQzDO7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RDpbhUe9HzHathb+O/jW+ZiPbGvvZovNKQaOC3oYTGM=; b=TWlEF9EkHtxpF40aSXNF2fFF+ie2MgPbRbCcnTWabWD1TNyycC5zr0iXF/GjqUrlkiHAhTpeBsVNK+3CzHzfEGMfgGMpxaSe/dgNJN76iLD6V8CS27HXLStNq5QzkSiiGZT2rlFtT7jOHyCXP6LsjatJdfID22DHN348WbxDd70= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB4510.eurprd08.prod.outlook.com (20.179.27.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Fri, 26 Jul 2019 10:00:34 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0%2]) with mapi id 15.20.2115.005; Fri, 26 Jul 2019 10:00:34 +0000 From: "Gavin Hu (Arm Technology China)" To: "Zhang, Qi Z" , "Richardson, Bruce" , "Ananyev, Konstantin" CC: "users@dpdk.org" , Honnappa Nagarahalli , "Phil Yang (Arm Technology China)" , "Ruifeng Wang (Arm Technology China)" Thread-Topic: i40e vPMD fix out of order Rx read issue Thread-Index: AdVCzJhDNbgBl9FATkWplfpJPawhKgAEGCLwAC59RaA= Date: Fri, 26 Jul 2019 10:00:33 +0000 Message-ID: References: <039ED4275CED7440929022BC67E7061153D71548@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D71548@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7a215fff-b88d-449d-84b8-6d0b85dd017d.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a25a97e1-0b0b-4118-fdbc-08d711b019be x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB4510; x-ms-traffictypediagnostic: VI1PR08MB4510: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01106E96F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(13464003)(40434004)(189003)(199004)(55236004)(68736007)(102836004)(99286004)(74316002)(7696005)(3846002)(6116002)(76176011)(54906003)(81156014)(33656002)(8936002)(14454004)(66066001)(305945005)(81166006)(71190400001)(53546011)(110136005)(25786009)(478600001)(71200400001)(5660300002)(26005)(55016002)(8676002)(6506007)(66476007)(14444005)(7736002)(5024004)(6306002)(186003)(9686003)(256004)(66556008)(66946007)(64756008)(66446008)(229853002)(52536014)(76116006)(6246003)(966005)(2906002)(4326008)(86362001)(446003)(476003)(53936002)(486006)(11346002)(316002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4510; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 83l/qfxZ1TopphLJH+tTXELy1v9uIa7ofljmE0U36aUr3vkgLfTLTRlCL1C15FNzIhckcnMyUIN78/+a4XUMrQPUFt641f80oHT7S9TlypH2v8ktsIsEMBIQZlqFslvwMxCs8/QWoZTctBhjFcaot1Jh+WPJxnOVyAQ4kGzPiIUUprMyY/3b6i8QKtx4uQx+M6HA2NF9m5hGbtqMTOhDILqtGDL5fPrwgwKaCuLMNHxiNZm6ovmmwDCzRmpVjYSxchHbHcTTD4M5CrgJrRLJrdri3r41QSeMesDyd2JBH/KXv72irCvkyl88xeXm9R6L/3WvUEIpSnFE3r9OBcBygg5jeyHjdfCUYkP/HJAVSdZBLztUcWsMovHSbI/mZqGdPPDICcSz6xLDblDbLKa/EEuL9qfOO/aIuE2IsbFC2fI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a25a97e1-0b0b-4118-fdbc-08d711b019be X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 10:00:33.9007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gavin.Hu@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4510 Subject: Re: [dpdk-users] i40e vPMD fix out of order Rx read issue X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" Hi Qi, Thanks for your explanation! I did some testing and found the barriers caused a big drop in RFC2544 NDR = performance on aarch64, how about it on X86? Is it possible to count DD bits in a way of surviving across the out-of-ord= er descriptors reading? Best Regards, Gavin > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, July 25, 2019 8:11 PM > To: Gavin Hu (Arm Technology China) ; Richardson, > Bruce ; Ananyev, Konstantin > > Cc: users@dpdk.org; Honnappa Nagarahalli > ; Phil Yang (Arm Technology China) > > Subject: RE: i40e vPMD fix out of order Rx read issue > > Hi Gavin: > > in vPMD, we read 4 or 8 packets as batch, we count DD bits for packet > received, but not check the if they are continues or not, we assume it sh= ould > always be 1000, 1100, 1110, 1111 ....(take batch size is 4 as example) > while the out of order read instruction generated by compiler will > cause driver to get un-continues DD bits, like 1011, the descriptor on th= e hole > actually is invalid since when it is read , descriptor is not write back = yet, but we > still process this as 1110, it cause an corrupted mbuf returned. > > hope this is helpful. > > Regards > Qi > > > -----Original Message----- > > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > > Sent: Thursday, July 25, 2019 5:57 PM > > To: Zhang, Qi Z ; Richardson, Bruce > > ; Ananyev, Konstantin > > > > Cc: users@dpdk.org; Honnappa Nagarahalli > > ; Phil Yang (Arm Technology China) > > > > Subject: i40e vPMD fix out of order Rx read issue > > > > Hi Qi, > > > > I am working on optimizing the i40e vPMD on aarch64 and I see this patc= h > > relevant. > > Could you illuminate what issue this patch was fixing? > > I understand the PMD works at the driver layer, for delivery of L2 pack= ets. > > It does not own the responsibility to keep order(the responsibility lie= s with > the > > protocol stack, like TCP)? > > > > http://patches.dpdk.org/patch/16665/ > > > > Best regards, > > Gavin > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended re= cipient, > > please notify the sender immediately and do not disclose the contents t= o any > > other person, use it for any purpose, or store or copy the information = in any > > medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.