From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46541A0A0F for ; Wed, 30 Jun 2021 13:11:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE3E84125B; Wed, 30 Jun 2021 13:11:46 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id AB42340141 for ; Wed, 30 Jun 2021 13:11:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10030"; a="272185402" X-IronPort-AV: E=Sophos;i="5.83,311,1616482800"; d="scan'208";a="272185402" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2021 04:11:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,311,1616482800"; d="scan'208";a="419957105" Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by fmsmga007.fm.intel.com with ESMTP; 30 Jun 2021 04:11:43 -0700 Received: from irsmsx601.ger.corp.intel.com (163.33.146.7) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 30 Jun 2021 12:11:42 +0100 Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by irsmsx601.ger.corp.intel.com ([163.33.146.7]) with mapi id 15.01.2242.008; Wed, 30 Jun 2021 12:11:42 +0100 From: "Richardson, Bruce" To: Dmitry Kozlyuk , Rob Scheepens CC: "users@dpdk.org" , "bluca@debian.org" Thread-Topic: [dpdk-users] Build on Windows not working: "ERROR: Program 'echo' not found" Thread-Index: AQHXbZJAubsKVXP0dUKyYAwd8SRvMKssY3XQ Date: Wed, 30 Jun 2021 11:11:42 +0000 Message-ID: References: <20210629234942.2efad3e2@sovereign> <997A3507-0829-4A9A-8402-C87F34556162@nutanix.com> <20210630122807.1cdeb496@sovereign> In-Reply-To: <20210630122807.1cdeb496@sovereign> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-users] Build on Windows not working: "ERROR: Program 'echo' not found" X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" +Luca who also helped with getting docs building > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Wednesday, June 30, 2021 10:28 AM > To: Rob Scheepens > Cc: users@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-users] Build on Windows not working: "ERROR: Program > 'echo' not found" >=20 > 2021-06-30 08:41 (UTC+0000), Rob Scheepens: > > Hello Dmitry, > > > > That works, thanks! > > > > Is there an issue open for this? If not, should I create one? >=20 > Not yet and I'm not sure is it Meson or DPDK issue. > Meson's behavior changed between 0.57 and 0.58.1 > seemingly due to another feature added, on the other hand, > DPDK code didn't work on Windows as expected. >=20 > +Bruce, build system maintainer. > I think we'll sort this out, thank you for reporting the bug. >=20 > Bruce, in doc/meson.build, we have this: >=20 > doc_targets =3D [] > doc_target_names =3D [] > subdir('api') > subdir('guides') >=20 > if doc_targets.length() =3D=3D 0 > message =3D 'No docs targets found' > else > message =3D 'Building docs:' > endif > run_target('doc', command: ['echo', message, doc_target_names], > depends: doc_targets) >=20 > First, why there's no early exit if enable_docs=3Dfalse? >=20 Looking through the code, I believe things are done this way so that, if we= have the dependencies of sphinx and doxygen, you can do "ninja doc" to bui= ld the documentation even if "enable_docs" is set to false. We always have = a valid "doc" target, irrespective of that setting, which controls only whe= ther the docs are built as part of a regular build or not. Regards, /Bruce