bond mode 8023ad LACP system id changes when link goes down

bond mode 8023ad LACP system id changes when link goes down

[Viktor Vasiliev]

Hello,

I have troubles with bond mode 8023ad. I have two bonded network 
adapters connected to my router. When one of router's ports goes down 
and second port continues working, then LACP system id is changed. As a 
result, I got the message: "preferred partner system not equal self 
system". I expect that system id should not change in this case. I tried 
to set bond mac using rte_eth_bond_mac_address_set, but it did not help. 
The system id in LACP frames was copied from mac address of physical 
network adapter. I've looked at DPDK source code, 
drivers/net/bonding/rte_eth_bond_8023ad.c, functions 
bond_mode_8023ad_mac_address_update and bond_mode_8023ad_periodic_cb, 
and found this call:

rte_ether_addr_copy(&slave_addr, &port->actor.system);

where slave_addr is the mac address of physical network adapter. So, 
there's no chance to use manually assigned bond mac as actor system id. 
I've modified the sources like this and rebuild DPDK:

rte_ether_addr_copy(/*&slave_addr*/ &(bond_dev->data->mac_addrs[0]), 
&slave->actor.system);

Now it works, bond mac is used as actor system id in LACP frames, and 
there's no "preferred partner system not equal self system" message.

Please tell if there's another way to achieve my goal, or modifying DPDK 
sources is the only solution. If so, is it a bug in DPDK?

Thank you in advance,

Viktor Vasiliev