From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: web@dpdk.org
Subject: Re: [dpdk-web] [PATCH v2] update css colours and shadows
Date: Thu, 18 Feb 2016 19:05:24 +0100 [thread overview]
Message-ID: <2405915.zzedV3v81e@xps13> (raw)
In-Reply-To: <1455544818-16664-1-git-send-email-harry.van.haaren@intel.com>
Hi Harry,
I like the new CSS. I would like to apply it but there are 2 small nits
to confirm below.
2016-02-15 14:00, Harry van Haaren:
> Change colours and shadows to align with DPDK logo,
> rounded corners reduced, fade times shortend,
> changed colour beside code snippet and event.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
[...]
> header h1 {
> - margin: 0 auto 0.5em;
> - padding: 0;
> + margin: 0 auto 0.75em;
> + padding: -0.5em;
> + padding-top: 0.25em;
Why the negative padding? It seems to have no effect.
May I remove it before applying?
Sometimes you use lowercase for colors and other times uppercase.
No problem to convert in lowercase before applying?
next prev parent reply other threads:[~2016-02-18 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 13:24 [dpdk-web] [PATCH] " Harry van Haaren
2016-02-12 15:46 ` Thomas Monjalon
2016-02-15 14:00 ` Van Haaren, Harry
2016-02-15 14:00 ` [dpdk-web] [PATCH v2] " Harry van Haaren
2016-02-18 18:05 ` Thomas Monjalon [this message]
2016-02-19 8:55 ` Van Haaren, Harry
2016-02-19 11:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2405915.zzedV3v81e@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=web@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).