* [dpdk-web] [PATCH] release 16.07.1
@ 2016-10-26 8:11 Yuanhan Liu
2016-10-26 8:58 ` Van Haaren, Harry
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
0 siblings, 2 replies; 9+ messages in thread
From: Yuanhan Liu @ 2016-10-26 8:11 UTC (permalink / raw)
To: web
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
NOTE: the md5 of the dpdk-16.07.1 tar is not filled, as it's
not been created yet. Hopefully, Thoams could fill that for
me.
Another note: there is a <p> decorator after the "latest stalbe
release" icon, because in my local testing, it can't show 4
icons in one row. Thus I splitted it them in two rows, each with
2 icons.
Thanks.
---
download.html | 6 +++++-
rel.html | 6 +++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/download.html b/download.html
index 919c41e..30b2086 100644
--- a/download.html
+++ b/download.html
@@ -43,7 +43,11 @@
<i class="material-icons">archive</i>
Latest Version: 16.07
</a><!-- no whitespace
- --><a href="/rel" class="button">
+ --><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz" class="button">
+ <i class="material-icons">archive</i>
+ Latest Stable Version: 16.07.1
+ </a><!-- no whitespace
+ --><p><a href="/rel" class="button">
<i class="material-icons">view_list</i>
Other Versions
</a><!-- no whitespace
diff --git a/rel.html b/rel.html
index b95403a..960daa4 100644
--- a/rel.html
+++ b/rel.html
@@ -59,9 +59,9 @@
<th>md5</th>
</tr>
<tr>
- <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
- <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
- <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
+ <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
+ <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 October 26</a></td>
+ <td><pre>XXX</pre></td>
</tr>
<tr>
<td><a href="http://fast.dpdk.org/rel/dpdk-16.04.tar.xz">DPDK 16.04</a></td>
--
1.9.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-web] [PATCH] release 16.07.1
2016-10-26 8:11 [dpdk-web] [PATCH] release 16.07.1 Yuanhan Liu
@ 2016-10-26 8:58 ` Van Haaren, Harry
2016-10-26 9:54 ` Thomas Monjalon
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
1 sibling, 1 reply; 9+ messages in thread
From: Van Haaren, Harry @ 2016-10-26 8:58 UTC (permalink / raw)
To: Yuanhan Liu, web
Hi,
Looks ok, I have a few comments:
> -----Original Message-----
> Another note: there is a <p> decorator after the "latest stalbe
> release" icon, because in my local testing, it can't show 4
> icons in one row. Thus I splitted it them in two rows, each with
> 2 icons.
I'm ok with the split into 2x2 grid, centering the buttons makes the page look better IMO.
I can patch after this is applied.
> - <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
> - <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
Looks like release notes date is being updated, but it still points to the same link?
> - <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
> + <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
It is not clear that this is the stable branch. Would it make more sense to rename to "DPDK Stable 16.07.1" or similar to make it more obvious this release has backports/fixes?
If there's no concerns about naming or release-notes link, please apply patch as is and I'll push a new patch to center the buttons on the download page.
Regards, -Harry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-web] [PATCH] release 16.07.1
2016-10-26 8:58 ` Van Haaren, Harry
@ 2016-10-26 9:54 ` Thomas Monjalon
2016-10-26 10:01 ` Van Haaren, Harry
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2016-10-26 9:54 UTC (permalink / raw)
To: Van Haaren, Harry; +Cc: web
2016-10-26 08:58, Van Haaren, Harry:
> Hi,
>
> Looks ok, I have a few comments:
>
> > -----Original Message-----
> > Another note: there is a <p> decorator after the "latest stalbe
> > release" icon, because in my local testing, it can't show 4
> > icons in one row. Thus I splitted it them in two rows, each with
> > 2 icons.
>
> I'm ok with the split into 2x2 grid, centering the buttons makes the page look better IMO.
> I can patch after this is applied.
I've sent a v2 with buttons in one row.
(actually sent 2 times, first on dev@ :/ )
> > - <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
> > - <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
>
> Looks like release notes date is being updated, but it still points to the same link?
No, 16.07 is replaced by 16.07.1 in this list.
The whole list of every versions is available at http://fast.dpdk.org/rel/
> > - <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
> > + <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
>
> It is not clear that this is the stable branch. Would it make more sense to rename to "DPDK Stable 16.07.1" or similar to make it more obvious this release has backports/fixes?
I don't think it is needed.
This list could point only to the latest tar.xz of each major version (16.11, 16.07.1, etc).
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-web] [PATCH] release 16.07.1
2016-10-26 9:54 ` Thomas Monjalon
@ 2016-10-26 10:01 ` Van Haaren, Harry
0 siblings, 0 replies; 9+ messages in thread
From: Van Haaren, Harry @ 2016-10-26 10:01 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: web
> -----Original Message-----
> > I'm ok with the split into 2x2 grid, centering the buttons makes the page look better IMO.
> > I can patch after this is applied.
>
> I've sent a v2 with buttons in one row.
> (actually sent 2 times, first on dev@ :/ )
Tested, looks good.
Nit pick, the buttons on rel.html are not centered. I can send a patch after this is applied.
> > Looks like release notes date is being updated, but it still points to the same link?
> No, 16.07 is replaced by 16.07.1 in this list.
> The whole list of every versions is available at http://fast.dpdk.org/rel/
Ok.
> > > - <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
> > > + <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK
> 16.07.1</a></td>
> >
> > It is not clear that this is the stable branch. Would it make more sense to rename to "DPDK
> Stable 16.07.1" or similar to make it more obvious this release has backports/fixes?
>
> I don't think it is needed.
> This list could point only to the latest tar.xz of each major version (16.11, 16.07.1, etc).
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-web] [PATCH v2] release 16.07.1
2016-10-26 8:11 [dpdk-web] [PATCH] release 16.07.1 Yuanhan Liu
2016-10-26 8:58 ` Van Haaren, Harry
@ 2016-10-26 9:48 ` Thomas Monjalon
2016-10-26 10:13 ` Yuanhan Liu
2016-10-26 10:31 ` [dpdk-web] [PATCH v3] " Thomas Monjalon
1 sibling, 2 replies; 9+ messages in thread
From: Thomas Monjalon @ 2016-10-26 9:48 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: web
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
v2:
- buttons on one row
- md5 of tarball
---
content.css | 4 ++--
download.html | 10 +++++++---
rel.html | 6 +++---
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/content.css b/content.css
index 4bd7240..4b469bd 100644
--- a/content.css
+++ b/content.css
@@ -105,11 +105,11 @@ section .button:hover {
}
section#download .button,
section#rel .button {
- width: 26%;
+ width: 18%;
}
section#download .button + .button,
section#rel .button + .button {
- margin-left: 11%;
+ margin-left: 9.3%;
}
section#events .button {
padding: 1em 3em;
diff --git a/download.html b/download.html
index 919c41e..dc5c802 100644
--- a/download.html
+++ b/download.html
@@ -41,15 +41,19 @@
<h2>Download</h2>
<a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz" class="button">
<i class="material-icons">archive</i>
- Latest Version: 16.07
+ Latest Major<br>16.07
+ </a><!-- no whitespace
+ --><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz" class="button">
+ <i class="material-icons">archive</i>
+ Latest Stable<br>16.07.1
</a><!-- no whitespace
--><a href="/rel" class="button">
<i class="material-icons">view_list</i>
- Other Versions
+ <br>Other Versions
</a><!-- no whitespace
--><a href="/doc/quick-start" class="button">
<i class="material-icons">access_time</i>
- Quick Start Instructions
+ <br>Quick Start
</a>
<ul>
<h3>Applications</h3>
diff --git a/rel.html b/rel.html
index b95403a..ffdc513 100644
--- a/rel.html
+++ b/rel.html
@@ -59,9 +59,9 @@
<th>md5</th>
</tr>
<tr>
- <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
- <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
- <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
+ <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
+ <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 October 26</a></td>
+ <td><pre>28b3831cebfa94ca533418c17de25986</pre></td>
</tr>
<tr>
<td><a href="http://fast.dpdk.org/rel/dpdk-16.04.tar.xz">DPDK 16.04</a></td>
--
2.7.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-web] [PATCH v2] release 16.07.1
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
@ 2016-10-26 10:13 ` Yuanhan Liu
2016-10-26 10:31 ` [dpdk-web] [PATCH v3] " Thomas Monjalon
1 sibling, 0 replies; 9+ messages in thread
From: Yuanhan Liu @ 2016-10-26 10:13 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: web
On Wed, Oct 26, 2016 at 11:48:00AM +0200, Thomas Monjalon wrote:
> From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Looks good. Thanks!
--yliu
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-web] [PATCH v3] release 16.07.1
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
2016-10-26 10:13 ` Yuanhan Liu
@ 2016-10-26 10:31 ` Thomas Monjalon
2016-10-26 11:08 ` Van Haaren, Harry
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2016-10-26 10:31 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: web
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
A quick download button is added for the latest stable release.
The release notes points to http://dpdk.org/doc/guides-16.07/
which will be updated for each stable release,
while http://dpdk.org/doc/guides/ should be the latest from the
master branch.
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
v3:
- keep buttons layout for rel.html
- update release notes link
v2:
- buttons on one row
- md5 of tarball
---
content.css | 8 ++++++--
download.html | 10 +++++++---
rel.html | 6 +++---
3 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/content.css b/content.css
index 4bd7240..1b3d05d 100644
--- a/content.css
+++ b/content.css
@@ -103,11 +103,15 @@ section .button:hover {
-o-transition: background-color .08s linear;
transition: background-color .08s linear;
}
-section#download .button,
+section#download .button {
+ width: 18%;
+}
+section#download .button + .button {
+ margin-left: 9.3%;
+}
section#rel .button {
width: 26%;
}
-section#download .button + .button,
section#rel .button + .button {
margin-left: 11%;
}
diff --git a/download.html b/download.html
index 919c41e..dc5c802 100644
--- a/download.html
+++ b/download.html
@@ -41,15 +41,19 @@
<h2>Download</h2>
<a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz" class="button">
<i class="material-icons">archive</i>
- Latest Version: 16.07
+ Latest Major<br>16.07
+ </a><!-- no whitespace
+ --><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz" class="button">
+ <i class="material-icons">archive</i>
+ Latest Stable<br>16.07.1
</a><!-- no whitespace
--><a href="/rel" class="button">
<i class="material-icons">view_list</i>
- Other Versions
+ <br>Other Versions
</a><!-- no whitespace
--><a href="/doc/quick-start" class="button">
<i class="material-icons">access_time</i>
- Quick Start Instructions
+ <br>Quick Start
</a>
<ul>
<h3>Applications</h3>
diff --git a/rel.html b/rel.html
index b95403a..3475264 100644
--- a/rel.html
+++ b/rel.html
@@ -59,9 +59,9 @@
<th>md5</th>
</tr>
<tr>
- <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
- <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
- <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
+ <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
+ <td><a href="/doc/guides-16.07/rel_notes/release_16_07.html">2016 October 26</a></td>
+ <td><pre>28b3831cebfa94ca533418c17de25986</pre></td>
</tr>
<tr>
<td><a href="http://fast.dpdk.org/rel/dpdk-16.04.tar.xz">DPDK 16.04</a></td>
--
2.7.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-web] [PATCH v3] release 16.07.1
2016-10-26 10:31 ` [dpdk-web] [PATCH v3] " Thomas Monjalon
@ 2016-10-26 11:08 ` Van Haaren, Harry
2016-10-26 11:17 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Van Haaren, Harry @ 2016-10-26 11:08 UTC (permalink / raw)
To: Thomas Monjalon, Yuanhan Liu; +Cc: web
> From: web [mailto:web-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, October 26, 2016 11:32 AM
> To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Cc: web@dpdk.org
> Subject: [dpdk-web] [PATCH v3] release 16.07.1
>
> From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> A quick download button is added for the latest stable release.
>
> The release notes points to http://dpdk.org/doc/guides-16.07/
> which will be updated for each stable release,
> while http://dpdk.org/doc/guides/ should be the latest from the
> master branch.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
V3 tested, acked as before. Thanks guys!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-web] [PATCH v3] release 16.07.1
2016-10-26 11:08 ` Van Haaren, Harry
@ 2016-10-26 11:17 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2016-10-26 11:17 UTC (permalink / raw)
To: Van Haaren, Harry; +Cc: web
2016-10-26 11:08, Van Haaren, Harry:
> > From: web [mailto:web-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, October 26, 2016 11:32 AM
> > To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Cc: web@dpdk.org
> > Subject: [dpdk-web] [PATCH v3] release 16.07.1
> >
> > From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> > A quick download button is added for the latest stable release.
> >
> > The release notes points to http://dpdk.org/doc/guides-16.07/
> > which will be updated for each stable release,
> > while http://dpdk.org/doc/guides/ should be the latest from the
> > master branch.
> >
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> V3 tested, acked as before. Thanks guys!
Applied, thanks for the review
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-10-26 11:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-26 8:11 [dpdk-web] [PATCH] release 16.07.1 Yuanhan Liu
2016-10-26 8:58 ` Van Haaren, Harry
2016-10-26 9:54 ` Thomas Monjalon
2016-10-26 10:01 ` Van Haaren, Harry
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
2016-10-26 10:13 ` Yuanhan Liu
2016-10-26 10:31 ` [dpdk-web] [PATCH v3] " Thomas Monjalon
2016-10-26 11:08 ` Van Haaren, Harry
2016-10-26 11:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).