Re: [dpdk-web] [PATCH] download: add icons to main 3 links

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-02-19 14:35, Harry van Haaren:
> This patch integrates icons from the Google material icon set
> for the download, quick-start, and web-browsing links.

I agree on the idea.

> The links are layed out using panes horizontally, and re-ordered:
> Download | Quick Start | Older versions and Web interface

"Web interface" does not well describe the cgit link.
What about this kind of title? "Other Versions & git"

> Defines a new .well CSS attribute for panes behind icons.

What means "well"? Why not button?

> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> 
> There are multiple ways to link to the Google icons, this patch
> includes the stylesheet, as it its the most flexible for using
> multiple icons.
> 
> Other options are to save the SVG code directly in the page
> (cannot resize icon easily) or save the .svg to a file and
> display it (requires adding each icon to be used manually).
> Unless you feel strongly against including the stylesheet,
> this is the most effective solution.

Yes the stylesheet include looks good.

> +.well {
> +	background-color: rgba(0, 35, 60, 0.07);
> +	text-align: center;
> +	padding-top: 1em;
> +	padding-bottom: 1em;
> +	margin-left: 0.7em;
> +	margin-right: 0.7em;
> +	box-shadow: inset 2px 2px 2px rgba(0,0,0,0.3);
> +	border-radius: 0.7em 0.7em 0.7em 0.7em;
> +	color : #00233b;
> +}

I think the orange hover effect is missing.

Thanks Harry for bringing some fresh air :)