From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B5167C55C for ; Fri, 19 Feb 2016 16:38:29 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id b205so73409870wmb.1 for ; Fri, 19 Feb 2016 07:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=YLgGVeBFZRHcwP/VQc0rwmjgT0mB6IgzKIxd3tJsetM=; b=os18AtrH93VFDGz9ww3BIfOgLSJ2y2T7ep4tUC4aaakIqW0Ya0wm0/R7LcEyYGYY97 aUeXM81sYQ3j6/AuByoDJnN6JI6NKhr5ESR4lRwx46rCk05cXFHmgqFsEdETx0jdjf5P n8VkWKR0thRUFbLIz5mByqoiR/jJxY/cur6kQdQ5aFtfubNQLQZsmnX3INCD4k5rdq1V Qsd28ZJLfxu9Pqfmt62sLxAXym92Oc/iJ9WVFr37JW+2NtSltcKjkbOaHYBn9VUH33Pi RLpqh9CeHDGLaMagNjoTKUrelkAbO0uIuXEW5LXgfrU+K9cRSDcM3x8wqjLDEhLVPMtv z6dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=YLgGVeBFZRHcwP/VQc0rwmjgT0mB6IgzKIxd3tJsetM=; b=S6mM1IMyDE4KRac5HqUSFjySqUmpIsL2TNNKCNv4wV4ABjxvHRDmguCeekbpAPewLu hE/TR7j55zyx9q9ZDmhgk/YEHPV9PqACLq5cYMFpONLAOFrhH5jhRgZtbYJFJg7RSuxQ RS5Zyaut0sxNoTCs+7ULPDDOL3cuIAusF428O4qFcSwaxJ0wnEJGiBA2lqfA+rflatt7 mdfZPmTQo8AK7Iai+ZK7D1YQv8Ocupn6IbVdOJ3U2nQxrBJJvL6IhilQ0mnLhSv1Yimi 9L6Ze3oUJ2iC3bfdxhWxtaxSZ45+MBo0NhPv68t86nd19uDgCCMEwDLDEFwdaFRQqh9j xO7w== X-Gm-Message-State: AG10YOQLaUDgfyJ/rGPZfO7q/+YlT0eGdAXZ8CSaZX2GEFj6Ik4jXdmluVDmr0bU7so0Rutg X-Received: by 10.194.71.46 with SMTP id r14mr15619502wju.100.1455896309553; Fri, 19 Feb 2016 07:38:29 -0800 (PST) Received: from xps13.localnet (111.204.154.77.rev.sfr.net. [77.154.204.111]) by smtp.gmail.com with ESMTPSA id h132sm8123660wmf.9.2016.02.19.07.38.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 07:38:28 -0800 (PST) From: Thomas Monjalon To: Harry van Haaren Date: Fri, 19 Feb 2016 16:36:55 +0100 Message-ID: <4769307.x4D9cxKz1O@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1455892502-14350-1-git-send-email-harry.van.haaren@intel.com> References: <1455892502-14350-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: web@dpdk.org Subject: Re: [dpdk-web] [PATCH] download: add icons to main 3 links X-BeenThere: web@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: website maintenance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 15:38:29 -0000 2016-02-19 14:35, Harry van Haaren: > This patch integrates icons from the Google material icon set > for the download, quick-start, and web-browsing links. I agree on the idea. > The links are layed out using panes horizontally, and re-ordered: > Download | Quick Start | Older versions and Web interface "Web interface" does not well describe the cgit link. What about this kind of title? "Other Versions & git" > Defines a new .well CSS attribute for panes behind icons. What means "well"? Why not button? > Signed-off-by: Harry van Haaren > --- > > There are multiple ways to link to the Google icons, this patch > includes the stylesheet, as it its the most flexible for using > multiple icons. > > Other options are to save the SVG code directly in the page > (cannot resize icon easily) or save the .svg to a file and > display it (requires adding each icon to be used manually). > Unless you feel strongly against including the stylesheet, > this is the most effective solution. Yes the stylesheet include looks good. > +.well { > + background-color: rgba(0, 35, 60, 0.07); > + text-align: center; > + padding-top: 1em; > + padding-bottom: 1em; > + margin-left: 0.7em; > + margin-right: 0.7em; > + box-shadow: inset 2px 2px 2px rgba(0,0,0,0.3); > + border-radius: 0.7em 0.7em 0.7em 0.7em; > + color : #00233b; > +} I think the orange hover effect is missing. Thanks Harry for bringing some fresh air :)