From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <web-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C32242870; Thu, 30 Mar 2023 14:48:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 641A9410D3; Thu, 30 Mar 2023 14:48:39 +0200 (CEST) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by mails.dpdk.org (Postfix) with ESMTP id BF46840E25; Thu, 30 Mar 2023 14:48:37 +0200 (CEST) Received: by mail-ua1-f50.google.com with SMTP id q8so6002731uas.7; Thu, 30 Mar 2023 05:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680180517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HOQ3l6rAKdV/hvc+uuX2drxbW+N9jbmj3JEDJPCfIr4=; b=iuu+L7k9SYGYQ469ZzQpqAJyA2HNPk3jvcyHvBLuvhpK0Cp/OwSYOM88cIC40X2/GE mUpakrPKWjzuNGcSMRpnxk35shS5wE5gY3KpsjGXf8W7S6oZMEyHnQhY8KvJ0+Z7Kih8 HwPnRjV10G8Ru94K7IOjCNOImw/B5PDhV2I/59hhUd+vhdCZ6aM537BRvZRNe9CA+kdE 8diHRDrJXZRQEupXK2AY4pKaa4lRxUrIeZc2ji2/qVbs1D1uZ/1UNBzhoIA4d+CkwOzt xt03yEMsOUB+EH2sOwx71cCNKOmDAxIV0vlw/8YOGJic6jlAlePeXzPPbirvM3NzrVPb FK9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680180517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HOQ3l6rAKdV/hvc+uuX2drxbW+N9jbmj3JEDJPCfIr4=; b=5BAO+ty3/hMT80kU1windYnicYU55b9BY7+Kup+4TCUfYuAHMuz7W/UaLPrRP7Dm+N 5HdqgFNLxVsVwr8ncocGTnN+0DRq/gvbIz7czwEzUJbHMB4SHt+SH3IJ5hN/tmSmWpj8 ubwOU/iJfm/g6MjHjmfhLfeoAXbpA95wAJTbNXx9Ys//Goyhmm6fhjacDQu7EaQSXkCY t4D1v0Fg8q0jEKGnFOvEVs4ZtrP0z1hSe3SSSFcVmdIVz+xMjNghXCHGgTsgOkHjlowY 7U9sb3ScdtRHOf5QFApBeEHi7r7bGGVfiZEtAmzPZfJIRBPTlM78xBstK3lNuipq5iJ6 tCbg== X-Gm-Message-State: AAQBX9dMuYSKLuJIdD9eWki4zHDxg5HvH6kkQpGDJ5oI3jf/gtUhCQUv l2KmMzFBW43K8uOCbRqGyTIhw8m+rv8UceY864o= X-Google-Smtp-Source: AKy350YG3CTLWb+zeioFSAT1fNaQ3a+BQ5SJB2ewRr0MCTmkbxv5+W0X1Qcv6vt6qY6DxLxInGNeKBh8ieqXAp9FlN0= X-Received: by 2002:a1f:16c7:0:b0:40e:fee9:667a with SMTP id 190-20020a1f16c7000000b0040efee9667amr13118927vkw.3.1680180517113; Thu, 30 Mar 2023 05:48:37 -0700 (PDT) MIME-Version: 1.0 References: <20230213092616.3589932-1-jerinj@marvell.com> <11338869.jrtcCam0TZ@thomas> <CALBAE1Pg3hLnbKN3revGVGzk=sRhTL6iDdJx-GQC25vaT4Pw0Q@mail.gmail.com> In-Reply-To: <CALBAE1Pg3hLnbKN3revGVGzk=sRhTL6iDdJx-GQC25vaT4Pw0Q@mail.gmail.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Thu, 30 Mar 2023 18:18:11 +0530 Message-ID: <CALBAE1P6Mh0GZUhgiUYM+kLig5s_Ss5zZZxXrm8=ggvinWcnog@mail.gmail.com> Subject: Re: [dpdk-web] [RFC PATCH] process: new library approval in principle To: Thomas Monjalon <thomas@monjalon.net> Cc: Jerin Jacob <jerinj@marvell.com>, web@dpdk.org, dev@dpdk.org, techboard@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: web@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK website maintenance <web.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/web>, <mailto:web-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/web/> List-Post: <mailto:web@dpdk.org> List-Help: <mailto:web-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/web>, <mailto:web-request@dpdk.org?subject=subscribe> Errors-To: web-bounces@dpdk.org On Wed, Mar 15, 2023 at 7:17=E2=80=AFPM Jerin Jacob <jerinjacobk@gmail.com>= wrote: > > On Fri, Mar 3, 2023 at 11:55=E2=80=AFPM Thomas Monjalon <thomas@monjalon.= net> wrote: > > > > Thanks for formalizing our process. > > Thanks for the review. Ping > > > > > 13/02/2023 10:26, jerinj@marvell.com: > > > --- /dev/null > > > +++ b/content/process/_index.md > > > > First question: is the website the best place for this process? > > > > Inside the code guides, we have a contributing section, > > but I'm not sure it is a good fit for the decision process. > > > > In the website, you are creating a new page "process". > > Is it what we want? > > What about making it a sub-page of "Technical Board"? > > Since it is a process, I thought of keeping "process" page. > No specific opinion on where to add it. > If not other objections, Then I can add at > doc/guides/contributing/new_library_policy.rst in DPDK repo. > Let me know if you think better name or better place to keep the file > > > > > > @@ -0,0 +1,33 @@ > > > ++++ > > > +title =3D "Process" > > > +weight =3D "9" > > > ++++ > > > + > > > +## Process for new library approval in principle > > > + > > > +### Rational > > > > s/Rational/Rationale/ > > Ack > > > > > > + > > > +Adding a new library to DPDK codebase with proper RFC and then full = patch-sets is > > > +significant work and getting early approval-in-principle that a libr= ary help DPDK contributors > > > +avoid wasted effort if it is not suitable for various reasons. > > > > That's a long sentence we could split. > > OK Changing as: > > Adding a new library to DPDK codebase with proper RFC and full > patch-sets is significant work. > > Getting early approval-in-principle that a library can help DPDK > contributors avoid wasted effort > if it is not suitable for various reasons > > > > > > > + > > > +### Process > > > + > > > +1. When a contributor would like to add a new library to DPDK code b= ase, the contributor must send > > > +the following items to DPDK mailing list for TB approval-in-principl= e. > > > > I think we can remove "code base". > > Ack > > > > > TB should be explained: Technical Board. > > Ack > > > > > > + > > > + - Purpose of the library. > > > + - Scope of the library. > > > > Not sure I understand the difference between Purpose and Scope. > > Purpose =E2=86=92 The need for the library > Scope =E2=86=92 I meant the work scope associated with it. > > I will change "Scope of the library" to, > > - Scope of work: Outline the various additional tasks planned for this > library, such as developing new test applications, adding new drivers, > and updating existing applications. > > > > > > + - Any licensing constraints. > > > + - Justification for adding to DPDK. > > > + - Any other implementations of the same functionality in other li= bs/products and how this version differs. > > > > libs/products -> libraries/projects > > Ack > > > > > > + - Public API specification header file as RFC > > > + - Optional and good to have. > > > > You mean providing API is optional at this stage? > > Yes. I think, TB can request if more clarity is needed as mentioned below= . > "TB may additionally request this collateral if needed to get more > clarity on scope and purpose" > > > > > > + - TB may additionally request this collateral if needed to ge= t more clarity on scope and purpose. > > > + > > > +2. TB to schedule discussion on this in upcoming TB meeting along wi= th author. Based on the TB > > > +schedule and/or author availability, TB may need maximum three TB me= eting slots. > > > > Better to translate the delay into weeks: 5 weeks? > > Ack > > > > > > + > > > +3. Based on mailing list and TB meeting discussions, TB to vote for = approval-in-principle and share > > > +the decision in the mailing list. > > > > I think we should say here that it is safe to start working > > on the implementation after this step, > > but the patches will need to match usual quality criterias > > to be effectively accepted. > > OK. > > I will add the following, > > 4. Once TB approves the library in principle, it is safe to start > working on its implementation. > However, the patches will need to meet the usual quality criteria in > order to be effectively accepted. > > > > > >