From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, "web@dpdk.org" <web@dpdk.org>
Subject: Re: [dpdk-web] [PATCH] release 16.07.1
Date: Wed, 26 Oct 2016 08:58:11 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129ACBAB@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1477469498-19637-1-git-send-email-yuanhan.liu@linux.intel.com>
Hi,
Looks ok, I have a few comments:
> -----Original Message-----
> Another note: there is a <p> decorator after the "latest stalbe
> release" icon, because in my local testing, it can't show 4
> icons in one row. Thus I splitted it them in two rows, each with
> 2 icons.
I'm ok with the split into 2x2 grid, centering the buttons makes the page look better IMO.
I can patch after this is applied.
> - <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.tar.xz">DPDK 16.07</a></td>
> - <td><a href="/doc/guides/rel_notes/release_16_07.html">2016 July 28</a></td>
Looks like release notes date is being updated, but it still points to the same link?
> - <td><pre>690a2bb570103e58d12f9806e8bf21be</pre></td>
> + <td><a href="http://fast.dpdk.org/rel/dpdk-16.07.1.tar.xz">DPDK 16.07.1</a></td>
It is not clear that this is the stable branch. Would it make more sense to rename to "DPDK Stable 16.07.1" or similar to make it more obvious this release has backports/fixes?
If there's no concerns about naming or release-notes link, please apply patch as is and I'll push a new patch to center the buttons on the download page.
Regards, -Harry
next prev parent reply other threads:[~2016-10-26 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 8:11 Yuanhan Liu
2016-10-26 8:58 ` Van Haaren, Harry [this message]
2016-10-26 9:54 ` Thomas Monjalon
2016-10-26 10:01 ` Van Haaren, Harry
2016-10-26 9:48 ` [dpdk-web] [PATCH v2] " Thomas Monjalon
2016-10-26 10:13 ` Yuanhan Liu
2016-10-26 10:31 ` [dpdk-web] [PATCH v3] " Thomas Monjalon
2016-10-26 11:08 ` Van Haaren, Harry
2016-10-26 11:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6129ACBAB@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=web@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).