From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com>
To: "'gowrishankar'" <gowrishankar.m@linux.vnet.ibm.com>, <dev@dpdk.org>
Cc: "'Bruce Richardson'" <bruce.richardson@intel.com>,
"'Konstantin Ananyev'" <konstantin.ananyev@intel.com>,
"'Thomas Monjalon'" <thomas.monjalon@6wind.com>,
"'Cristian Dumitrescu'" <cristian.dumitrescu@intel.com>,
"'Pradeep'" <pradeep@us.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le
Date: Mon, 18 Jul 2016 16:54:11 +0800 [thread overview]
Message-ID: <000101d1e0d1$f7ffacd0$e7ff0670$@linux.vnet.ibm.com> (raw)
In-Reply-To: <5789E94A.6000603@linux.vnet.ibm.com>
Gowrishankar,
I still get this error with the v3 patches. My OS is Ubuntu 16.04 LTS
ppc64le. GCC version: Ubuntu/IBM 5.3.1-14ubuntu2
Can you help to check again?
In file included from
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function
'transition4':
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],
^
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],
^
-----Original Message-----
From: gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com]
Sent: 2016年7月16日 15:59
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>; dev@dpdk.org
Cc: 'Bruce Richardson' <bruce.richardson@intel.com>; 'Konstantin Ananyev'
<konstantin.ananyev@intel.com>; 'Thomas Monjalon'
<thomas.monjalon@6wind.com>; 'Cristian Dumitrescu'
<cristian.dumitrescu@intel.com>; 'Pradeep' <pradeep@us.ibm.com>
Subject: Re: [PATCH v2 0/6] enable lpm, acl and other missing libraries in
ppc64le
Hi Chao,
I did not face this error. Even I verified today with tip of master
6596554... .
However I had patch conflict for examples/l3fwd/l3fwd_em.c which is fixed
now and v3 patch set sent recently. Could you please check.
Thanks,
Gowrishankar
On Friday 15 July 2016 08:45 AM, Chao Zhu wrote:
> Gowrishankar,
>
> When I tried the patches, I got some compilation error:
>
> In file included from
> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:
> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function
> 'transition4':
> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
> dereferencing type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
> *indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],
> ^
> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
> dereferencing type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
> *indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],
>
> Can you help to take a look?
>
>
> -----Original Message-----
> From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com]
> Sent: 2016年7月10日 15:51
> To: dev@dpdk.org
> Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>; Cristian Dumitrescu
> <cristian.dumitrescu@intel.com>; Pradeep <pradeep@us.ibm.com>;
> gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in
> ppc64le
>
> From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
>
> This patchset enables LPM, ACL and other few missing libs in ppc64le
> and also address few patches in related examples (ip_pipeline and l3fwd).
>
> Test report:
> LPM and ACL unit tests verified as in patch set v1.
> Same results as before observed.
>
> v2 changes:
> - enabling libs in config included as part of lib changes itself.
>
> gowrishankar (6):
> lpm: add altivec intrinsics for dpdk lpm on ppc_64
> acl: add altivec intrinsics for dpdk acl on ppc_64
> ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
> table: cache align rte_bucket_4_8
> sched: enable sched library for ppc64le
> l3fwd: add altivec support for em_hash_key
>
> app/test-acl/main.c | 4 +
> app/test/test_xmmt_ops.h | 16 +
> config/defconfig_ppc_64-power8-linuxapp-gcc | 7 -
> examples/ip_pipeline/cpu_core_map.c | 12 +-
> examples/ip_pipeline/init.c | 4 +
> examples/l3fwd/l3fwd_em.c | 8 +
> lib/librte_acl/Makefile | 2 +
> lib/librte_acl/acl.h | 4 +
> lib/librte_acl/acl_run.h | 2 +
> lib/librte_acl/acl_run_altivec.c | 47 +++
> lib/librte_acl/acl_run_altivec.h | 328
> +++++++++++++++++++++
> lib/librte_acl/rte_acl.c | 13 +
> lib/librte_acl/rte_acl.h | 1 +
> .../common/include/arch/ppc_64/rte_vect.h | 60 ++++
> lib/librte_lpm/Makefile | 2 +
> lib/librte_lpm/rte_lpm.h | 2 +
> lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++
> lib/librte_table/rte_table_hash_key8.c | 2 +-
> 18 files changed, 649 insertions(+), 19 deletions(-) create mode
> 100644 lib/librte_acl/acl_run_altivec.c create mode 100644
> lib/librte_acl/acl_run_altivec.h create mode 100644
> lib/librte_eal/common/include/arch/ppc_64/rte_vect.h
> create mode 100644 lib/librte_lpm/rte_lpm_altivec.h
>
> --
> 1.9.1
>
>
>
next prev parent reply other threads:[~2016-07-18 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 7:51 Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 1/6] lpm: add altivec intrinsics for dpdk lpm on ppc_64 Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 2/6] acl: add altivec intrinsics for dpdk acl " Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 3/6] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64 Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 4/6] table: cache align rte_bucket_4_8 Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 5/6] sched: enable sched library for ppc64le Gowrishankar
2016-07-10 7:51 ` [dpdk-dev] [PATCH v2 6/6] l3fwd: add altivec support for em_hash_key Gowrishankar
2016-07-11 8:55 ` [dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le Chao Zhu
2016-07-11 9:37 ` gowrishankar
2016-07-15 3:15 ` Chao Zhu
2016-07-16 7:59 ` gowrishankar
2016-07-18 8:54 ` Chao Zhu [this message]
2016-07-18 13:47 ` gowrishankar muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d1e0d1$f7ffacd0$e7ff0670$@linux.vnet.ibm.com' \
--to=chaozhu@linux.vnet.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=konstantin.ananyev@intel.com \
--cc=pradeep@us.ibm.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).