From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: xuan.ding@intel.com, chenbo.xia@intel.com
Cc: dev@dpdk.org, weix.ling@intel.com
Subject: Re: [PATCH] net/vhost: fix compliant offloading flag
Date: Tue, 28 Jun 2022 11:57:02 +0200 [thread overview]
Message-ID: <00357c27-25b1-a423-1a99-78de21ff519e@redhat.com> (raw)
In-Reply-To: <20220628094246.97223-1-xuan.ding@intel.com>
On 6/28/22 11:42, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch fixes the check to set compliant offloading flag.
> Compliant offloading flag should be set when the
> 'legacy-ol-flags' is true.
>
> Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index d75d256040..24049df58a 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
> goto out_free;
> }
>
> - if (legacy_ol_flags == 0)
> + if (legacy_ol_flags == 1)
> flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
>
> if (dev->device.numa_node == SOCKET_ID_ANY)
Nack, legacy OL flags is NOT compliant. So current implementation is
good.
Regards,
Maxime
next prev parent reply other threads:[~2022-06-28 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 9:42 xuan.ding
2022-06-28 9:57 ` Maxime Coquelin [this message]
2022-06-28 10:28 ` Ding, Xuan
2022-06-28 10:58 ` Ling, WeiX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00357c27-25b1-a423-1a99-78de21ff519e@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=weix.ling@intel.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).