From: Declan Doherty <declan.doherty@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument
Date: Tue, 20 Jun 2017 15:35:07 +0100 [thread overview]
Message-ID: <003924ea-dca1-3a44-1067-3323894c7d69@intel.com> (raw)
In-Reply-To: <1495639634-74846-4-git-send-email-pablo.de.lara.guarch@intel.com>
On 24/05/2017 4:27 PM, Pablo de Lara wrote:
> rte_cryptodev_devices_get() function was parsing a crypto
> device name as an argument, but the function actually
> returns device identifiers of devices that share the
> same crypto driver, so the argument should be driver name, instead.
>
> Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
> CC: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.c | 2 +-
> lib/librte_cryptodev/rte_cryptodev.h | 7 ++++---
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
> index a5a5c36..6880661 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type)
> }
>
> uint8_t
> -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices,
> +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,
> uint8_t nb_devices)
> {
> uint8_t i, count = 0;
Compilation breaks after this change, needs next patch to build
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index f307b3b..89093f6 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -464,9 +464,10 @@ extern uint8_t
> rte_cryptodev_count_devtype(enum rte_cryptodev_type type);
>
> /**
> - * Get number and identifiers of attached crypto device.
> + * Get number and identifiers of attached crypto devices that
> + * use the same crypto driver.
> *
> - * @param dev_name device name.
> + * @param driver_name driver name.
> * @param devices output devices identifiers.
> * @param nb_devices maximal number of devices.
> *
> @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type);
> * Returns number of attached crypto device.
> */
> uint8_t
> -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices,
> +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,
> uint8_t nb_devices);
> /*
> * Return the NUMA socket to which a device is connected
>
next prev parent reply other threads:[~2017-06-20 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>
2017-05-24 15:27 ` Pablo de Lara
2017-06-20 14:35 ` Declan Doherty [this message]
2017-06-20 17:28 ` De Lara Guarch, Pablo
[not found] ` <20170621062826.21896-1-pablo.de.lara.guarch@intel.com>
2017-06-21 6:28 ` [dpdk-stable] [PATCH v2 " Pablo de Lara
2017-06-23 12:54 ` Declan Doherty
[not found] <1495639541-74649-1-git-send-email-pablo.de.lara.guarch@intel.com>
2017-05-24 15:25 ` [dpdk-stable] [PATCH " Pablo de Lara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003924ea-dca1-3a44-1067-3323894c7d69@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).