From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
Date: Fri, 18 Nov 2016 15:26:59 +0000 [thread overview]
Message-ID: <00696ef7-6fb5-9bb8-5d77-a04d3253f138@intel.com> (raw)
In-Reply-To: <CAD+H9919z+wvjdP31kivhNy+tkPCOHULfNBO=Ae0xSdCGAVA8g@mail.gmail.com>
On 11/18/2016 3:10 PM, Alejandro Lucero wrote:
> Hi Thomas,
>
> I got this email when sending a patch some minutes ago.
>
> The point is I trusted script/checkpatches.sh which did not report those
> warnings.
> Am I doing anything wrong when using checkpatches.sh?
>
>
> ---------- Forwarded message ----------
> From: <checkpatch@dpdk.org>
> Date: Fri, Nov 18, 2016 at 3:04 PM
> Subject: |WARNING| [PATCH] nfp: report link speed using hardware info
> To: test-report@dpdk.org
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>
>
> Test-Label: checkpatch
> Test-Status: WARNING
> http://dpdk.org/patch/17091
>
> _coding style issues_
>
>
> CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects?
> #53: FILE: drivers/net/nfp/nfp_net.c:806:
> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
btw, you can benefit from RTE_DIM:
lib/librte_eal/common/include/rte_common.h:352:
#define RTE_DIM(a) (sizeof (a) / sizeof ((a)[0]))
>
> CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> #91: FILE: drivers/net/nfp/nfp_net.c:856:
> + else {
> +
>
> total: 0 errors, 0 warnings, 2 checks, 68 lines checked
>
next prev parent reply other threads:[~2016-11-18 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 15:04 [dpdk-dev] " Alejandro Lucero
[not found] ` <20161118150433.AD575558B@dpdk.org>
2016-11-18 15:10 ` [dpdk-dev] Fwd: |WARNING| " Alejandro Lucero
2016-11-18 15:24 ` Ferruh Yigit
2016-11-18 15:31 ` Alejandro Lucero
2016-11-18 15:42 ` Alejandro Lucero
2016-11-18 15:44 ` Thomas Monjalon
2016-11-18 15:34 ` Thomas Monjalon
2016-11-18 15:26 ` Ferruh Yigit [this message]
2016-11-18 15:33 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00696ef7-6fb5-9bb8-5d77-a04d3253f138@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).