From: "Hunt, David" <david.hunt@intel.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header
Date: Mon, 11 Dec 2017 10:48:39 +0000 [thread overview]
Message-ID: <00a8ba24-cff4-f88b-f5a7-bcb02d744c5e@intel.com> (raw)
In-Reply-To: <20171128132203.43181-4-marko.kovacevic@intel.com>
Hi Marko,
On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> lib/librte_power/power_acpi_cpufreq.c | 2 +-
> lib/librte_power/{rte_power_common.h => power_common.h} | 6 +++---
> lib/librte_power/rte_power.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
> rename lib/librte_power/{rte_power_common.h => power_common.h} (95%)
>
> diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> index 165ec97..fd1931f 100644
> --- a/lib/librte_power/power_acpi_cpufreq.c
> +++ b/lib/librte_power/power_acpi_cpufreq.c
> @@ -45,7 +45,7 @@
> #include <rte_atomic.h>
>
> #include "power_acpi_cpufreq.h"
> -#include "rte_power_common.h"
> +#include "power_common.h"
>
> #ifdef RTE_LIBRTE_POWER_DEBUG
> #define POWER_DEBUG_TRACE(fmt, args...) do { \
> diff --git a/lib/librte_power/rte_power_common.h b/lib/librte_power/power_common.h
> similarity index 95%
> rename from lib/librte_power/rte_power_common.h
> rename to lib/librte_power/power_common.h
>
--snip--
Could I suggest adding the following into the commit message?
"Rename private header file rte_power_common.h to power_common.h to
prevent private functions from leaking into the documentation."
Apart from that, if you make those changes, you can include my Ack in
the next revision.
Series-Acked-By: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2017-12-11 10:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:22 [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int Marko Kovacevic
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files Marko Kovacevic
2017-11-28 14:17 ` Bruce Richardson
2017-11-29 16:17 ` Marko Kovacevic
2017-12-11 10:44 ` Hunt, David
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 3/4] power: clean up of kvm files Marko Kovacevic
2017-12-11 10:45 ` Hunt, David
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header Marko Kovacevic
2017-12-11 10:48 ` Hunt, David [this message]
2017-11-28 14:16 ` [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int Bruce Richardson
2017-11-29 16:15 ` Marko Kovacevic
2017-12-11 10:43 ` Hunt, David
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 " Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 2/4] power: clean up of power common header Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 3/4] power: clean up of acpi files Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 4/4] power: clean up of kvm files Marko Kovacevic
2018-01-11 23:14 ` [dpdk-dev] [PATCH v3 1/4] power: changed unsigned to unsigned int Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a8ba24-cff4-f88b-f5a7-bcb02d744c5e@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).